public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] lto/114655 - -flto=4 at link time doesn't override -flto=auto at compile time
Date: Tue, 9 Apr 2024 14:52:38 +0200	[thread overview]
Message-ID: <ZhU6FnNsKAZBItz-@kam.mff.cuni.cz> (raw)
In-Reply-To: <20240409124949.31FE93858289@sourceware.org>

> The following adjusts -flto option processing in lto-wrapper to have
> link-time -flto override any compile time setting.
> 
> LTO-boostrapped on x86_64-unknown-linux-gnu, testing in progress.
> 
> OK for trunk and branches?  GCC 11 seems to be unaffected by this.
> 
> Thanks,
> Richard.
> 
> 	PR lto/114655
> 	* lto-wrapper.cc (merge_flto_options): Add force argument.
> 	(merge_and_complain): Do not force here.
> 	(run_gcc): But here to make the link-time -flto option override
> 	any compile-time one.
Looks good to me.  I am actually surprised we propagate -flto settings
from compile time at all.  I guess I never tried it since I never
assumed it to work :)

Honza

       reply	other threads:[~2024-04-09 12:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240409124949.31FE93858289@sourceware.org>
2024-04-09 12:52 ` Jan Hubicka [this message]
2024-04-09 12:56   ` Richard Biener
     [not found] <49506.124040908491001343@us-mta-292.us.mimecast.lan>
2024-04-09 12:51 ` Jakub Jelinek
2024-04-09 12:49 Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhU6FnNsKAZBItz-@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).