From: Jakub Jelinek <jakub@redhat.com>
To: Eric Gallager <egall@gwmail.gwu.edu>
Cc: Christophe Lyon <christophe.lyon@linaro.org>,
gcc-patches@gcc.gnu.org, pinskia@gcc.gnu.org, arsen@gcc.gnu.org,
dmalcolm@redhat.com
Subject: Re: [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748]
Date: Wed, 17 Apr 2024 19:20:31 +0200 [thread overview]
Message-ID: <ZiAE33kEc/IiWNsq@tucnak> (raw)
In-Reply-To: <CAMfHzOsWZ3asQnJcE9sCxQRpHd3t02=DEtn13cF=xhcK+-hQ8w@mail.gmail.com>
On Wed, Apr 17, 2024 at 01:16:43PM -0400, Eric Gallager wrote:
> > --- a/libcpp/configure
> > +++ b/libcpp/configure
> > @@ -2670,6 +2670,9 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu
> >
> >
> >
> > +
> > +
> > +
>
> So, this is kind of a minor style nitpick, but personally, it kind of
> bothers me when autotools goes and inserts a bunch of unnecessary
> blank newlines in the generated output scripts. Does anyone else think
> it'd be worth it to scatter around some of m4's "dnl" comments in the
> configure.ac scripts, to get autoconf to eat the unnecessary newlines?
In stage1 maybe, but certainly not in stage4.
Jakub
prev parent reply other threads:[~2024-04-17 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 14:01 Christophe Lyon
2024-04-17 14:07 ` Jakub Jelinek
2024-04-17 17:16 ` Eric Gallager
2024-04-17 17:20 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiAE33kEc/IiWNsq@tucnak \
--to=jakub@redhat.com \
--cc=arsen@gcc.gnu.org \
--cc=christophe.lyon@linaro.org \
--cc=dmalcolm@redhat.com \
--cc=egall@gwmail.gwu.edu \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).