From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0FEE33858CDA for ; Wed, 17 Apr 2024 17:20:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0FEE33858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0FEE33858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713374450; cv=none; b=HSHha8ue/jhSrYbcl1DJdqaknE42+ta6nn/04j8M2B5c1j/bZDS5aQmUhu7B3+P8x5jjXQUh+ehy18Mn2wNWqpFaSgudQj6PqQu8VvJ6DNHIi7gVNSM62/04fZQTYTPlE+MSrdk0vkwHSOC81iurAx5T8kR2xIjyLi4/9uc9fSM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713374450; c=relaxed/simple; bh=5pubieQb8J/0IJq064t3/l+wO7aoIs11BJ0Om0kPSnI=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=lbldUORJEVgPF/ZrW24hKj8Rch+szreeuX1KZP5QkYzL6x4UJYAY/NQtc5l/2sahCJgvwGegx+wds6K85mHFDCpfMiOK7YrWl5PH8es71M/rBbx27uHfqLSwbhGiFMt0shxh+W4h6Qqsh93bu9lB0SqvP05N2zs/lUtZB14PL2I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713374448; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=xiuQ+f3Ycgn+i0KlCNA7P51Lgjx0LwqKw4DdpD0PBWg=; b=dZ+BRSaW0IfAtK/Gv09+hvG8aG1uc9IjpKzTUykroayH6DqYRNSjUDVl3sqxDE7YY1FASn bWJvofomEKDaLtU1j4A4Q4aIcRpSPpBZ8YT3/0mKa6dxV9x967Z3bHbwR1RbKG19pZcP+J IKqQ9vrF6Nr7QWuv8OpEmfyFhrklpFo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-124-chKMjWwNPKWuzRDZiIsB-g-1; Wed, 17 Apr 2024 13:20:45 -0400 X-MC-Unique: chKMjWwNPKWuzRDZiIsB-g-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2863618065AE; Wed, 17 Apr 2024 17:20:45 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D99A540F035; Wed, 17 Apr 2024 17:20:44 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 43HHKVnv2680100 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 17 Apr 2024 19:20:32 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 43HHKVMY2680099; Wed, 17 Apr 2024 19:20:31 +0200 Date: Wed, 17 Apr 2024 19:20:31 +0200 From: Jakub Jelinek To: Eric Gallager Cc: Christophe Lyon , gcc-patches@gcc.gnu.org, pinskia@gcc.gnu.org, arsen@gcc.gnu.org, dmalcolm@redhat.com Subject: Re: [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748] Message-ID: Reply-To: Jakub Jelinek References: <20240417140155.2062332-1-christophe.lyon@linaro.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 17, 2024 at 01:16:43PM -0400, Eric Gallager wrote: > > --- a/libcpp/configure > > +++ b/libcpp/configure > > @@ -2670,6 +2670,9 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu > > > > > > > > + > > + > > + > > So, this is kind of a minor style nitpick, but personally, it kind of > bothers me when autotools goes and inserts a bunch of unnecessary > blank newlines in the generated output scripts. Does anyone else think > it'd be worth it to scatter around some of m4's "dnl" comments in the > configure.ac scripts, to get autoconf to eat the unnecessary newlines? In stage1 maybe, but certainly not in stage4. Jakub