From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9B0B73858C50 for ; Tue, 23 Apr 2024 14:24:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B0B73858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9B0B73858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713882252; cv=none; b=NOD/lqez1tWfqCXfcz5Uq/fFZ5gOCXAECWUjv7rfRtpuh48vy6nRvnapIeF8xCl+kGSCbsXiNZeUs10YYE0+Vl+1dz2OhEU4tTdxuS9QVSjURRp9SyCDGSiitqPGo7322+GwviYNDCofXSeZgQlrBMKt7stpO+vmNsgv/UDcaZ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713882252; c=relaxed/simple; bh=ofF2/9tI0LAdHywECo9grfafZaOqnnw1TYggEdP678A=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=a1VF6L2LjeZuYiWPaj/DKkvlf3L8tzMSMoAh40AYJcW5F/Q+vYCXO/ekj9Mo/zwHkuZLdHY9U66GvoO6HmjWq+lBGo+lKo7+sFGbI8GQoFWraCeqQh+7mA4TmRr3vAI7KrCm8+G4YAu/kcbLwnOuRBL2ben0bWu7p2TfovO86nc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713882251; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=YLUV4Kl+zZqCAqPzI/qHveEA/t20eaQhkZBCrAboboM=; b=NDhVPK+B7LZBPM1kq8cWrAA5bsHb1dwXv5p/KSIV5/IZncXzjpz29Jt9NPKsoRFERZ8CId pt3NdIAW8FGClSfPM/VffXkCAahsY//0N29y/fe0qiefGHa7agdCRXQ4lsK+nICKUrwxMO J2Am0iThJA97I087odLWc7DxJO1br5U= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-168-HfQ1LZrYOJO_tAwQjmlBJg-1; Tue, 23 Apr 2024 10:24:06 -0400 X-MC-Unique: HfQ1LZrYOJO_tAwQjmlBJg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A811729AC00D; Tue, 23 Apr 2024 14:24:05 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 67E971C060D0; Tue, 23 Apr 2024 14:24:05 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 43NEO3O71545643 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 16:24:03 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 43NEO3SZ1545092; Tue, 23 Apr 2024 16:24:03 +0200 Date: Tue, 23 Apr 2024 16:24:02 +0200 From: Jakub Jelinek To: Rainer Orth , gcc-patches@gcc.gnu.org, Ian Lance Taylor Subject: Re: [PATCH] libbacktrace: Avoid GNU ld --compress-debug-sections=zlib-gabi Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 23, 2024 at 04:18:49PM +0200, Jakub Jelinek wrote: > Then you have two tests (ctestg and ctesta) doing exactly the same thing, > that can't be right. > I guess it might be fine to use zlib when it is an alias to zlib-gabi, > but zlib-gnu shouldn't be replaced. > > I must say I don't really understand the patch though, because configury > checks > AC_CACHE_CHECK([whether --compress-debug-sections is supported], > [libgo_cv_ld_compress], > [LDFLAGS_hold=$LDFLAGS > LDFLAGS="$LDFLAGS -Wl,--compress-debug-sections=zlib-gnu" > AC_LINK_IFELSE([AC_LANG_PROGRAM(,)], > [libgo_cv_ld_compress=yes], > [libgo_cv_ld_compress=no]) > LDFLAGS=$LDFLAGS_hold]) > AM_CONDITIONAL(HAVE_COMPRESSED_DEBUG, test "$libgo_cv_ld_compress" = yes) > > So, if Solaris doesn't support --compress-debug-sections=zlib-gnu, it > shouldn't be tested. Or does it support zlib-gnu and zlib? What we could do is drop the HAVE_COMPRESSED_DEBUG stuff altogether, and instead similarly how we have HAVE_COMPRESSED_DEBUG_ZSTD have HAVE_COMPRESSED_DEBUG_{ZLIB,ZLIB_GABI,ZLIB_GNU} and for each of those if linker supports them test with that corresponding flag. Jakub