From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path:
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
by sourceware.org (Postfix) with ESMTPS id E68993858C50
for ; Fri, 26 Apr 2024 13:14:25 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E68993858C50
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E68993858C50
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714137267; cv=none;
b=DOTIwXY2TEeyekuU+1tqYxbMRZvkXrfo1yV2HlUIdwV+m2JEbzNsmCD3zOuFecxRc1luMla43bVWkf6bA+0PMr8f2bWAPBxlL02BVfZdNmGA4IBKRojIJjYF2oQz2b9GGsIURH6HHSOutskrh9cfmg6g4tCyFhP91fNTz/mPbp4=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
t=1714137267; c=relaxed/simple;
bh=VX+NwE9wAMFhKMtn9jq3q6hLZsQpcREZUYHLMj9fukY=;
h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=egTsHcbBZATFkdsY5b3ea+G1bwSwdJlrkGQdX30OrHCBHbpmvSc7ajXlU28sw//+8XJ6r66pIi8qe8YiRLUskMjz7jcwowL/OOSXAHGg92rbXbY2hBj5+Ru8H6qvmSbPknj9vPBhm2REajdEXW737ZSQIplmpCLOQQTDbWh8n6Q=
ARC-Authentication-Results: i=1; server2.sourceware.org
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1714137265;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=rKiKXQGglZMiKot4j9yiLz2Q3LLZZ71ehwHYD5770D8=;
b=SIY/pSbd4JqEKtGobLpPkD5nGXFeklxbrHw9UbsjEx8ien27CwTFtPcipPwRsTD41yCi0z
RL3cr5Q9cDcFpYhS3c5IUG14bN+sO3qZoedv/LpQhjQ8qzuAHsYBSn9kLxqMH3n8P2Tij6
CaxS3Uk9S9Xg8QYm5oz08gOtF0lqfxk=
Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com
[209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-624-T_WeE4CxP2uRQBpBPMChPA-1; Fri, 26 Apr 2024 09:14:23 -0400
X-MC-Unique: T_WeE4CxP2uRQBpBPMChPA-1
Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-3c709618a03so2676110b6e.1
for ; Fri, 26 Apr 2024 06:14:23 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1714137262; x=1714742062;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=rKiKXQGglZMiKot4j9yiLz2Q3LLZZ71ehwHYD5770D8=;
b=G7gBVjCY1OiGxR6TQLN+pvAF4xT0KG4ryU792AXLQp/HzQIAHSxNfgoLgdmMHC6luX
CVkEaT+R5LzTiBS6AdWfVEQfvIZElsAViPwDksq/AlwBkSu6nRaT8JOK6y/1QaxrOhXY
/bMAmdlxKEDB8GwNS03wouAY7G0kH82XRjpXExtM6gpJc5PCn5freaf47x0ln4y5dzMz
4nZCZWxs4oNZjTaQU+mhnb51wtevPBsTw/3BBnPdHarCJM87+fCQinYVCyFQMJiGOVzM
UbToqh0mdNK6kGEESs4UZzrTl/eFwWR0YTlGCnZeI94YErHMPw3lUgkxvutGoY2tb5WJ
Nqpg==
X-Gm-Message-State: AOJu0YxViGIrdySVkAAVTOPkoukHG5byeJp/jev5WQNamPMrHLophC8Z
NE2X9E6a+vweXVfzmQU3vIvxW9Kv90/4fh0WGRr5Tk3eGqXrfNaUYJa1oxPVNyYNQJQG4+gl7I5
n9GjnPKpS2UJY+VMyAI4h8mnZpGYDYff9Sjv7F1jfY5FX3JDTq2oYYWI=
X-Received: by 2002:aca:d12:0:b0:3c7:488a:7815 with SMTP id 18-20020aca0d12000000b003c7488a7815mr2800412oin.7.1714137262545;
Fri, 26 Apr 2024 06:14:22 -0700 (PDT)
X-Google-Smtp-Source: AGHT+IFmR5Ju4fsw6Ad02MiKSSoNyEECgx11b/jc7Xcgji1GC+n5T3miJygRWY1h4EyvPkel3D7QGQ==
X-Received: by 2002:aca:d12:0:b0:3c7:488a:7815 with SMTP id 18-20020aca0d12000000b003c7488a7815mr2800393oin.7.1714137262226;
Fri, 26 Apr 2024 06:14:22 -0700 (PDT)
Received: from redhat.com ([2603:7000:9500:34a5::1db4])
by smtp.gmail.com with ESMTPSA id i9-20020a0cf109000000b006a04a3d4fbesm7903327qvl.56.2024.04.26.06.14.21
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 26 Apr 2024 06:14:21 -0700 (PDT)
Date: Fri, 26 Apr 2024 09:14:20 -0400
From: Marek Polacek
To: Alex Coplan
Cc: gcc-patches@gcc.gnu.org, Jason Merrill ,
Joseph Myers , Iain Sandoe
Subject: Re: [PATCH] wwwdocs: Add note to changes.html for
__has_{feature,extension}
Message-ID:
References:
MIME-Version: 1.0
In-Reply-To:
User-Agent: Mutt/2.2.12 (2023-09-09)
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id:
On Fri, Apr 26, 2024 at 11:12:54AM +0100, Alex Coplan wrote:
> On 17/04/2024 11:41, Marek Polacek wrote:
> > On Mon, Apr 15, 2024 at 11:13:27AM +0100, Alex Coplan wrote:
> > > On 04/04/2024 11:00, Alex Coplan wrote:
> > > > Hi,
> > > >
> > > > This adds a note to the GCC 14 release notes mentioning support for
> > > > __has_{feature,extension} (PR60512).
> > > >
> > > > OK to commit?
> > >
> > > Ping. Is this changes.html patch OK? I guess it needs a review from C++
> > > maintainers since it adds to the C++ section.
> > >
> > > >
> > > > Thanks,
> > > > Alex
> > >
> > > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> > > > index 9fd224c1..facead8d 100644
> > > > --- a/htdocs/gcc-14/changes.html
> > > > +++ b/htdocs/gcc-14/changes.html
> > > > @@ -242,6 +242,12 @@ a work-in-progress.
> > > > constinit
and optimized dynamic initialization
> > > >
> > > >
> > > > + The Clang language extensions __has_feature
and
> > > > + __has_extension
have been implemented in GCC. These
> > > > + are available from C, C++, and Objective-C(++).
> >
> > Since the extension is for the whole c-family, not just C++, I think it
> > belongs to a "C family" section. See e.g. .
>
> Thanks, I agree that makes more sense. How about this version instead then:
Thanks, I think you can go ahead with this.
> diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> index fce0fb44..42353955 100644
> --- a/htdocs/gcc-14/changes.html
> +++ b/htdocs/gcc-14/changes.html
> @@ -303,7 +303,15 @@ a work-in-progress.
> Further clean up and improvements to the GNAT code.
>
>
> -
> +C family
> +
> + - The Clang language extensions
__has_feature
and
> + __has_extension
have been implemented in GCC. These
> + are available from C, C++, and Objective-C(++).
> + This is primarily intended to aid the portability of code written
> + against Clang.
> +
> +
>
> C
Marek