From: Marek Polacek <polacek@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jason Merrill <jason@redhat.com>,
Jonathan Wakely <jwakely@redhat.com>, Jan Hubicka <jh@suse.cz>,
gcc-patches@gcc.gnu.org, Richard Biener <rguenther@suse.de>,
Patrick Palka <ppalka@redhat.com>
Subject: Re: [PATCH] c++: Optimize in maybe_clone_body aliases even when not at_eof [PR113208]
Date: Thu, 9 May 2024 14:58:52 -0400 [thread overview]
Message-ID: <Zj0c7Dp9_eQNEXjl@redhat.com> (raw)
In-Reply-To: <Zj0T0KbGM9iIZy/+@tucnak>
On Thu, May 09, 2024 at 08:20:00PM +0200, Jakub Jelinek wrote:
> --- gcc/cp/decl.cc.jj 2024-05-09 10:30:54.804505130 +0200
> +++ gcc/cp/decl.cc 2024-05-09 17:07:08.400110018 +0200
> @@ -19280,6 +19280,14 @@ cxx_comdat_group (tree decl)
> else
> break;
> }
> + /* If a ctor/dtor has already set the comdat group by
> + maybe_clone_body, don't override it. */
> + if (SUPPORTS_ONE_ONLY
> + && TREE_CODE (decl) == FUNCTION_DECL
> + && DECL_CLONED_FUNCTION_P (decl)
> + && SUPPORTS_ONE_ONLY)
> + if (tree comdat = DECL_COMDAT_GROUP (decl))
> + return comdat;
This checks SUPPORTS_ONE_ONLY twice.
Marek
next prev parent reply other threads:[~2024-05-09 18:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 7:42 [PATCH] c++: Retry the aliasing of base/complete cdtor optimization at import_export_decl time [PR113208] Jakub Jelinek
2024-04-17 9:04 ` Jan Hubicka
2024-04-17 12:32 ` Jakub Jelinek
2024-04-17 13:26 ` Jan Hubicka
2024-04-17 14:07 ` Jakub Jelinek
2024-04-17 14:34 ` Jan Hubicka
2024-04-17 14:39 ` Jakub Jelinek
2024-04-22 15:42 ` [PATCH] c++, v2: " Jakub Jelinek
2024-04-23 3:14 ` Jason Merrill
2024-04-23 16:04 ` Jakub Jelinek
2024-04-24 9:16 ` Jonathan Wakely
2024-04-24 16:16 ` [PATCH] c++, v3: " Jakub Jelinek
2024-04-24 22:39 ` Jason Merrill
2024-04-24 22:47 ` Jakub Jelinek
2024-04-25 0:43 ` Jason Merrill
2024-04-25 12:02 ` [PATCH] c++, v4: " Jakub Jelinek
2024-04-25 14:22 ` Jakub Jelinek
2024-04-25 15:30 ` Jason Merrill
2024-04-25 18:42 ` [PATCH] c++, v5: " Jakub Jelinek
2024-05-09 18:20 ` [PATCH] c++: Optimize in maybe_clone_body aliases even when not at_eof [PR113208] Jakub Jelinek
2024-05-09 18:58 ` Marek Polacek [this message]
2024-05-09 19:05 ` Jakub Jelinek
2024-05-10 19:59 ` Jason Merrill
2024-05-13 10:19 ` Jakub Jelinek
2024-05-14 22:20 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj0c7Dp9_eQNEXjl@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=jh@suse.cz \
--cc=jwakely@redhat.com \
--cc=ppalka@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).