From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by sourceware.org (Postfix) with ESMTPS id D628E3846401 for ; Wed, 8 May 2024 11:27:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D628E3846401 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=kitware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kitware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D628E3846401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::72f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715167623; cv=none; b=R/5iXJS5166mocZX+ZGAvqzhInd/M/Uap0pGNJpS3M7iGpL6RI8BtIQ6Vdo8TK839KqOlDhAdSCiFD0LEJH1JIrbAMqTZcL5g2x6OXgUN0c5Rfx8AisLFQ8OuTyWEZ+1Wljhb1EQrAhah7gLTuiMmCiAXhrWnE37vgzpWDodndE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715167623; c=relaxed/simple; bh=U9zKJC7FHgvPxcEolwW2eJshAs7TwUROyiULXm+HLzE=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=JgeHDN8MHOkEus0eGs1eYF9T6st8LvrT+YT3nSVSIaqulk7f13S1ofeoP9wO4xJZMWneJQEuyyifFWeISGITfLkbQ4hIPttcqSpAIFZXsLGWAIW0IrMKoTuILc075o9rATAoV/58Zze6dEIMTyjqeaLc5ncxMsHNcbr7PoTouMg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-792b9790f6bso16536585a.2 for ; Wed, 08 May 2024 04:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kitware.com; s=google; t=1715167621; x=1715772421; darn=gcc.gnu.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sQp/3lkWdTX3Ln4w0vJohzZzmPyaBSxrKPLI+wDgq8o=; b=iAW+vAqrchQaOM0h1Eo2KHtbUNpI4ioE/qvKkrEU95r9jmkDxTdvH9EyGCFWm3NXOf Q3MrY1CbfMOWbR+TVZJrSFORmKbLRvTtAkVQfiXorbz8W15EVjzV7ho5GPbc6/cecVnN /nf57uSH02aDoCTVcRSpJcbHuhPOv0U7xFNOE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715167621; x=1715772421; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sQp/3lkWdTX3Ln4w0vJohzZzmPyaBSxrKPLI+wDgq8o=; b=RDooHYZDmzFlNCyPN1qxjxZtruYFAv6//7qiFX3xRPTPIQP32isRTYFLn/Vl3hUTF/ 8uxZRz4RWcbNsKtAErS7IZCaEeEvaiWBQsBaI4icteQHE/sLnssBv7Ajc/nsw9zg+ThW frAjRzqMBrByNW100D218hIMpc/5TdvpUX3JUZs03CyLLBbZesmF1gXHq8gWeXhph7fo ylTpUhXWeJlZHs/FzCJvYmn1wPCIvU4RocAbtfuCK4TJPq8juU+ABRqBCRL7RStn97zp eki6J49RxWBTIY1r0sZqy57Qi4pfz2udzn9i/Mn7ij1mExWjA/uqSLf5Ad1uTfZNHPYg ixvQ== X-Gm-Message-State: AOJu0YxhLt+GcDkKWP/zoEEC6xDleeDHwtno1mb7qpmn0+OafeCxnrkz nO2CB4Xp8GGj7k8ElFKUui8YUXZbFLx5bX3Dy0XSXO1eP73aYrzDBva2psZDPg== X-Google-Smtp-Source: AGHT+IGsCUh9pLu0eQIGtJfNxK2v59AnwRfjFOVQhxXJ2XDqb0fTnEqxs05wVGZITsLTbOp5KUrSPQ== X-Received: by 2002:a05:620a:17a8:b0:78f:182:5e20 with SMTP id af79cd13be357-792b27bdeb1mr282649585a.7.1715167621191; Wed, 08 May 2024 04:27:01 -0700 (PDT) Received: from localhost (syn-142-105-146-128.res.spectrum.com. [142.105.146.128]) by smtp.gmail.com with ESMTPSA id b27-20020a05620a127b00b00792aa489240sm1447665qkl.30.2024.05.08.04.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 04:27:00 -0700 (PDT) Date: Wed, 8 May 2024 07:26:59 -0400 From: Ben Boeckel To: Joseph Myers Cc: gcc-patches@gcc.gnu.org, Brad King , Roland Illig Subject: Re: [PATCH 3/4] gcc/c-family/c-opts: fix quoting for `-fdeps-format=` error message Message-ID: References: <20240504150446.473575-1-ben.boeckel@kitware.com> <20240504150446.473575-4-ben.boeckel@kitware.com> <81b6a395-fa18-d9cf-3fd9-b21a5e282ac@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <81b6a395-fa18-d9cf-3fd9-b21a5e282ac@redhat.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, May 07, 2024 at 21:15:09 +0000, Joseph Myers wrote: > That can't be right. The GCC %q is a modifier that needs to have an > actual format specifier it modifies (so %qs - which produces the same > output as %<%s%> - but not %q by itself). Yes, I got CI results of failure and noticed that I had prepared the patches on my laptop, but when I investigated, I had done additional work on my desktop concurrently I had not pulled back (it builds GCC in a…reasonable time comparatively) which did have the `%qs` change, but I've not gotten around to running the test suite again (or reporting back here). I have another patch revision in the works. Thanks, --Ben