From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from server28.superhosting.bg (server28.superhosting.bg [217.174.156.11]) by sourceware.org (Postfix) with ESMTPS id BE536384B000 for ; Wed, 8 May 2024 15:57:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE536384B000 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dinux.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dinux.eu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BE536384B000 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.174.156.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715183854; cv=none; b=krGRLpfAPMBCf/jWZwph+qJrEAadtAzRNCFUT+p2+HjibIokOjSNvJpjW3kZmgoAOfevC/w44Htd7AiePPgR2goO5RAomPSkVzJ/sSg69+YafgpGEvWipoYulupOan35dCYh4Y0OC4qE0Rk2dgYfCLrAO6B/boLtb6qRI0XAo3A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715183854; c=relaxed/simple; bh=5/BnR3N5u+rsjb0M2I7qr/+Od8Shc8TOBKqYELFCDYw=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=IRuw/Bwsnmegn9gW9UPvrb2S76YWaZvqv23G58eWf/MpjBI6aMndH6ftFsaxhthotw2omET+RbYf0Wy2bnwSZ0xfAwvMkDxogghBZ5/CoQJy3tDVN0eNCLb6U0r3W+mF80zn1+J27WT6ItubIXnsDZeQmKyBrS50DH1AoFiUkcQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dinux.eu; s=default; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UJhmCEkaVUQ139w2JorN7Lki0Y/EYCcnLYXFA6KIVz0=; b=FdqyTMPuzWgy97ptFMxQpMp7mr gb7z5nEFvKl0qnP8TuiX1hEbjZvSeBt0B8gznGTllTHZ5KCu8UzjVgkhh2uFe1zz9PwNCHIc5xfWL 66/uhB1cqk77dWPyH1zUItDoKpMMbjQ8BN7Z0S+eoVaZlksPT+MUOJCm0hc2xfFPQZh1jBxqX6cID MxmmDgV6bbZw7XUlmcekPrYVjT1ef33xMhtKT9LfpPgJuYISsJeaNKqWGjJUKo6i/nXskBgBRdRDx fU6XuvvZ4E7QSFwb2Zhzc2vglG+91xiNdFZL0G4XfsquKpfKQQoKX/aTDgZT2Yu7B7PUL6SNqwmIp b5bMc1KQ==; Received: from 95-42-20-142.ip.btc-net.bg ([95.42.20.142]:60898 helo=localhost) by server28.superhosting.bg with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1s4jfb-0003YZ-0P; Wed, 08 May 2024 18:57:29 +0300 Date: Wed, 8 May 2024 18:57:24 +0300 From: Dimitar Dimitrov To: =?utf-8?B?6ZmI56GV?= Cc: =?utf-8?B?5LiB5LmQ5Y2O?= , gcc-patches , =?utf-8?B?6ZKf5bGF5ZOy?= , =?utf-8?B?5aSP5pmL?= , vmakarov , "richard.sandiford" Subject: Re: [PATCH 2/4] df: Add DF_LIVE_SUBREG problem Message-ID: References: <20240424100505.1301-1-lehua.ding@rivai.ai> <20240424100505.1301-3-lehua.ding@rivai.ai> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server28.superhosting.bg X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - dinux.eu X-Get-Message-Sender-Via: server28.superhosting.bg: authenticated_id: dimitar@dinux.eu X-Authenticated-Sender: server28.superhosting.bg: dimitar@dinux.eu X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, May 08, 2024 at 11:34:48AM +0800, 陈硕 wrote: > Hi Dimitar > > > I send a patch just now, modifies accordingly > > > some comments: > > > >Nit: Should have two spaces after the dot, per GNU coding style.  I'd suggest > >to run the contrib/check_GNU_style.py script on your patches. > Do you mean "star" by "dot", i.e. "/*----" should be "/* ----"? No, I was referring to the following paragraph from https://www.gnu.org/prep/standards/standards.html : "Please put two spaces after the end of a sentence in your comments, ..." To fix, simply add a second space after the dot, e.g.: - Like DF_LR, but include tracking subreg liveness. Currently used to provide + Like DF_LR, but include tracking subreg liveness. Currently used to provide For reference, here is the output from the style checker: $ git show | ./contrib/check_GNU_style.py - === ERROR type #4: dot, space, space, new sentence (24 error(s)) === ... gcc/df-problems.cc:1350:52: Like DF_LR, but include tracking subreg liveness.█Currently used to provide > > > >These names seem a bit too short for global variables.  Perhaps tuck > >them in a namespace? > > > >Also, since these must remain empty, shouldn't they be declared as const? > > > >namespace df { > >   const bitmap_head empty_bitmap; > >   const subregs_live empty_live; > >} > > > > May be better if "namespace df" contains all DF related code? as a minor modification, I add a prefix "df_" to the variables. > Meanwhile, const seems inapropriate here, since it's returned as normal pointer rather than const pointer in some funtions, > > change to const would break this return value type check, and a const_cast would make the const meanlingless. > > > more details see in the patch Thanks for considering my suggestion. Regards, Dimitar > > > regards > Shuo > >   >