From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A18B53870899 for ; Thu, 13 Jun 2024 12:38:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A18B53870899 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A18B53870899 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718282333; cv=none; b=KH0zQWaPUvIm162wirGjvgwy64tECK6zIS0JYKtJTPHIv4Pk16yT7sOKOZ7TJ70EaqQhK8wJJ54pqV/hZbZ/vojsd0euMK9WXlWM0Ep14hjWrXFCD80IoTphFyL5P6wfJ5yobk+/4IbzojgzkHpiDE96lcNvk0K8ZjeqMseYPwo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718282333; c=relaxed/simple; bh=Ylfa6M6iNSAPnYnD9tyoXJV038Mith+HOOEEj5e3K7E=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=IVms/VFULORDOyL7LmcTFfXPiKr740Gq4+3XH6t4qdBS6F7gXst6x7yn7h2uC94ElQgmbERpWd52ySnCyGFwXGY8nefvsrHCSFh3nyZTJ6g/cgjef/fMipD3MITbWUyBeLFAlibFMVAl0VI0GEA70Eb+rfdvBOIJ/i4cxAnRa6U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718282331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wUEVo30X7RK8SsthqZqYKXzZgFS46lxFkBzfKUfwkBg=; b=EzvFXgcA5EEUVqhXt9lIqDNfNhq//8BSbbbXCBMqaLOT9IstnwoumnZzgd0j/GB9BbDzfS NwKdQlZqjmBcykNv0+XShqm0/VT+gOq3nQeZBXL1Pun23S99Ak6sbuk6RhwmorUykNKuB0 gzrOTO1yMPcHuksx1dAXcylgtWwHEj0= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-189-AOvlwwUFPFeR9cLALrI7Bg-1; Thu, 13 Jun 2024 08:38:48 -0400 X-MC-Unique: AOvlwwUFPFeR9cLALrI7Bg-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EA1BC1956095; Thu, 13 Jun 2024 12:38:47 +0000 (UTC) Received: from localhost (unknown [10.39.192.128]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4007F19560BF; Thu, 13 Jun 2024 12:38:46 +0000 (UTC) Date: Thu, 13 Jun 2024 13:38:45 +0100 From: Jonathan Wakely To: Ken Matsui Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH v26 09/13] libstdc++: Optimize std::add_rvalue_reference compilation performance Message-ID: References: <20240510161405.194750-21-kmatsui@gcc.gnu.org> <20240511090130.248174-1-kmatsui@gcc.gnu.org> <20240511090130.248174-9-kmatsui@gcc.gnu.org> MIME-Version: 1.0 In-Reply-To: <20240511090130.248174-9-kmatsui@gcc.gnu.org> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/05/24 02:01 -0700, Ken Matsui wrote: >This patch optimizes the compilation performance of >std::add_rvalue_reference by dispatching to the new >__add_rvalue_reference built-in trait. > >libstdc++-v3/ChangeLog: > > * include/std/type_traits (add_rvalue_reference): Use > __add_rvalue_reference built-in trait. > (__add_rvalue_reference_helper): Likewise. > >Signed-off-by: Ken Matsui >--- > libstdc++-v3/include/std/type_traits | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > >diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits >index effa3fbcb75..824cad90a25 100644 >--- a/libstdc++-v3/include/std/type_traits >+++ b/libstdc++-v3/include/std/type_traits >@@ -1185,6 +1185,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > }; > > /// @cond undocumented >+#if _GLIBCXX_USE_BUILTIN_TRAIT(__add_rvalue_reference) >+ template >+ struct __add_rvalue_reference_helper >+ { using type = __add_rvalue_reference(_Tp); }; >+#else > template > struct __add_rvalue_reference_helper > { using type = _Tp; }; >@@ -1192,6 +1197,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > template > struct __add_rvalue_reference_helper<_Tp, __void_t<_Tp&&>> > { using type = _Tp&&; }; >+#endif > > template > using __add_rval_ref_t = typename __add_rvalue_reference_helper<_Tp>::type; Same comment as for add_lvalue_reference. >@@ -1748,9 +1754,15 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > #endif > > /// add_rvalue_reference >+#if _GLIBCXX_USE_BUILTIN_TRAIT(__add_rvalue_reference) >+ template >+ struct add_rvalue_reference >+ { using type = __add_rvalue_reference(_Tp); }; >+#else > template > struct add_rvalue_reference > { using type = __add_rval_ref_t<_Tp>; }; >+#endif > > #if __cplusplus > 201103L > /// Alias template for remove_reference >-- >2.44.0 >