From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id E9D08389000C for ; Thu, 20 Jun 2024 14:18:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9D08389000C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E9D08389000C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::429 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718893103; cv=none; b=A9cAz93ABQ0RAGntp1xwAu5byAy0qeE90sDpW6X9GTlp1pV0hwFzutOaQHWKNmoOsWw2cUAfXyHozp/zPwsQNUtUAoN7FlDsVLSkWaGN1bAB+ztRaIZ3QVFwNFYnR04R9VVXQBR4Lji4C8hgu7ulaolob2A9wEGYxDdWDTAwnkk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718893103; c=relaxed/simple; bh=x7prf9JzVKKCsufz4Kk32/oSEiVbx184xuVwXl7imfk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=CXG992mahgQrYx/xKFbGtgfkS4sIClBrpS6n2gHc5rKhEUJI9mpnqS1UbvSiNYuzSLCQOgysdQ1SO6W5nih6LYIpaISbNSWEzPnxJqhKwISoN1DPrglyWOzAuSNI+qsJf977IS+TrQ4PzCvjkEV/0Zl48IfRG5jUWojuq6T5Mjo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-3651ee582cfso366583f8f.2 for ; Thu, 20 Jun 2024 07:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718893091; x=1719497891; darn=gcc.gnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YAhurbxx1Rtte6VwinayyoOv7CeKN0Um5zWnIVY7LqM=; b=dFGQ9JbEBwz1K5ObTX3dJrJsKxBpTXDf983Li/0lx0bF41P12+Ko3miUS4vFCJCgyl K5Bt67iNYx4s5al6BFLmUw84Cb07AbyeAP6CHusrEHtfzvvHEQTVH63OIXAESJwgyPsM 7oEq4JG9z+a20plLLwWFimkfE+bA/fg3DMcr+yc7HCchGnGgzG+QjpP2iop17Jntomgs kv+9amPN8TlXr/Lm+QAC43EslntEBaRp31depbShevNGjkzvrog3TP+cjjM5ckG7aK0j Mh92O4LKOs8daz/oec/Sktk0PY+Xo07A2Ot02bGgsgUdF5hbKQWeYSHpQHhd7z3c1yjw FsLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718893091; x=1719497891; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YAhurbxx1Rtte6VwinayyoOv7CeKN0Um5zWnIVY7LqM=; b=UmsdakXpZ0wJufnP/RsPgi5UhV4e1O8GxsXj/iH6kP1XFPEzxAmNW0NbnBlMGQbkfh xELP82QtZ7uckHxtUiB5oEwTrU3tjzugXPRTWutWRV7+YHiOjlGYTnRdh6SuvnIZRD/S L66zb9ztV+IEYz0itgFBmKxPj/pJb2geMrw0+1b7Iw3mgWIp/pqiYbgy8fuLa3vsHgVI nLoiZG1QY1phxSGJjcFUhc8VzMUlCmk99ph56OczEZKcgDCzLGb+XXiBmA3Ymr+b429I 1DddIYgGdizSslOef91jO57xWe3YCgIkL3juKKnaM/Ann2Q9Q+7LF2x8C+8JMtRHvQ5g sVZg== X-Gm-Message-State: AOJu0YwnlcJjsYs9iozf7/GwTBvHW8eAgvbxjgAJ3yGZJJtIu9b1TZn+ 1GB8tFXDjY52YBHb6sy+9Mfc0S8Ov1p9WvSyR/l7Pyi5dPuERgN1 X-Google-Smtp-Source: AGHT+IGzeOJUpD49T+Qw0JcQbTmaztUH5gThtPxcVe0fn8m2C62FGnuzpV2IPiMy4cjGXCFnrYZxTg== X-Received: by 2002:adf:a1c3:0:b0:35f:22e3:1e0c with SMTP id ffacd0b85a97d-36319d686cbmr3732051f8f.69.1718893091232; Thu, 20 Jun 2024 07:18:11 -0700 (PDT) Received: from localhost (cpc1-brnt4-2-0-cust862.4-2.cable.virginm.net. [86.9.131.95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-364999e27c4sm2111995f8f.57.2024.06.20.07.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 07:18:10 -0700 (PDT) Date: Thu, 20 Jun 2024 15:18:09 +0100 From: Stafford Horne To: "Kewen.Lin" Cc: gcc-patches@gcc.gnu.org, Jeff Law , Jeff Law Subject: Re: PING^1 [PATCH 29/52] or1k: Remove macros {FLOAT,DOUBLE,LONG_DOUBLE}_TYPE_SIZE Message-ID: References: <791d1d140fac173888b7645b716f2f2cc6a854ee.1717134752.git.linkw@linux.ibm.com> <6ba5eca3-0825-69e8-eac5-bc2b98587d93@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ba5eca3-0825-69e8-eac5-bc2b98587d93@linux.ibm.com> X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jun 13, 2024 at 03:16:44PM +0800, Kewen.Lin wrote: > Hi, > > Gentle ping: > > https://gcc.gnu.org/pipermail/gcc-patches/2024-June/653363.html Hello since this is a treewide update I am not the best person to approve just this single patch. But it does look good to me as this is what you are doing to all other architectures. -Stafford > BR, > Kewen > > on 2024/6/3 11:01, Kewen Lin wrote: > > This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE > > defines in or1k port. > > > > gcc/ChangeLog: > > > > * config/or1k/or1k.h (FLOAT_TYPE_SIZE): Remove. > > (DOUBLE_TYPE_SIZE): Likewise. > > (LONG_DOUBLE_TYPE_SIZE): Likewise. > > --- > > gcc/config/or1k/or1k.h | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/gcc/config/or1k/or1k.h b/gcc/config/or1k/or1k.h > > index 0ff73df33e7..a55509f9f32 100644 > > --- a/gcc/config/or1k/or1k.h > > +++ b/gcc/config/or1k/or1k.h > > @@ -67,9 +67,6 @@ > > #define SHORT_TYPE_SIZE 16 > > #define LONG_TYPE_SIZE 32 > > #define LONG_LONG_TYPE_SIZE 64 > > -#define FLOAT_TYPE_SIZE 32 > > -#define DOUBLE_TYPE_SIZE 64 > > -#define LONG_DOUBLE_TYPE_SIZE 64 > > #define WCHAR_TYPE_SIZE 32 > > > > #undef SIZE_TYPE >