From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20601.outbound.protection.outlook.com [IPv6:2a01:111:f403:2608::601]) by sourceware.org (Postfix) with ESMTPS id C4E2F3858C50 for ; Tue, 2 Jul 2024 09:46:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C4E2F3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C4E2F3858C50 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:2608::601 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1719913602; cv=pass; b=jwNtH+dIGTwCmfVoBn9WxUGQblzvUhB3gYq3jXEohtUQ65f79H8RMAfd26c86w9ndrIqBTFwSVx7vG/Xjrs20wf/E1BFbJtgFfesg7Bj0/vQYt6TfXiLhlwARimK+ah+ELaOKlftqtwU4dfyP5k2fs0Z/pHsvyF5GzF+hxZDcIg= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1719913602; c=relaxed/simple; bh=FXgwFVqKzg3Mflh50zgf3TNm07Hw/laKFjFMfmb1ClE=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=Wg7HN+bMOwd9CAlcQaqyEMVnf5XFpBhtaQnMipZGoAQrY+Vcyotcv1HVfzzEtHW4fmDyCmlif+YUyXK4GyJuvB7Sdp/UhAojxx30pcbQAIz7bENpry8gzWzQUquAnYJE0K98EhLbU5Ej3g4myq/jcMGVfEl4JwbE+z5YqoSvZ1g= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=btIZkrZf0vkTOZbJqO5PpSBlG24oWRdoM/fPhbxFQCieenVBlGvVTXplT4bYGa1cqwCPupIkTQ1AnK55/iURybhJRFMtd+tKlwuNgAFYAS8DG3PX2qPpzdN7bxs/XsyXKxb3txvSQc/TgRAvITiHv1dfop6S3tKvNyrjKIKsN15J2d9gfjVNJT7Fe8miKvrf53EtchajqhEB5YzPKd8XdhAW7XQ1nofEipZwl0MkMYzy7Xz3H8ONiTXYRJpJtA2RuPB8qMdIxF5qGQLOxHjfroNJJXXfxSOFocoGfULktvob40JZ5CIIld3cJR4fcgYWytycFy4aZz7SEejSJOLsIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RCefcdGdy5SWgZMFNQo9pe1h4tUTy55Dd4vHVZJGaTo=; b=EWId/CGleiCkApKMoe0hRpbk5FA82B8EqqD6zHv/HV405Rrx7nQKxbjgaty1xNoRdjT1s0eDbanCN8c1CAZKCoUQVJEoBB686JH6gs8OXprJ8tjMp8lxK0uPMYmUZdxyziqJuRM35HoCpAWWiYjfrWHM4ceV/rDn7GkBzGWN7dLijBbAAVWTS0BoELG0s3GPtXDJdlhBvJ5wcKxw230EoM11EELzI+oBoezxfG5aCq5Sd/mlhf2W1WHMUFFl4VGynJPpchqty82glcGdV0S6215NcuY5XqBHuG3kOsQWdXf4lNU1v5KQQnoJz/WG+PIeJnenPo6uX1wA2o2qDmzf/g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RCefcdGdy5SWgZMFNQo9pe1h4tUTy55Dd4vHVZJGaTo=; b=ljL12FsCZLvKq9d9tcyoJmA5wZbLDpbXcOSI8aMqnG0cc5hjzSQbSKgc7+XId5s59Rzds8Bw6UdxPxyY2egUOk7EwWHkTg0hGDfJk69zhP0pQoe3JVSljnHlJAC5QKdMA3DGOcQEo26PYqNMKMkLJnYzHrW6fo6kebn7CeipoEk= Received: from DUZPR01CA0295.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::11) by AS2PR08MB10154.eurprd08.prod.outlook.com (2603:10a6:20b:62e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.34; Tue, 2 Jul 2024 09:46:34 +0000 Received: from DU2PEPF00028CFD.eurprd03.prod.outlook.com (2603:10a6:10:4b7:cafe::85) by DUZPR01CA0295.outlook.office365.com (2603:10a6:10:4b7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.34 via Frontend Transport; Tue, 2 Jul 2024 09:46:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU2PEPF00028CFD.mail.protection.outlook.com (10.167.242.181) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7741.18 via Frontend Transport; Tue, 2 Jul 2024 09:46:34 +0000 Received: ("Tessian outbound 078479ff1462:v357"); Tue, 02 Jul 2024 09:46:33 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3ce2654e9196a358 X-CR-MTA-TID: 64aa7808 Received: from 332265b7b852.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 30EF8D9A-AB22-4D98-B936-9BE0711F99DE.1; Tue, 02 Jul 2024 09:46:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 332265b7b852.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 02 Jul 2024 09:46:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WZjhGelcJU8HRCBQyJi/QfXOY6gaLXF04vvHUzoANef6WY1gESsc3wdL7Y60WPNyjyiiXi/MJj0Bk/Hq/8+iSiz4nCsHVrnH5tuWgmomkxcn6Hwa3RPewCRc+w8he0BDtpLahl7fLSA5eKpQHJTNGp1p4V0IV82EuMOAtgWpv8TZRP8iivwvbdkMUloH+cuF2yXEQR+Hw7sG6eR+c88k7gQ4eIFHG5Nu2uBaPyBz8cDzyMbH9CQdcthXowFhYMi1qoFE5ziy9gmxQhaicJuZjO1Zm6RSVldkvA1fjIuDzSRhrTNT6W9H7/QXJeJ1imet3Mr8TK+2TMDLbeizVZmWMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RCefcdGdy5SWgZMFNQo9pe1h4tUTy55Dd4vHVZJGaTo=; b=odecP7bmWPqhmR+O85WpBHWluuGN32xXfdizCxLkbJDn2C8HfAUPTTcNAjBDNyyIqsx3AdV85SBiwZPEWMLXGc3NfnLErCJrrTTOh8jPYIClqzrCo3X4etlzXMUNg8wHmK/vjIvvI+e1M/cFJK2h71ibJDKVhluNyU8uPuEYpYCLN71S6iQLOgLfHVqvm8f4tRWX4sUAImUOQokQsR1SPGCJspxIqPF33sD3OZRbQH85e9sqoNYaFpJm9JFB2D2weDFX5jCxWT0Fr5UfHUr8CDGFqkfxyyo8VVGALFHrofffYSA5Ykkyuj6tqKGmf2OgVSiQNY8JE08QrUfpg+ZWGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RCefcdGdy5SWgZMFNQo9pe1h4tUTy55Dd4vHVZJGaTo=; b=ljL12FsCZLvKq9d9tcyoJmA5wZbLDpbXcOSI8aMqnG0cc5hjzSQbSKgc7+XId5s59Rzds8Bw6UdxPxyY2egUOk7EwWHkTg0hGDfJk69zhP0pQoe3JVSljnHlJAC5QKdMA3DGOcQEo26PYqNMKMkLJnYzHrW6fo6kebn7CeipoEk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PAWPR08MB8958.eurprd08.prod.outlook.com (2603:10a6:102:33e::15) by DB9PR08MB7817.eurprd08.prod.outlook.com (2603:10a6:10:399::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.32; Tue, 2 Jul 2024 09:46:25 +0000 Received: from PAWPR08MB8958.eurprd08.prod.outlook.com ([fe80::9f32:dc2a:5bec:aeac]) by PAWPR08MB8958.eurprd08.prod.outlook.com ([fe80::9f32:dc2a:5bec:aeac%5]) with mapi id 15.20.7719.029; Tue, 2 Jul 2024 09:46:25 +0000 Date: Tue, 2 Jul 2024 10:46:22 +0100 From: Alex Coplan To: Richard Biener Cc: Tamar Christina , "gcc-patches@gcc.gnu.org" , nd , "jlaw@ventanamicro.com" Subject: Re: [PATCH 1/2]middle-end: fix wide_int_constant_multiple_p when VAL and DIV are 0. [PR114932] Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0593.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::8) To PAWPR08MB8958.eurprd08.prod.outlook.com (2603:10a6:102:33e::15) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAWPR08MB8958:EE_|DB9PR08MB7817:EE_|DU2PEPF00028CFD:EE_|AS2PR08MB10154:EE_ X-MS-Office365-Filtering-Correlation-Id: fbf8dc82-740e-4964-0766-08dc9a7bdbf2 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?MUlVUzhVL1RENlZWREhHM0JDTFJPaDg0UDh1cWhiR2FMblBrWVVSbTB2aTJY?= =?utf-8?B?ZmtHSWNSUklvcE8wYWhrc3RkNytqM1UyL0FzZjRTeTVOZFQySU9mbEhCZzF4?= =?utf-8?B?bkZrMFlrQ2c3aUlkVVdhYnEyZXE1anhmbzN0SGxSazUzc09yclltVFg4Zjk2?= =?utf-8?B?KzdDcE9BSlJ5T1I2WU9qZjhuWXJaZkRDZVNRZERpRjR5RVdrV0V4eDZLdWVJ?= =?utf-8?B?aVBjMENsYTEzMFBORTN5aXdSdmZTNTFQZjlOcjRkMElGM2t3YmJITTFqNzFG?= =?utf-8?B?WHZWOTZQNVFETFpROU42a3hyeis2dEdwbk82Z1hnd0I4ZDczOE1XczhiYzA0?= =?utf-8?B?WDBEeTEycElaY3BJVjdiRU50a205SVlJQjBoYlNmb05QcGhFM0lWMU5YZm5z?= =?utf-8?B?N2JkcDFsUEgrckx4R2tzampEUWR4bTl0ckJ4NkFZdG9zZ2prN09CS0RuNUtI?= =?utf-8?B?cUdtNzdIQytCYmhyMURRM3ZKYngyemV3blRQVi9qZmdIcGV0RkFkY1dodU4z?= =?utf-8?B?dzVmSVhtVGU4Z28rbEd3eFp4T2gwYUhISkx1NER2VS9wUDk1dEl5TWt5NGJO?= =?utf-8?B?Q3dwZnMxNHgrRkNEQmdlODVIWk9iZjJpZk9mQVhoY2hYUk9JYTNaMVcrOVIw?= =?utf-8?B?MWgxbk9MNzV4bE9jMFY2ajRDZGJhOXNiQlZBbjVHYVVGK3VwbXRPUUpqbzA1?= =?utf-8?B?eHFKaHdFaFNaejdFekZFZFpNOWZ2YjZWWmJVQXo0TmhnTzluZDY4RExpdnV0?= =?utf-8?B?a2sxdWZ2VVdiU2daZGxSNU1VVlJnbm8zdHppekVzQzF5Rm4yOGlHcXcxMEh4?= =?utf-8?B?cXE3K3lPak43T3B0YnNhYVhMc3FDTmV3NldTN0N4dlVCQjZOTjNpMWQ5SlFN?= =?utf-8?B?OUVLeWtDNjBGaTU0cUFiYlRsREdjVXh5d29udTFUVkFaRXc1UEQ4YXhxbXFk?= =?utf-8?B?cW1USXhvSmpjSm4rMUF1bEg1ZkNwZVVZSTY1RHArMnRia3RYNHdyK2FvTjhr?= =?utf-8?B?OGg2d3Z1N3c3UmtHTTJHa216cmtENVdrSFc4TTlHUUlubjVHdmhVWFhvdzFC?= =?utf-8?B?czViL0Rnd1ZLVjMra3BaOXFKazdJTjJyQ0dvMFVEbGl1S1lPRTRHNThGdlQy?= =?utf-8?B?L2dMV3ZYWmkrV3REZ2pFZjhtRDVxWEJjSmZma0NiMlRROVJRQldQY29lYXNs?= =?utf-8?B?b2pMWHdZelA2SzZhUTIvV29BYUIyQm54dFVXS2pxRW5RbzFXWHc0SXFpMzZT?= =?utf-8?B?cE1SUjd0T2hXaGRheHRobjF1SVFOTHpwZXl6R2kzZVdlVDEwR3Nxc3BEYlFJ?= =?utf-8?B?QmpEajVCRzNaMDFlMFczbmt2UnVISTZ2cHZIVzVIblEvN2FxaVp4cFhwc3Aw?= =?utf-8?B?cVlUZmU5SGpxMFM3U3hxbVNnd29lL21XWjJBWS9hWnpkMVhNYnNJOHVQY3pC?= =?utf-8?B?UkxOZ2dPQkx5eWVYQkd2Vitkdk5vS0ZoUUdaamFzN25EZ1pIOFVhNXJVM3Ny?= =?utf-8?B?d3JDS0VvMm04c2FDZVJwaTVPcDVvYXU0Mzc2VlQxRlVleExyTnRpZFhQbUlB?= =?utf-8?B?dXRsdkZLa25yY1dXWDFXZlFrV0duNWZDZFl1am1hcjlEZkd0TW5XNG45dE9u?= =?utf-8?B?MlVVYXdDNXljYVNMTkp2Z295amQxN0kydEtrZkxFR01tRW1keGhManhRQnZE?= =?utf-8?B?Q0oxS3NPbGdBMXhHSnpENytUN0pzclFWYzlLYW9GRlAzcm9mZ2hjYnhZeXJF?= =?utf-8?B?SmVVNkZtMUJLSStJNDVBMkVVVDhTbExEYjhBL0dzeFYvcFBQSUtjUlo5QW9R?= =?utf-8?B?WDBrYnZtN3oraXNJSnJzUT09?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8958.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7817 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF00028CFD.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0dee239b-8b2f-45fe-2051-08dc9a7bd6a0 X-Microsoft-Antispam: BCL:0;ARA:13230040|35042699022|376014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dWNCdWYzUXNUaXprSzFsWFNzYXp4dVExelAxeHRBL2RWOXhtTlE2VVBCbGhy?= =?utf-8?B?REZPbVFweXpMUThDeFRNelZzMFlCNE9sQlFyb1p1WTdBM1d6OVZwSnJuYUZr?= =?utf-8?B?TVJmYnFTR3lFWEM5MFE3eXpOU0I1REYvYlF4UVpDNHBNblJuekZHd0lKb0E3?= =?utf-8?B?TFZXVkFLNlN6U0FhS2NPWUtMSmZkOWlQbktRWDNBS0dRMDJxdUxLbkE2T3NK?= =?utf-8?B?QXlLSHlUWUh2WmtNTkpobTgwb3JQUFM0UjNkckcwcEIxUEdMZk44b3RHS2pV?= =?utf-8?B?eHZFdFpXR0NzOVJhY25hSHRxb2dDMGRsQUY5RW9lNElpNjM0bWg3WlZUN0lt?= =?utf-8?B?ZEtFRUJCc1ZjcE9taGQzUEVnRVVwbWtOalN5aUlMTi9zQ3NoZmxwcThjQ1hY?= =?utf-8?B?eW1SK0t5RmQ0M0RRV0ZBRzNXMEFhekNjRURIMVNKblIya0pEOXl3NnkzL1lm?= =?utf-8?B?TFlqcEpldlRpb2h5UVlFelExS0pTVE92blpuS1B1WmdTSVhMKzZhK3Z1VFlq?= =?utf-8?B?NUhIbkNzRmVFMTVaeE51ZmZnR29EVTVXU2prWlBsOWxTUmptakNkV0N1WTRN?= =?utf-8?B?eVYwV2RsUmJ5T1dNamhZN1d1Wmo2OFJGWm9ZZ1hqQy80bmRrUHozZjF3d2Jm?= =?utf-8?B?NWNGOEd0a3hRTi8yZ1p6L3p0N3lGOFc1NEVvL3ZKZmpOU0ZCdnZ0ZWYwOUtq?= =?utf-8?B?WVovMkNPSG9pallwV0FiYW5hSWdlTlRoaVlqS2oyajhMU2lKNEhCbWZUQUNE?= =?utf-8?B?b0J4bXFWdFZndVNLeHdIbUNpY2FEcncwQW4vYnBTTy9XUDRXNnM0dGxabHpY?= =?utf-8?B?WVNGM0EyTXU5ZVQ5d1JUdlZ5N3hKaTdTM3pERlRYMTdMbHpUcnFQaTJOL1d1?= =?utf-8?B?elBCT3VDQWdYVlpWWFl6dkM2WG9VcVN1aU9xcXhDVVVEWmxOdHdYV3M0eVds?= =?utf-8?B?M3kyN01tTnphVHdHVm9kU01mQVBhOHVlN1VJaVpTK3pSR3lBWTBWN1FoNHU3?= =?utf-8?B?REtkSms0R0FHVVpGdGtwejQyMU9GUktXc1JSMm5wcVhGZGMzemhRWEpEbHN1?= =?utf-8?B?VWZROXJnNFVqNVdHbklvb2dqcXlXd1FYVnJzdzJ5dlhLRTZnbkcwQTlwQkYz?= =?utf-8?B?bFU4SnViTFo4cXhHN3VHZWFGSnRBeG5hWk02eU1zcGFrSHZYQVY3bThNbk9z?= =?utf-8?B?MUNXSkJrZzRtYUV1THdhSUg1cGMrcFo2YnU4SUt2V3BiYnlnOWxIL2trSThi?= =?utf-8?B?SHh6T1gxKytHL3hZOHRLVFdoMndUWjRLMXZ1cVpyTWFVTklFdFlJTVpFZVdS?= =?utf-8?B?ekZ4cWtpaVI4dHRVdUdZRkN3Tm0xcDlha1htcy9TdExiS1dLV0NCOEZwd3dT?= =?utf-8?B?Z2JpR2VpcUhuOTZ6alpHZU9pYXZkUndlRUZOS2NFQndZREtldXA4NXJCNWRQ?= =?utf-8?B?YWJJcXNqVlZGc0wyYlVqNGRocFo4ZURZMkRCK2JGRlltMlFqMXpMTDRabzN6?= =?utf-8?B?NDJ5L21aNGdLUnNNWXc5anRPSHpCNUR3NmRQR2FqbXY5WE9ONHMyZVhlcWF5?= =?utf-8?B?NEs2eFp4Uzk3SDliTEoxQkxtZjJGM2gyK25sYmdQMlRKSWoyUlNUTTFhZ1dI?= =?utf-8?B?RkdTVjc3YkFodDdwc3RocXJWa2szWDJmdkNBS2FFWmt5c0xVR0NpNGNqTlQx?= =?utf-8?B?bzI4NHo1bHJXV0tDNmhjSlpxdjJqTmErM05ROTVvMitjeDBnWFRudHNOK0hO?= =?utf-8?B?a1JwMW9zWDI4TzJ4T0RYbkliV2tJTTY0Q3N2L3dQRlpBNHc5S05kd1NMT21W?= =?utf-8?B?dzVUM3VLS0hHenNURG4yYmgxQ3NPN0tGL3EvZGo1ZG9ueWxKWFBTNXBYWXlh?= =?utf-8?B?MTlGOUZwemo5em10T0ZMNjZsKzBDaDl1d0JVM0JHdTV1czV1K0hvYU04YlhM?= =?utf-8?Q?eJguKTyuW89y5YZ6LvTxw5LN+02eyLFI?= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230040)(35042699022)(376014)(1800799024)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2024 09:46:34.1338 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fbf8dc82-740e-4964-0766-08dc9a7bdbf2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028CFD.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10154 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,GIT_PATCH_0,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02/07/2024 10:01, Richard Biener wrote: > On Mon, 1 Jul 2024, Tamar Christina wrote: > > > > -----Original Message----- > > > From: Tamar Christina > > > Sent: Monday, July 1, 2024 9:14 PM > > > To: gcc-patches@gcc.gnu.org > > > Cc: nd ; rguenther@suse.de; jlaw@ventanamicro.com > > > Subject: [PATCH 1/2]middle-end: fix wide_int_constant_multiple_p when VAL and > > > DIV are 0. [PR114932] > > > > > > Hi All, > > > > > > wide_int_constant_multiple_p tries to check if for two tree expressions a and b > > > that there is a multiplier which makes a == b * c. > > > > > > This code however seems to think that there's no c where a=0 and b=0 are equal > > > which is of course wrong. > > > > > > This fixes it and also fixes the comment. > > > > > > Bootstrapped Regtested on aarch64-none-linux-gnu, > > > x86_64-pc-linux-gnu -m32, -m64 and no issues. > > > > > > Ok for master? > > > > > > Thanks, > > > Tamar > > > > > > gcc/ChangeLog: > > > > > > PR tree-optimization/114932 > > > * tree-affine.cc (wide_int_constant_multiple_p): Support 0 and 0 being > > > multiples. > > > > > > --- > > > diff --git a/gcc/tree-affine.cc b/gcc/tree-affine.cc > > > index > > > d6309c4390362b680f0aa97a41fac3281ade66fd..bfea0fe826a6affa0ace154e3ca > > > 38c9ef632fcba 100644 > > > --- a/gcc/tree-affine.cc > > > +++ b/gcc/tree-affine.cc > > > @@ -880,11 +880,10 @@ free_affine_expand_cache (hash_map > > name_expansion *> **cache) > > > *cache = NULL; > > > } > > > > > > -/* If VAL != CST * DIV for any constant CST, returns false. > > > - Otherwise, if *MULT_SET is true, additionally compares CST and MULT, > > > - and if they are different, returns false. Finally, if neither of these > > > - two cases occur, true is returned, and CST is stored to MULT and MULT_SET > > > - is set to true. */ > > > +/* If VAL == CST * DIV for any constant CST, returns true. > > > + and if *MULT_SET is true, additionally compares CST and MULT > > > + and if they are different, returns false. If true is returned, CST is > > > + stored to MULT and MULT_SET is set to true. */ > > > > > > static bool > > > wide_int_constant_multiple_p (const poly_widest_int &val, > > > @@ -895,6 +894,12 @@ wide_int_constant_multiple_p (const poly_widest_int > > > &val, > > > > > > if (known_eq (val, 0)) > > > { > > > + if (maybe_eq (div, 0)) > > > + { > > > + *mult = 1; > > > + return true; > > > + } > > > + > > > > Note, I also tested known_eq here, and also no regression on what I can test. > > I picked maybe_eq since that's what the lines after this one tests. > > I think the maybe_eq (div, 0) is because otherwise multiple_p might > crash? I'm not sure if there's a difference between > maybe_eq (x, 0) and known_eq (x, 0) though - how does a maybe_eq > POLY_INT look like that's not known_eq? Take: A = POLY_INT_CST [16,0] B = POLY_INT_CST [8,8] then these represent polynomials: A = 16 B = 8 + 8x where x is only known at runtime. We have maybe_eq (A,B) since there is a value of x (= 1) which makes these equal at runtime, but clearly !known_eq (A,B) (take x = 0, for example). That is my understanding at least, hopefully that makes sense. Thanks, Alex > > > I'm not sure I fully understand why one tests known and the other maybe. It seems to me > > that both should test known. But I tested both so which ever one is felt to be more correct > > I can commit If ok. > > > > Thanks, > > Tamar > > > > > if (*mult_set && maybe_ne (*mult, 0)) > > > return false; > > > *mult_set = true; > > > > > > > > > > > > > > > -- > > > > -- > Richard Biener > SUSE Software Solutions Germany GmbH, > Frankenstrasse 146, 90461 Nuernberg, Germany; > GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)