From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tburnus@baylibre.com>
Cc: Andre Vehreschild <vehre@gmx.de>, Tobias Burnus <burnus@net-b.de>,
gcc-patches <gcc-patches@gcc.gnu.org>,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Subject: Re: [Patch, v2] OpenMP/Fortran: Fix handling of 'declare target' with 'link' clause [PR11555]
Date: Mon, 29 Jul 2024 10:22:50 +0200 [thread overview]
Message-ID: <ZqdRWrEu7l2GIKFl@tucnak> (raw)
In-Reply-To: <8f63369b-2254-41f2-aaab-528eee3cd31c@baylibre.com>
On Mon, Jul 29, 2024 at 09:53:47AM +0200, Tobias Burnus wrote:
> Hi Andre, hi all,
>
> Andre Vehreschild wrote:
> > yes, I could have looked harder 🙂
>
> I wrote ;-) on purpose as this feature is somewhat hidden and writing 'dg-do
> compile' doesn't harm.
I think an explicit dg-do is better, otherwise one has to just guess
for some tests what has been actually intentional (see the recent
torture tests which were just compile time but written most likely to be
runtime; I've changed a few, Sam changed more).
Also, the subject line has too few digits in the PR number I think (9
missing?).
Otherwise LGTM.
Jakub
next prev parent reply other threads:[~2024-07-29 8:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 13:06 [Patch] " Tobias Burnus
2024-07-26 18:34 ` [Patch, v2] " Tobias Burnus
2024-07-29 7:09 ` Andre Vehreschild
2024-07-29 7:29 ` Tobias Burnus
2024-07-29 7:39 ` Andre Vehreschild
2024-07-29 7:53 ` Tobias Burnus
2024-07-29 8:22 ` Jakub Jelinek [this message]
2024-07-30 8:37 ` [committed] gfortran.dg/compiler-directive_2.f: Update dg-error (was: [Patch, v2] OpenMP/Fortran: Fix handling of 'declare target' with 'link' clause [PR115559]) Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqdRWrEu7l2GIKFl@tucnak \
--to=jakub@redhat.com \
--cc=burnus@net-b.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tburnus@baylibre.com \
--cc=vehre@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).