From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 50665385E830 for ; Mon, 29 Jul 2024 12:00:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 50665385E830 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 50665385E830 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722254441; cv=none; b=twcbnG56+fU0LaEwtR8oSfVzr2BfM1M8VIqzpxpCdGNfPi8LG6Ut8tEgPgy4t0lFl0o0ff12RkOrVII01B/B8UNbcaaciY4ejk/TsEe1357tBOewtSvfjHCrmwXFgV8MFbefZkfJk1Gi8co3sy297UJrptq2kigzYYvUQqx911Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722254441; c=relaxed/simple; bh=P2rt6vdsOKzTgnsFOG61V1BL7EAX7gznyEv5tvuOPzs=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=JFrBz1ZL6tb9YR9mV45GnkERzwwt19ye+pwhdkHUHMxLIcaPDOombSpYWNjnVc4TTik+mCWXoMC+mfpNMyIhPM9ziDhhfJhuLVJQV87O0sq45QBpaiXR1cKkuytow9eXmUfAKgWA4FJ4aDPGkbpQDNHltg7CA3eSr/LQOAFKpxA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722254437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oEW3ZS5+20ixlzj82bi/4LLuJrR/63z5HgYdzNdrNBY=; b=SUkrEUgcAqIEV3o+XKkd8/i16VdF//w3g863Iq13PzoHMS/HJIE3a0NAGx7/rhYagwOn6E cNt7UkAisKMbdxLeoT4WGJ1mdkXl9hPwvN48wPWpZ8tpRuxhxKM/ZKbwgR1Hsn75vzoTsf fVOjdR+ZGOrO2W9gMYSDdFqDpLh00W0= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-7WgR6cfIOyO-aRZHwW6W1A-1; Mon, 29 Jul 2024 08:00:30 -0400 X-MC-Unique: 7WgR6cfIOyO-aRZHwW6W1A-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 181181955BF9; Mon, 29 Jul 2024 12:00:29 +0000 (UTC) Received: from localhost (unknown [10.42.28.14]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7A6641955D42; Mon, 29 Jul 2024 12:00:27 +0000 (UTC) Date: Mon, 29 Jul 2024 13:00:25 +0100 From: Jonathan Wakely To: gcc-patches@gcc.gnu.org Cc: dmalcolm@sourceware.org Subject: Re: [PATCH] doc: Improve punctuation and grammar in -fdiagnostics-format docs Message-ID: References: <20240315130309.2915229-1-jwakely@redhat.com> MIME-Version: 1.0 In-Reply-To: <20240315130309.2915229-1-jwakely@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15/03/24 13:02 +0000, Jonathan Wakely wrote: >OK for trunk? Ping >-- >8 -- > >The hyphen can be misunderstood to mean "emitted to -" i.e. stdout. >Refer to both forms by name, rather than using "the former" for one and >referring to the other by name. > >gcc/ChangeLog: > > * doc/invoke.texi (Diagnostic Message Formatting Options): > Replace hyphen with a new sentence. Replace "the former" with > the actual value. >--- > gcc/doc/invoke.texi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi >index 85c938d4a14..d850b5fcdcc 100644 >--- a/gcc/doc/invoke.texi >+++ b/gcc/doc/invoke.texi >@@ -5737,8 +5737,9 @@ named @file{@var{source}.sarif}, respectively. > > The @samp{json} format is a synonym for @samp{json-stderr}. > The @samp{json-stderr} and @samp{json-file} formats are identical, apart from >-where the JSON is emitted to - with the former, the JSON is emitted to stderr, >-whereas with @samp{json-file} it is written to @file{@var{source}.gcc.json}. >+where the JSON is emitted to. With @samp{json-stderr}, the JSON is emitted >+to stderr, whereas with @samp{json-file} it is written to >+@file{@var{source}.gcc.json}. > > The emitted JSON consists of a top-level JSON array containing JSON objects > representing the diagnostics.