From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 6124D3858CD9 for ; Fri, 9 Aug 2024 16:42:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6124D3858CD9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6124D3858CD9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723221747; cv=none; b=vBBAxWbKcJGGOd+dNFMOJtODASqLDumrfL3qJyjLWYaavr5pqQYNKhyhXVz8SNjRJl8EIzq8z34OOa17TkhH0YGZZCWNj78lzPMFwrZKA80M8iMBzYEJPcwk3PJxX2AMWB9+/CfzmWnxtOvMCilKFYBDKmz8ArvssEvLm6EfeIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723221747; c=relaxed/simple; bh=n0N1el4G6VYEUULz+HmM1hdjyEWr61uEgXzjo1zlcYI=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=fFv878e2mg63QGMGT3bFtkv1We1z6DJWXCHGiJHyOOudiTjYY2nUni6JpcO82djhewMKIZ9mZP1GsGqCIT7c602t2uiEjZSkW7AE9COviikydAw49Ao0kw+n0IsJQ+kKIeWzVJIJzx2rqte8u7xkn70CDGAdWQXaVW3uPcNjMdc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723221746; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=GweRci6pk8sulGV04wRqY9sIzWYPcIUMRkMZnevNzGU=; b=OJLu3Frq2fbjkOP1C67kirV9zfIs9I/SloSO/fCqnk2SW7MPyY8MrcMBnhF98w/+6N2gGE 3+yd9JTEGyLFMGNPjny6P8khOMjWYbUfNczTIOF9WkAq8DJCyZjjYw6NegSot5XqZiyUzx Rs+Zvujb1ksNFVgOmQNAzkBpVu7IJSQ= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-195-S_LC6-XENZaYm75rzPUBzg-1; Fri, 09 Aug 2024 12:42:22 -0400 X-MC-Unique: S_LC6-XENZaYm75rzPUBzg-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E8141944D3C; Fri, 9 Aug 2024 16:42:20 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.25]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 69C6C300019D; Fri, 9 Aug 2024 16:42:18 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 479GgG3N649654 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 9 Aug 2024 18:42:16 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 479GgGpf649606; Fri, 9 Aug 2024 18:42:16 +0200 Date: Fri, 9 Aug 2024 18:42:15 +0200 From: Jakub Jelinek To: Sandra Loosemore Cc: gcc-patches@gcc.gnu.org, tburnus@baylibre.com Subject: Re: [PATCH v3 01/12] OpenMP: metadirective tree data structures and front-end interfaces Message-ID: Reply-To: Jakub Jelinek References: <20240720204231.2229891-1-sloosemore@baylibre.com> <20240720204231.2229891-2-sloosemore@baylibre.com> MIME-Version: 1.0 In-Reply-To: <20240720204231.2229891-2-sloosemore@baylibre.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Jul 20, 2024 at 02:42:20PM -0600, Sandra Loosemore wrote: > +static tree > +omp_encode_kind_arch_isa_props (tree props) > +{ > + if (!props) > + return NULL_TREE; > + size_t length = 1; > + for (tree p = props; p; p = TREE_CHAIN (p)) > + length += strlen (omp_context_name_list_prop (p)) + 1; > + char *buffer = (char *) alloca (length); This should be char *buffer = XALLOCAVEC (char, length); > + /* Generate > + devnum = (num == -1) ? GOMP_DEVICE_HOST_FALLBACK : num); > + to remap -1 for GOMP_* functions. */ In the comment there are 2 closing parens vs. one opening, should the one before ; be dropped? > @@ -150,6 +166,15 @@ extern tree make_trait_set_selector (enum omp_tss_code, tree, tree); > extern tree make_trait_selector (enum omp_ts_code, tree, tree, tree); > extern tree make_trait_property (tree, tree, tree); > > +/* Accessors and constructor for metadirective variants. */ > +#define OMP_METADIRECTIVE_VARIANT_SELECTOR(v) \ > + TREE_PURPOSE (v) > +#define OMP_METADIRECTIVE_VARIANT_DIRECTIVE(v) \ > + TREE_PURPOSE (TREE_VALUE (v)) > +#define OMP_METADIRECTIVE_VARIANT_BODY(v) \ > + TREE_VALUE (TREE_VALUE (v)) I think the above macros should go to tree.h after OMP_METADIRECTIVE_VARIANTS definition, not in this header (plus the docs adjusted not to talk about omp-general.h). Why needs omp-general.h the move in GTFILES etc.? Will just moving those definitions be ok? Otherwise LGTM. Jakub