From: Jeff Law <jeffreyalaw@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>,
Richard Biener <rguenther@suse.de>, Jan Hubicka <jh@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] cfgrtl: Fix up fixup_partitions caused ICE [PR99085]
Date: Tue, 2 Mar 2021 16:39:23 -0700 [thread overview]
Message-ID: <a00ec30e-082f-24bb-b16d-c50cfa13c90f@gmail.com> (raw)
In-Reply-To: <20210216081359.GU4020736@tucnak>
On 2/16/21 1:13 AM, Jakub Jelinek via Gcc-patches wrote:
> Hi!
>
> fixup_partitions sometimes changes some basic blocks from hot partition to
> cold partition, in particular if after unreachable block removal or other
> optimizations a hot partition block is dominated by cold partition block(s).
> It fixes up the edges and jumps on those edges, but when after reorder
> blocks and in rtl (non-cfglayout) mode that is clearly not enough, because
> it keeps the block order the same and so we can end up with more than
> 1 hot/cold section transition in the same function.
>
> So, this patch fixes that up too.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2021-02-15 Jakub Jelinek <jakub@redhat.com>
>
> PR target/99085
> * cfgrtl.c (fixup_partitions): When changing some bbs from hot to cold
> partitions, if in non-layout mode after reorder_blocks also move
> affected blocks to ensure a single partition transition.
>
> * gcc.dg/graphite/pr99085.c: New test.
OK
jeff
prev parent reply other threads:[~2021-03-02 23:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 8:13 Jakub Jelinek
2021-02-23 8:49 ` Patch ping Jakub Jelinek
2021-03-01 13:01 ` Patch ping^2 Jakub Jelinek
2021-03-02 23:39 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a00ec30e-082f-24bb-b16d-c50cfa13c90f@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jh@suse.cz \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).