From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id C3F773858D3C for ; Mon, 2 May 2022 08:50:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C3F773858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 705CB21877; Mon, 2 May 2022 08:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1651481408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X5USOPFdObPluAsia9DXnqg4YZtfYbMchwMnTsyb0Ps=; b=z7Cul2ZmW7eLb60h49Y4Cpha0VYrxqv4T0+ME5PPH5ByTkufpzIoLCdJfsRzS3QeLWemcR /QNwaHFSestiJUQbkBPlG8+KO2NTVecXfsVKGdL9vZZcEP8hZMn/v7UTn1UhbtN5RRRSsR uDOhAOHW8Qe0Cp6MKSqcWlvhscjeSCM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1651481408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X5USOPFdObPluAsia9DXnqg4YZtfYbMchwMnTsyb0Ps=; b=BEwGA+jLaJSVTLwHgPuj6RhQLXj/MQmXbAjXSzEyQnZkm2l3c8fj8bNCYoEIdEH0/y/rW+ XV3pBcu70ilVR2AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5AE49133E5; Mon, 2 May 2022 08:50:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EeN4FECbb2KAFwAAMHmgww (envelope-from ); Mon, 02 May 2022 08:50:08 +0000 Message-ID: Date: Mon, 2 May 2022 10:50:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] gcov: Fix first time gcov info dump Content-Language: en-US To: Sebastian Huber , gcc-patches@gcc.gnu.org References: <20220502084319.69190-1-sebastian.huber@embedded-brains.de> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <20220502084319.69190-1-sebastian.huber@embedded-brains.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2022 08:50:11 -0000 On 5/2/22 10:43, Sebastian Huber wrote: > This patch fixes an issue introduced by commit > ef9a53feae5701953da9161afef2aea0329ec8b2: Works for me, please install it. Martin > > gcc --coverage main.c && ./a.out > libgcov profiling error:a-main.gcda:Error writing > > gcc/ChangeLog: > > * gcov-io.cc (gcov_rewrite): Clear the file error status. > --- > gcc/gcov-io.cc | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gcc/gcov-io.cc b/gcc/gcov-io.cc > index fdf745e6ce1..62032ccfa18 100644 > --- a/gcc/gcov-io.cc > +++ b/gcc/gcov-io.cc > @@ -79,11 +79,14 @@ gcov_is_error (void) > } > > #if IN_LIBGCOV > -/* Move to beginning of file and initialize for writing. */ > +/* Move to beginning of file, initialize for writing, and clear file error > + status. */ > + > GCOV_LINKAGE inline void > gcov_rewrite (void) > { > gcov_var.mode = -1; > + gcov_var.error = GCOV_FILE_NO_ERROR; > fseek (gcov_var.file, 0L, SEEK_SET); > } > #endif