From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=LA3F=JY=arm.com=Richard.Earnshaw@sourceware.org>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by sourceware.org (Postfix) with ESMTP id 14277385022E
	for <gcc-patches@gcc.gnu.org>; Thu, 15 Feb 2024 14:35:30 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14277385022E
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 14277385022E
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708007731; cv=none;
	b=veJO8K5KmVeYEsidRE9F6COxsuV02NCkOAIEcRVZFdQ8/vaR5/GgR4cwQXSovt1IzAJjBVo40KOW5/5+LPlTNGRKQVk4EqTvF7EhEes7fsnZk2jR7VCwReBXHJQ5deSkLc3iO4VJV67DeTddmVLIqxhzkX+9pVQUnrCTSjhQsqM=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1708007731; c=relaxed/simple;
	bh=O/6YZHD6KcBI3ikGJI3l59UGcUgag68jZYprhQ4P4R4=;
	h=Message-ID:Date:MIME-Version:Subject:To:From; b=hyABXbK7fUk/qvzl403VHeu+Wm4HKsv8j2PCGwH3DbnJgK/N5sH/QsMn3y1zQJgxpS6TV/6/mjG93ODwdssx0gheTXVuAaYkhaioGZCyq9f5v4L9kGrtfk+DRhi7KLgx7BE+7/NlmQYhK8HGzrrbcgjO1WpVeIXQzA1kGWJUNP4=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 51F131FB;
	Thu, 15 Feb 2024 06:36:10 -0800 (PST)
Received: from [10.2.78.54] (e120077-lin.cambridge.arm.com [10.2.78.54])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C86C83F7B4;
	Thu, 15 Feb 2024 06:35:28 -0800 (PST)
Message-ID: <a02a73c9-3c2d-4187-ac1e-51d15f8a0126@arm.com>
Date: Thu, 15 Feb 2024 14:35:27 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH][GCC][Arm] Missing optimization pattern for rev16 on
 architectures with thumb1
Content-Language: en-GB
To: Matthieu Longo <matthieu.longo@arm.com>, gcc-patches@gcc.gnu.org
Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
References: <9336d774-4b6e-468b-93fe-98e96a7c4bd2@arm.com>
From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
In-Reply-To: <9336d774-4b6e-468b-93fe-98e96a7c4bd2@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-3490.0 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On 12/02/2024 13:48, Matthieu Longo wrote:
> This patch marks a rev16 test as XFAIL for architectures having only Thumb1 support. The generated code is functionally correct, but the optimization is disabled when -mthumb is equivalent to Thumb1. Fixing the root issue would requires changes that are not suitable for GCC14 stage 4.
> 
> More information at https://linaro.atlassian.net/browse/GNU-1141
> 
> gcc/testsuite/ChangeLog:
> 
>     * gcc.target/arm/rev16_2.c: XFAIL when compiled with Thumb1.

Thanks, I've tweaked the commit message slightly and pushed this.

R.