public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Torbjorn SVENSSON <torbjorn.svensson@foss.st.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] testsuite: Sanitize fails for SP FPU on Arm
Date: Fri, 23 Sep 2022 12:03:41 +0200	[thread overview]
Message-ID: <a03bff74-7ea7-d2b9-f7da-5a7ea008cff8@foss.st.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2209222240000.122140@digraph.polyomino.org.uk>

Hi Joseph,

On 2022-09-23 00:42, Joseph Myers wrote:
> On Thu, 22 Sep 2022, Torbjörn SVENSSON via Gcc-patches wrote:
> 
>> This patch stops reporting fails for Arm targets with single
>> precision floating point unit for types wider than 32 bits (the width
>> of float on arm-none-eabi).
>>
>> As reported in PR102017, fenv is reported as supported in recent
>> versions of newlib. At the same time, for some Arm targets, the
>> implementation in libgcc does not support exceptions and thus, the
>> test fails with a call to abort().
> 
> It's definitely wrong to have this sort of Arm-specific conditional in
> architecture-independent tests.  Tests requiring floating-point exceptions
> support should have an appropriate dg-require-effective-target; if that
> dg-require-effective-target wrongly passes in certain configurations, fix
> it (or e.g. add a new check_effective_target_fenv_exceptions_double to
> verify that exceptions work for double, as opposed to the present
> check_effective_target_fenv_exceptions which checks whether exceptions
> work for float, and then adjust tests requiring exceptions for double to
> use the new effective-target).
> 

Okay, thanks for your review.
I will split this test case into 3 files as for SP FPU, we would like to 
verify that the exception handling for the float part work, but at the 
same time we know that exception handling for double and long double 
should not work.
Do you think it's preferable to have the double and long double should 
be reported as UNSUPPORRTED, or as XFAIL for the SP FPU case?

      reply	other threads:[~2022-09-23 10:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22 16:40 Torbjörn SVENSSON
2022-09-22 22:42 ` Joseph Myers
2022-09-23 10:03   ` Torbjorn SVENSSON [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a03bff74-7ea7-d2b9-f7da-5a7ea008cff8@foss.st.com \
    --to=torbjorn.svensson@foss.st.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).