* [PATCH] Remove legacy external declarations in toplev.h [PR101447]
@ 2021-07-15 1:53 ashimida
2021-07-15 7:58 ` Richard Biener
0 siblings, 1 reply; 3+ messages in thread
From: ashimida @ 2021-07-15 1:53 UTC (permalink / raw)
To: gcc-patches
External declarations in ./gcc/toplev.h is no longer used in newest
version of gcc and should be cleaned up to avoid misunderstandings.
gcc/ChangeLog:
* toplev.h (set_random_seed):
---
diff --git a/gcc/toplev.h b/gcc/toplev.h
index 175944c..f543554 100644
--- a/gcc/toplev.h
+++ b/gcc/toplev.h
@@ -94,11 +94,6 @@ extern bool set_src_pwd (const
char *);
extern HOST_WIDE_INT get_random_seed (bool);
extern void set_random_seed (const char *);
-extern unsigned int min_align_loops_log;
-extern unsigned int min_align_jumps_log;
-extern unsigned int min_align_labels_log;
-extern unsigned int min_align_functions_log;
-
extern void parse_alignment_opts (void);
extern void initialize_rtl (void);
---
The history FYI:
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=e6de53356769e13178975c18b4ce019a800ea946;hp=118f2d8bc3e6804996ca2953b86454ec950054bf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove legacy external declarations in toplev.h [PR101447]
2021-07-15 1:53 [PATCH] Remove legacy external declarations in toplev.h [PR101447] ashimida
@ 2021-07-15 7:58 ` Richard Biener
2021-07-26 14:42 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: Richard Biener @ 2021-07-15 7:58 UTC (permalink / raw)
To: ashimida; +Cc: GCC Patches
On Thu, Jul 15, 2021 at 3:54 AM ashimida via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> External declarations in ./gcc/toplev.h is no longer used in newest
> version of gcc and should be cleaned up to avoid misunderstandings.
OK
> gcc/ChangeLog:
>
> * toplev.h (set_random_seed):
>
> ---
> diff --git a/gcc/toplev.h b/gcc/toplev.h
> index 175944c..f543554 100644
> --- a/gcc/toplev.h
> +++ b/gcc/toplev.h
> @@ -94,11 +94,6 @@ extern bool set_src_pwd (const
> char *);
> extern HOST_WIDE_INT get_random_seed (bool);
> extern void set_random_seed (const char *);
>
> -extern unsigned int min_align_loops_log;
> -extern unsigned int min_align_jumps_log;
> -extern unsigned int min_align_labels_log;
> -extern unsigned int min_align_functions_log;
> -
> extern void parse_alignment_opts (void);
>
> extern void initialize_rtl (void);
>
> ---
> The history FYI:
> https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=e6de53356769e13178975c18b4ce019a800ea946;hp=118f2d8bc3e6804996ca2953b86454ec950054bf
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove legacy external declarations in toplev.h [PR101447]
2021-07-15 7:58 ` Richard Biener
@ 2021-07-26 14:42 ` Jeff Law
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Law @ 2021-07-26 14:42 UTC (permalink / raw)
To: Richard Biener, ashimida; +Cc: GCC Patches
On 7/15/2021 1:58 AM, Richard Biener via Gcc-patches wrote:
> On Thu, Jul 15, 2021 at 3:54 AM ashimida via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>>
>> External declarations in ./gcc/toplev.h is no longer used in newest
>> version of gcc and should be cleaned up to avoid misunderstandings.
> OK
>
>> gcc/ChangeLog:
>>
>> * toplev.h (set_random_seed):
I've fixed the ChangeLog and committed this to the trunk for Ashimida.
Ashimida -- in the future please don't close the PR until the change has
been committed to the trunk.
Thanks,
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-26 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15 1:53 [PATCH] Remove legacy external declarations in toplev.h [PR101447] ashimida
2021-07-15 7:58 ` Richard Biener
2021-07-26 14:42 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).