From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 918FD3939C33 for ; Mon, 26 Jul 2021 14:42:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 918FD3939C33 Received: by mail-pl1-x62d.google.com with SMTP id e14so11897180plh.8 for ; Mon, 26 Jul 2021 07:42:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=o+X3kvB0iz8pUqDsgP585Xf2TPsm/y97XVoIybSGhs8=; b=f7vh5XIsRjHTN9xBAs2ZlsmiRa1Br3UklLeIBdpt6hrJ8VWFkka1q6649D+Bz6vwox cEunZx9vXrfBsQu9nTWhjB1pJwH5c6eZ8p299mbRckJffe8Ga1PCPKovKJIbYPIU4frC +Aj6NYFlSoFWpwcA0M5ja+0EOrVBrMyA1HMDlDyCCod4xUc+PUVRmlSlMk9s9rkiL4Zs +9M7YHjWOEU9+bGTzKagFoUcbWmULWX2o7FyhlcUmy53oqY0s0zCfQC+2LNNt3PSrJPb qly3oLrAGruvE7Tycq2+OXw+qHv4osZo/kMYP/LtnED+jnZv6ZX7BBU6DZhrB42O9mt3 HXMg== X-Gm-Message-State: AOAM532wqLVDD9b7kvhRSTQWQJFdgqnd/dXSKvT+x62gV84rCG1BsTpa p6vtdMDD/SMMVDZn8iZD/TN76mvxPXo= X-Google-Smtp-Source: ABdhPJxOg+Evzw8OLi6QAPHPDt1kF4K1g0QSWNqPZ+jiq888Q0xGNSgEyJjuppMKPLPnGbl0HJiJcg== X-Received: by 2002:a63:f00d:: with SMTP id k13mr19061891pgh.260.1627310540374; Mon, 26 Jul 2021 07:42:20 -0700 (PDT) Received: from [192.168.1.17] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id e8sm190255pfm.218.2021.07.26.07.42.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jul 2021 07:42:20 -0700 (PDT) Subject: Re: [PATCH] Remove legacy external declarations in toplev.h [PR101447] To: Richard Biener , ashimida Cc: GCC Patches References: <79e96909-5e54-316f-fb8a-9954ea4c6460@linux.alibaba.com> From: Jeff Law Message-ID: Date: Mon, 26 Jul 2021 08:42:17 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jul 2021 14:42:22 -0000 On 7/15/2021 1:58 AM, Richard Biener via Gcc-patches wrote: > On Thu, Jul 15, 2021 at 3:54 AM ashimida via Gcc-patches > wrote: >> >> External declarations in ./gcc/toplev.h is no longer used in newest >> version of gcc and should be cleaned up to avoid misunderstandings. > OK > >> gcc/ChangeLog: >> >> * toplev.h (set_random_seed): I've fixed the ChangeLog and committed this to the trunk for Ashimida. Ashimida -- in the future please don't close the PR until the change has been committed to the trunk. Thanks, Jeff