From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38056 invoked by alias); 5 Oct 2018 16:40:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 38041 invoked by uid 89); 5 Oct 2018 16:40:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*vmakarov, Hx-languages-length:1027 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 Oct 2018 16:40:45 +0000 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w95GdYxT144318 for ; Fri, 5 Oct 2018 12:40:43 -0400 Received: from e15.ny.us.ibm.com (e15.ny.us.ibm.com [129.33.205.205]) by mx0a-001b2d01.pphosted.com with ESMTP id 2mxan0byps-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 05 Oct 2018 12:40:42 -0400 Received: from localhost by e15.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 5 Oct 2018 12:40:36 -0400 Received: from b01cxnp22033.gho.pok.ibm.com (9.57.198.23) by e15.ny.us.ibm.com (146.89.104.202) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 5 Oct 2018 12:40:33 -0400 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w95GeW5846071894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Oct 2018 16:40:32 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0197BAE063; Fri, 5 Oct 2018 12:38:44 -0400 (EDT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 97D61AE062; Fri, 5 Oct 2018 12:38:43 -0400 (EDT) Received: from otta.local (unknown [9.85.130.97]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 5 Oct 2018 12:38:43 -0400 (EDT) Subject: Re: [PATCH 2/2 v3][IRA,LRA] Fix PR86939, IRA incorrectly creates an interference between a pseudo register and a hard register To: Vladimir Makarov Cc: GCC Patches , "H.J. Lu" , Jeffrey Law References: <616affd5-5140-8e15-9081-1635f7d4e700@redhat.com> <6ff45a7e-2415-2d18-1d53-5a50964a2174@linux.ibm.com> <14bf79ef-9db2-e76b-df10-fcb2574d5ccb@linux.ibm.com> <121ca751-fb38-d7e1-bffd-89df22a2fdd7@redhat.com> From: Peter Bergner Date: Fri, 05 Oct 2018 16:50:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <121ca751-fb38-d7e1-bffd-89df22a2fdd7@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit x-cbid: 18100516-0068-0000-0000-0000034841D3 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009825; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000267; SDB=6.01098303; UDB=6.00568066; IPR=6.00878343; MB=3.00023630; MTD=3.00000008; XFM=3.00000015; UTC=2018-10-05 16:40:34 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18100516-0069-0000-0000-000045F82C0F Message-Id: X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00335.txt.bz2 On 10/4/18 3:01 PM, Vladimir Makarov wrote: > IMHO, the name copy_insn_p is too common and confusing (we already have > functions copy_insn and copy_insn_1 in GCC). The name does not reflect its > result meaning. I would call it something like non_conflict_copy_source_reg > although it is long. I'm fine with renaming it. I'm not sure I like the use of source reg in the name even though it is what is returned. That is just a convenience for the caller of the function. Its true purpose is recognizing whether INSN is or is not a reg to reg copy for which we can ignore their interference. How about is_reg_copy_insn_p() or is_reg_to_reg_copy_p() or ??? > Also I would rename last_regno to bound_regno because it is better reflect > variable value meaning or at least to end_regno as it is a value of END_REGNO > macro. Ok, I went with end_regno, since that seems to be used elsewhere. Peter