From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bumble.maple.relay.mailchannels.net (bumble.maple.relay.mailchannels.net [23.83.214.25]) by sourceware.org (Postfix) with ESMTPS id 6EFAF3858D35 for ; Thu, 16 Dec 2021 18:57:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6EFAF3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 0027112073D; Thu, 16 Dec 2021 18:57:04 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 896041204F1; Thu, 16 Dec 2021 18:57:03 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.99.165.210 (trex/6.4.3); Thu, 16 Dec 2021 18:57:03 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Decisive-Cold: 6bf406016284b0aa_1639681023829_4228501258 X-MC-Loop-Signature: 1639681023829:4117676652 X-MC-Ingress-Time: 1639681023828 Received: from [192.168.52.116] (unknown [223.185.62.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4JFLvK3JPjz1PV; Thu, 16 Dec 2021 10:57:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gotplt.org; s=gotplt.org; t=1639681022; bh=V72Q+mvK1l0xkyaA7tgxJw8NLTw=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=Hxy9/Qdp1mKMG6ARDp9xCtI7sPqV1v5eGwXqFJtlYYFrPDS4Y5BqVkji123gbHeBT IJr/cBFTvYhqLl4l1/Ne6MdxZqFEI6dBbWM0cvD1lU0qVSd+kGk2IiuDWlu67x+01c TngQENGVyjSphfpKYqnCcu+SGmwWDe8dDkqw2+7U= Message-ID: Date: Fri, 17 Dec 2021 00:26:56 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v4 1/6] tree-object-size: Use trees and support negative offsets Content-Language: en-US To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org References: <20211109190137.1107736-1-siddhesh@gotplt.org> <20211201142757.4086840-1-siddhesh@gotplt.org> <20211201142757.4086840-2-siddhesh@gotplt.org> <20211215152151.GJ2646553@tucnak> <873ad5ef-2d95-4f11-bb4e-b82fa2a1ddf2@gotplt.org> <20211215184316.GM2646553@tucnak> <43576001-84b0-032c-37d6-6ea60cdf9ca6@gotplt.org> <20211216154920.GV2646553@tucnak> From: Siddhesh Poyarekar In-Reply-To: <20211216154920.GV2646553@tucnak> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3029.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Dec 2021 18:57:08 -0000 On 12/16/21 21:19, Jakub Jelinek wrote: > Yes, but please fix up formatting, wholeval should go below old_wholeval. > Though, perhaps it would be better to: > > if (tree_int_cst_compare (oldval, val)) > return true; > > gcc_checking_assert (tree_int_cst_compare (old_wholeval, wholeval) == 0); > return false; > > Ok with that change. > > Jakub > I thought about this some more and I think I'm wrong in assuming that wholeval won't change in subsequent passes; my tests show I'm wrong too. I'm now testing with the condition fixed up to: return (tree_int_cst_compare (oldval, val) != 0 || tree_int_cst_compare (old_wholeval, wholeval) != 0); as you had suggested earlier and will push it if it passes bootstrap and a clean testsuite run. I'm doing a ubsan bootstrap too because it's been quite useful in catching corner cases in __bos before. Thanks, Siddhesh