From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E574F385840B for ; Fri, 24 May 2024 14:01:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E574F385840B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E574F385840B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716559292; cv=none; b=kzkNP8xdbgnCvJEL0x4wRgejAljKbMSkqhBlSMR8sCSI1OinPP0DlgV582oxRhuyteMPry+7zeSgr58iXbIRIE/p1oytwEueS53QOwUShoPhFylVFp/Z0XwkM01b0FaMeFEPP3gIEa7nye7ehDAIifVZst7GNHnHCPJ8UtHtMEw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716559292; c=relaxed/simple; bh=xW1wS6giCAtxWLYIBAOV8ULldxs0Hy88doJM5hYQhWs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=IzHhUH1+Fz3jtXhc2hG/Wjiy6YpJviSDw4aXkB4ltl1VnUvX2x4pCK+gI2V3z6Fm6x3sR0H+QnbGPA/Voh+OhjsXsMJLOq5TTqTgb6/iBZl2BpUT1WJCp+tZOQREaB9msCw1hi+l3L+SxTK2yf8jxaWwyImzcp2vAmkWc6cxZsg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716559289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=coClnJlJvNJyTikCbynw+gi9BZfD12hsRE1fLqvI81E=; b=NSoNhVW1kg7opY4NgZZO/k4pt+8C4SlxDfL2dwy0EqQjYxmRzFL7wROX0Da64XOKW7FhMZ JZYVWsHnnsEghW3XijfyKu6qahN9LuQlEUI/4RmQcwdmQStvRYTbC1YQqJ1sG0s09ykAM3 7QD9n2e6AXtEsy9IrrzqcjNQYia7Pgc= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-360-IKgfEhClObmPx8apZ43YMw-1; Fri, 24 May 2024 10:01:27 -0400 X-MC-Unique: IKgfEhClObmPx8apZ43YMw-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6ab8467e576so15858906d6.0 for ; Fri, 24 May 2024 07:01:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716559287; x=1717164087; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=coClnJlJvNJyTikCbynw+gi9BZfD12hsRE1fLqvI81E=; b=aduzSJFnSEFWLAjEK9NXA2s9mCsT9u6q2bBuZvnQuCQeSPhXQgC7+OcWSRTQxpYT/N x7fJ2Fom/0/2J0zEJOTRm+Tq1FXwO5+AsWC3mqJyiJRaaqpA8NeXUoGEpd1uN0ke/xos Vb97l+JqniOe0YJIvgS2HSBYhFhB26bbQZlTEVJxFJzAxiehApM7AeV9TipRJPkZX0jK BKvSaTSJNNRf77E/rK53t9KeQLYwRhFjLuWBCtNqRHF4wTkwR++hh6GnGl/vTJdwEMk/ ISttaZjiHuVa/Z+lyi39VDpGm4doFNGtQ9D14H3q9gJlte4FlwU6WaQ1Jxy3UzU90rrn feDg== X-Gm-Message-State: AOJu0Yx668DZD0wlLofr9TQOdsZZlBjf96tPhrkxvrvUl5+v/Q8ACw8y I4T1RnNfAgZTdNLUfuOlIpMVzGPBcwJ1lo0NYBnDtvX7nh6EHix7cCePLeVmG/L4kcadT9RSXfm 2ROnp8cNC63KHIMEtpmBsTTJxxDjJZZ6rgJQAQ7mbA0utk+paI5eKXIY= X-Received: by 2002:a05:6214:5c08:b0:6ab:8868:5186 with SMTP id 6a1803df08f44-6abc3e87ce8mr22060586d6.2.1716559286858; Fri, 24 May 2024 07:01:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFoA0so+539CnuvzRfdRNNMsaYNLBXPlQRwJyHd/83VYSFQvJLc+q2M+pRoZz+DkR5zhUTB/w== X-Received: by 2002:a05:6214:5c08:b0:6ab:8868:5186 with SMTP id 6a1803df08f44-6abc3e87ce8mr22060236d6.2.1716559286331; Fri, 24 May 2024 07:01:26 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ac070c7f32sm7505036d6.8.2024.05.24.07.01.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 May 2024 07:01:25 -0700 (PDT) Message-ID: Date: Fri, 24 May 2024 10:01:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] c++: mark TARGET_EXPRs for function arguments eliding [PR114707] To: Marek Polacek Cc: GCC Patches References: <20240523144145.15177-1-polacek@redhat.com> <4bff239a-0437-488d-a295-09e218d4cb8d@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/23/24 20:32, Marek Polacek wrote: > On Thu, May 23, 2024 at 04:04:13PM -0400, Jason Merrill wrote: >> On 5/23/24 10:41, Marek Polacek wrote: >>> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? >>> >>> -- >8 -- >>> Coming back to our discussion in >>> : >>> TARGET_EXPRs that initialize a function argument are not marked >>> TARGET_EXPR_ELIDING_P even though gimplify_arg drops such TARGET_EXPRs >>> on the floor. >> >> But only if TREE_TYPE (TARGET_EXPR_INITIAL is non-void, I think we should >> check that here too to be parallel. > > Ah yes, definitely. > >> Perhaps most/all affected TARGET_EXPRs will have been handled earlier in the >> function under the TREE_ADDRESSABLE check, but I wouldn't rely on that >> without an assert. > > So like this or you want an assert somewhere too? dg.exp passed. > > -- >8 -- > Coming back to our discussion in > : > TARGET_EXPRs that initialize a function argument are not marked > TARGET_EXPR_ELIDING_P even though gimplify_arg drops such TARGET_EXPRs > on the floor. To work around it, I added a pset to > replace_placeholders_for_class_temp_r, but it would be best to just rely > on TARGET_EXPR_ELIDING_P. > > PR c++/114707 > > gcc/cp/ChangeLog: > > * call.cc (convert_for_arg_passing): Call set_target_expr_eliding. > * typeck2.cc (replace_placeholders_for_class_temp_r): Don't use pset. > (digest_nsdmi_init): Call cp_walk_tree_without_duplicates instead of > cp_walk_tree. > --- > gcc/cp/call.cc | 6 ++++++ > gcc/cp/typeck2.cc | 20 ++++---------------- > 2 files changed, 10 insertions(+), 16 deletions(-) > > diff --git a/gcc/cp/call.cc b/gcc/cp/call.cc > index ed68eb3c568..35c024f2c7c 100644 > --- a/gcc/cp/call.cc > +++ b/gcc/cp/call.cc > @@ -9437,6 +9437,12 @@ convert_for_arg_passing (tree type, tree val, tsubst_flags_t complain) > if (complain & tf_warning) > warn_for_address_of_packed_member (type, val); > > + /* gimplify_arg elides TARGET_EXPRs that initialize a function argument. */ > + if (TREE_CODE (val) == TARGET_EXPR) > + if (tree init = TARGET_EXPR_INITIAL (val)) > + if (!VOID_TYPE_P (TREE_TYPE (init))) You can simplify this test to 'if (SIMPLE_TARGET_EXPR_P ...'. OK with that change. Jason