* [ping * 2] PR78736: New C warning -Wenum-conversion
@ 2017-05-23 14:13 Prathamesh Kulkarni
2017-06-29 22:04 ` Jeff Law
0 siblings, 1 reply; 4+ messages in thread
From: Prathamesh Kulkarni @ 2017-05-23 14:13 UTC (permalink / raw)
To: gcc Patches, Joseph S. Myers, Marek Polacek
Hi,
I would like to ping this patch for review:
https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00775.html
Thanks,
Prathamesh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ping * 2] PR78736: New C warning -Wenum-conversion
2017-05-23 14:13 [ping * 2] PR78736: New C warning -Wenum-conversion Prathamesh Kulkarni
@ 2017-06-29 22:04 ` Jeff Law
2017-06-29 23:01 ` Joseph Myers
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Law @ 2017-06-29 22:04 UTC (permalink / raw)
To: Prathamesh Kulkarni, gcc Patches, Joseph S. Myers, Marek Polacek
On 05/23/2017 07:54 AM, Prathamesh Kulkarni wrote:
> Hi,
> I would like to ping this patch for review:
> https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00775.html
So was there any kind of resolution on the case in libcomp where we had
an assignment between two essentially equivalent, but distinct enums?
Aren't we going to trip over that if this is in -Wall? And if so and we
wanted to keep this in -Wall, then don't we need a cast here?
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ping * 2] PR78736: New C warning -Wenum-conversion
2017-06-29 22:04 ` Jeff Law
@ 2017-06-29 23:01 ` Joseph Myers
2017-06-30 15:21 ` Jeff Law
0 siblings, 1 reply; 4+ messages in thread
From: Joseph Myers @ 2017-06-29 23:01 UTC (permalink / raw)
To: Jeff Law; +Cc: Prathamesh Kulkarni, gcc Patches, Marek Polacek
On Thu, 29 Jun 2017, Jeff Law wrote:
> On 05/23/2017 07:54 AM, Prathamesh Kulkarni wrote:
> > Hi,
> > I would like to ping this patch for review:
> > https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00775.html
> So was there any kind of resolution on the case in libcomp where we had
> an assignment between two essentially equivalent, but distinct enums?
I don't know. I approved this patch on the 12th subject to one
correction, but see it hasn't yet been committed.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ping * 2] PR78736: New C warning -Wenum-conversion
2017-06-29 23:01 ` Joseph Myers
@ 2017-06-30 15:21 ` Jeff Law
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Law @ 2017-06-30 15:21 UTC (permalink / raw)
To: Joseph Myers; +Cc: Prathamesh Kulkarni, gcc Patches, Marek Polacek
On 06/29/2017 05:01 PM, Joseph Myers wrote:
> On Thu, 29 Jun 2017, Jeff Law wrote:
>
>> On 05/23/2017 07:54 AM, Prathamesh Kulkarni wrote:
>>> Hi,
>>> I would like to ping this patch for review:
>>> https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00775.html
>> So was there any kind of resolution on the case in libcomp where we had
>> an assignment between two essentially equivalent, but distinct enums?
>
> I don't know. I approved this patch on the 12th subject to one
> correction, but see it hasn't yet been committed.
OK. I missed that (not uncommon given the depth of the queue of things
I'm working through). I'll trust that Prathamesh will commit after
addressing the one issue you raised.
THanks,
jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-30 15:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-23 14:13 [ping * 2] PR78736: New C warning -Wenum-conversion Prathamesh Kulkarni
2017-06-29 22:04 ` Jeff Law
2017-06-29 23:01 ` Joseph Myers
2017-06-30 15:21 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).