public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Delia Burduv <Delia.Burduv@arm.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: "nickc@redhat.com" <nickc@redhat.com>,
	Richard Earnshaw	<Richard.Earnshaw@arm.com>,
	Ramana Radhakrishnan	<Ramana.Radhakrishnan@arm.com>,
	Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
Subject: Re: [GCC][PATCH][AArch32] ACLE intrinsics bfloat16 vmmla and vfma<b/t> for AArch32 AdvSIMD
Date: Wed, 22 Jan 2020 17:45:00 -0000	[thread overview]
Message-ID: <a0ef840e-d3f9-ce55-d56c-035e33d1afa5@arm.com> (raw)
In-Reply-To: <1994305c-a05b-774b-15da-5f1474b7c841@arm.com>

Ping.

I have read Richard Sandiford's comments on the AArch64 patches and I 
will apply what is relevant to this patch as well. Particularly, I will 
change the tests to use the exact input and output registers and I will 
change the types of the rtl patterns.

On 12/20/19 6:44 PM, Delia Burduv wrote:
> This patch adds the ARMv8.6 ACLE intrinsics for vmmla, vfmab and vfmat 
> as part of the BFloat16 extension.
> (https://developer.arm.com/docs/101028/latest.)
> The intrinsics are declared in arm_neon.h and the RTL patterns are 
> defined in neon.md.
> Two new tests are added to check assembler output and lane indices.
> 
> This patch depends on the Arm back-end patche. 
> (https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01448.html)
> 
> Tested for regression on arm-none-eabi and armeb-none-eabi. I don't have 
> commit rights, so if this is ok can someone please commit it for me?
> 
> gcc/ChangeLog:
> 
> 2019-11-12  Delia Burduv  <delia.burduv@arm.com>
> 
>      * config/arm/arm_neon.h (vbfmmlaq_f32): New.
>        (vbfmlalbq_f32): New.
>        (vbfmlaltq_f32): New.
>        (vbfmlalbq_lane_f32): New.
>        (vbfmlaltq_lane_f32): New.
>          (vbfmlalbq_laneq_f32): New.
>        (vbfmlaltq_laneq_f32): New.
>      * config/arm/arm_neon_builtins.def (vbfmmla): New.
>            (vbfmab): New.
>            (vbfmat): New.
>            (vbfmab_lane): New.
>            (vbfmat_lane): New.
>            (vbfmab_laneq): New.
>            (vbfmat_laneq): New.
>       * config/arm/iterators.md (BF_MA): New int iterator.
>            (bt): New int attribute.
>            (VQXBF): Copy of VQX with V8BF.
>            (V_HALF): Added V8BF.
>        * config/arm/neon.md (neon_vbfmmlav8hi): New insn.
>            (neon_vbfma<bt>v8hi): New insn.
>            (neon_vbfma<bt>_lanev8hi): New insn.
>            (neon_vbfma<bt>_laneqv8hi): New expand.
>            (neon_vget_high<mode>): Changed iterator to VQXBF.
>      * config/arm/unspecs.md (UNSPEC_BFMMLA): New UNSPEC.
>            (UNSPEC_BFMAB): New UNSPEC.
>            (UNSPEC_BFMAT): New UNSPEC.
> 
> 2019-11-12  Delia Burduv  <delia.burduv@arm.com>
> 
>          * gcc.target/arm/simd/bf16_ma_1.c: New test.
>          * gcc.target/arm/simd/bf16_ma_2.c: New test.
>          * gcc.target/arm/simd/bf16_mmla_1.c: New test.

  reply	other threads:[~2020-01-22 17:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-20 18:46 Delia Burduv
2020-01-22 17:45 ` Delia Burduv [this message]
2020-01-28 16:52   ` Delia Burduv
2020-01-30 15:55     ` Kyrill Tkachov
2020-01-31 16:21       ` Delia Burduv
2020-02-19 17:23         ` Delia Burduv
2020-02-21 11:41           ` Kyrill Tkachov
2020-03-04 17:21             ` Delia Burduv
2020-03-05 11:22               ` Kyrill Tkachov
2020-03-05 17:49                 ` Kyrill Tkachov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0ef840e-d3f9-ce55-d56c-035e33d1afa5@arm.com \
    --to=delia.burduv@arm.com \
    --cc=Kyrylo.Tkachov@arm.com \
    --cc=Ramana.Radhakrishnan@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).