From: Robin Dapp <rdapp.gcc@gmail.com>
To: 钟居哲 <juzhe.zhong@rivai.ai>, "kito.cheng" <kito.cheng@gmail.com>
Cc: rdapp.gcc@gmail.com, gcc-patches <gcc-patches@gcc.gnu.org>,
palmer <palmer@dabbelt.com>, Jeff Law <jeffreyalaw@gmail.com>
Subject: Re: [PATCH] RISC-V: Add rawmemchr expander.
Date: Fri, 27 Oct 2023 13:46:36 +0200 [thread overview]
Message-ID: <a110bb22-5543-4f2f-8f56-33ef1e8bba93@gmail.com> (raw)
In-Reply-To: <2628B40764CD408E+20231027193944488244115@rivai.ai>
> It seems that you didn't commit it yet.
>
> A nit comment:
>
> + int lmul = riscv_autovec_lmul == RVV_DYNAMIC ? RVV_M8 : riscv_autovec_lmul;
>
> I change you could use TARGET_MAX_LMUL
No didn't commit yet, testsuite was still running.
OK, added it, will commit later.
Regards
Robin
next prev parent reply other threads:[~2023-10-27 11:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 20:29 Robin Dapp
2023-10-26 22:37 ` 钟居哲
2023-10-27 7:38 ` Robin Dapp
2023-10-27 7:39 ` juzhe.zhong
2023-10-27 7:47 ` Kito Cheng
2023-10-27 7:51 ` Robin Dapp
2023-10-27 7:52 ` juzhe.zhong
2023-10-27 7:53 ` Robin Dapp
2023-10-27 8:50 ` Robin Dapp
2023-10-27 11:39 ` 钟居哲
2023-10-27 11:46 ` Robin Dapp [this message]
2023-10-27 13:38 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a110bb22-5543-4f2f-8f56-33ef1e8bba93@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).