From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id ABEB23856099 for ; Mon, 6 Jun 2022 08:50:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ABEB23856099 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2568FRPf024012; Mon, 6 Jun 2022 08:50:54 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gggr8v1rv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jun 2022 08:50:54 +0000 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2568ln4C017518; Mon, 6 Jun 2022 08:50:54 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gggr8v1r9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jun 2022 08:50:53 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2568ZWXG005521; Mon, 6 Jun 2022 08:50:51 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma03ams.nl.ibm.com with ESMTP id 3gfy19a4hs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jun 2022 08:50:51 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2568onqW49873326 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Jun 2022 08:50:49 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B8DFA4060; Mon, 6 Jun 2022 08:50:49 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 926C3A405F; Mon, 6 Jun 2022 08:50:47 +0000 (GMT) Received: from [9.197.252.204] (unknown [9.197.252.204]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 6 Jun 2022 08:50:47 +0000 (GMT) Message-ID: Date: Mon, 6 Jun 2022 16:50:45 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: PING^1 [PATCH] rs6000: Handle unresolved overloaded builtin [PR105485] Content-Language: en-US To: GCC Patches Cc: Peter Bergner , David Edelsohn , Segher Boessenkool References: <340fcec1-eb5e-e0f6-e8d1-ea819d4fd165@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <340fcec1-eb5e-e0f6-e8d1-ea819d4fd165@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: XoKxxLhpGs_n3Bu2qOC-0MWzX8dIwZTH X-Proofpoint-GUID: R8lDjRQwIXTcvZNNW6TKr7dm80U--Bmo Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-06_02,2022-06-03_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 impostorscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0 clxscore=1015 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206060039 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2022 08:51:01 -0000 Hi, Gentle ping https://gcc.gnu.org/pipermail/gcc-patches/2022-May/594699.html BR, Kewen on 2022/5/13 13:29, Kewen.Lin via Gcc-patches wrote: > Hi, > > PR105485 exposes that new builtin function framework doesn't handle > unresolved overloaded builtin function well. With new builtin > function support, we don't have builtin info for any overloaded > rs6000_gen_builtins enum, since they are expected to be resolved to > one specific instance. So when function rs6000_gimple_fold_builtin > faces one unresolved overloaded builtin, the access for builtin info > becomes out of bound and gets ICE then. > > We should not try to fold one unresolved overloaded builtin there > and as the previous support we should emit one error message during > expansion phase like "unresolved overload for builtin ...". > > Bootstrapped and regtested on powerpc64-linux-gnu P8 and > powerpc64le-linux-gnu P9 and P10. > > Is it ok for trunk? > > BR, > Kewen > ----- > PR target/105485 > > gcc/ChangeLog: > > * config/rs6000/rs6000-builtin.cc (rs6000_gimple_fold_builtin): Add > the handling for unresolved overloaded builtin function. > (rs6000_expand_builtin): Likewise. > > gcc/testsuite/ChangeLog: > > * g++.target/powerpc/pr105485.C: New test. > > --- > gcc/config/rs6000/rs6000-builtin.cc | 13 +++++++++++++ > gcc/testsuite/g++.target/powerpc/pr105485.C | 9 +++++++++ > 2 files changed, 22 insertions(+) > create mode 100644 gcc/testsuite/g++.target/powerpc/pr105485.C > > diff --git a/gcc/config/rs6000/rs6000-builtin.cc b/gcc/config/rs6000/rs6000-builtin.cc > index e925ba9fad9..e102305c90c 100644 > --- a/gcc/config/rs6000/rs6000-builtin.cc > +++ b/gcc/config/rs6000/rs6000-builtin.cc > @@ -1294,6 +1294,11 @@ rs6000_gimple_fold_builtin (gimple_stmt_iterator *gsi) > enum tree_code bcode; > gimple *g; > > + /* For an unresolved overloaded builtin, return early here since there > + is no builtin info for it and we are unable to fold it. */ > + if (fn_code > RS6000_OVLD_NONE) > + return false; > + > size_t uns_fncode = (size_t) fn_code; > enum insn_code icode = rs6000_builtin_info[uns_fncode].icode; > const char *fn_name1 = rs6000_builtin_info[uns_fncode].bifname; > @@ -3295,6 +3300,14 @@ rs6000_expand_builtin (tree exp, rtx target, rtx /* subtarget */, > tree fndecl = TREE_OPERAND (CALL_EXPR_FN (exp), 0); > enum rs6000_gen_builtins fcode > = (enum rs6000_gen_builtins) DECL_MD_FUNCTION_CODE (fndecl); > + > + /* Emit error message if it's an unresolved overloaded builtin. */ > + if (fcode > RS6000_OVLD_NONE) > + { > + error ("unresolved overload for builtin %qF", fndecl); > + return const0_rtx; > + } > + > size_t uns_fcode = (size_t)fcode; > enum insn_code icode = rs6000_builtin_info[uns_fcode].icode; > > diff --git a/gcc/testsuite/g++.target/powerpc/pr105485.C b/gcc/testsuite/g++.target/powerpc/pr105485.C > new file mode 100644 > index 00000000000..a3b8290df8c > --- /dev/null > +++ b/gcc/testsuite/g++.target/powerpc/pr105485.C > @@ -0,0 +1,9 @@ > +/* It's to verify no ICE here, ignore error/warning messages since > + they are not test points here. */ > +/* { dg-excess-errors "pr105485" } */ > + > +template void __builtin_vec_vslv(); > +typedef __attribute__((altivec(vector__))) char T; > +T b (T c, T d) { > + return __builtin_vec_vslv(c, d); > +}