From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 61071385841E for ; Mon, 23 Oct 2023 14:15:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 61071385841E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 61071385841E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698070512; cv=none; b=aCtD/dZvdc7xAGrSwqBG3WlgcgOvXw+dPMYSKvM/Qfn53TJ72wJ+mo2Uz8/Tao7nO9N539ELFAyrJgteYbSbXy9dBiM1Thdq6Qc7CCLZSdZIWJGw32mJr5aihS8NQYPuKdJgQGO5TrKhd+JmcQVfdriXvRxmmJFh5pCIjRkjX1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698070512; c=relaxed/simple; bh=3J8WNX6ajK5BiuHHt7jpqdraoyyMEZnLytxCaFynJdM=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=pFZIn58VV4BVBVXPMTsuSRbAOxh7bXz7KSMpDRkT1+/hmjzdr4qXrHJpt4NhCrkSbTuiXE1crVzzDc5hmDssgPqlbVmGWD6LE15EBmasiR7r1TRtjpQgDiz8JKMqBBlzASnr4E3YcIrXqpLKME7bTmotfUq7KY+NhE8Y2WpdqZA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698070510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3J8WNX6ajK5BiuHHt7jpqdraoyyMEZnLytxCaFynJdM=; b=FPn62EgpYJ1iW653NcBRGA9VVBuA5W54EQNarXdp9uDFJ0tHw+ezArWF9UcXV2CA8jJFPW d5T1zkVLHxBXBJ8XUOcBE833P8sV4wY4iZUvfRa9pV174Xf+sJMXBjf5ndgs01VbOz3WFD Z/t764C1MBUG+GSv5Z/29hHfWN/2Xy4= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-186-YkqkQsCTMiGOstxTDSKfjQ-1; Mon, 23 Oct 2023 10:15:08 -0400 X-MC-Unique: YkqkQsCTMiGOstxTDSKfjQ-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-66d75988385so39699536d6.2 for ; Mon, 23 Oct 2023 07:15:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698070507; x=1698675307; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3J8WNX6ajK5BiuHHt7jpqdraoyyMEZnLytxCaFynJdM=; b=BLBT2lmw9zy3DofH1yUKLWt0jUlAOhgAqmLcapZd3RRW70+jDkVN3Vt5h41/u24y0J v7MkobVcJAvgLNAI8i2j5UnPqHiAY7eVjzGo20E7xLtnphTBT9Q8PTh+pWHVg2ALHEYk YPCnozpfqBjWERQC9wcu8cq5fRzAao3a2SchyabVEkmfP4AS39a0pCTjQogz3sn/kOec B359p6QiyxNWiR5StwyywYT8lu6MaLRqoCaW/G59BqCWNXfVPe0/gJnQZwT57DbCkL7a VeGaBv9DrzJ3a+SDEKWn9Ji/YuuOMDOVhaGwET3C9hfqb0MY75yWhd+br0KPZoYg843l MeEQ== X-Gm-Message-State: AOJu0YyO23C3e+sZbxBTI62gBzc+bw6BGjr7MK88sxou3RJXiqqCKapd Xy241EwpJblMItC8dSk1THSQV9KL+jZeu9VkKjzSPqbvxeknw9AeIMDutA3zjbTTUV/1LpmVsA5 MVGkh6vahfWqly9k6ew== X-Received: by 2002:a05:6214:27c5:b0:65b:21bf:8fc1 with SMTP id ge5-20020a05621427c500b0065b21bf8fc1mr11727474qvb.42.1698070507746; Mon, 23 Oct 2023 07:15:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGeLd6MsFD+nnMqZhBqzquPEdPC0nS3707J3mdZe6D7ZLmDKQRWA+7DQShm12yqIT8EhwHW+A== X-Received: by 2002:a05:6214:27c5:b0:65b:21bf:8fc1 with SMTP id ge5-20020a05621427c500b0065b21bf8fc1mr11727457qvb.42.1698070507417; Mon, 23 Oct 2023 07:15:07 -0700 (PDT) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id dh14-20020ad458ce000000b0066d1348bdddsm2900783qvb.44.2023.10.23.07.15.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 07:15:06 -0700 (PDT) Message-ID: Subject: Re: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887] From: David Malcolm To: Lewis Hyatt , gcc-patches@gcc.gnu.org Date: Mon, 23 Oct 2023 10:15:05 -0400 In-Reply-To: <20230920041202.4099349-1-lhyatt@gmail.com> References: <20230920041202.4099349-1-lhyatt@gmail.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2023-09-20 at 00:12 -0400, Lewis Hyatt wrote: > Hello- >=20 > This patch implements the PR's request to add more information to the > diagnostic issued for using a poisoned identifier. Bootstrapped + > regtested > all languages on x86-64 Linux. Does it look OK please? Thanks! Thanks! Patch looks good to me; please go ahead and push it. Dave