From: "Kewen.Lin" <linkw@linux.ibm.com>
To: Andrew Pinski <pinskia@gmail.com>,
"Andrew Pinski (QUIC)" <quic_apinski@quicinc.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
David Edelsohn <dje.gcc@gmail.com>,
Peter Bergner <bergner@linux.ibm.com>,
Richard Biener <richard.guenther@gmail.com>
Subject: Re: [PATCH] testsuite: Fix vect_long_mult on Power [PR109705]
Date: Mon, 29 Jan 2024 10:39:55 +0800 [thread overview]
Message-ID: <a1a498b9-3b64-069d-c084-8dc27c49ed44@linux.ibm.com> (raw)
In-Reply-To: <CA+=Sn1mTyEkApSeuCxs3ug7_Arag+T9_cNgRuLyNzJrdJkr-EA@mail.gmail.com>
on 2024/1/27 06:42, Andrew Pinski wrote:
> On Mon, Jan 15, 2024 at 6:43 PM Kewen.Lin <linkw@linux.ibm.com> wrote:
>>
>> Hi,
>>
>> As pointed out by the discussion in PR109705, the current
>> vect_long_mult effective target check on Power is broken.
>> This patch is to fix it accordingly.
>>
>> With additional change by adding a guard vect_long_mult
>> in gcc.dg/vect/pr25413a.c , it's tested well on Power{8,9}
>> LE & BE (also on Power10 LE as before).
>
> I see this is still broken for 32bit PowerPC where vect_long_mult
> should return true still since long there is 32bit and there is a
> 32bit vector multiply.
> Can someone test (and apply if approved) the attached patch to see if
> it fixes pr25413a.c for powerpc*-*-* for 32bit?
Thanks for fixing, it works perfectly as tested.
I just pushed it as r14-8485 (also updating with a tab and commit log).
BR,
Kewen
>
> Thanks,
> Andrew Pinski
>
>>
>> I'm going to push this soon.
>>
>> BR,
>> Kewen
>> -----
>> PR testsuite/109705
>>
>> gcc/testsuite/ChangeLog:
>>
>> * lib/target-supports.exp (check_effective_target_vect_long_mult):
>> Fix powerpc*-*-* checks.
>> ---
>> gcc/testsuite/lib/target-supports.exp | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
>> index 81ae92a0266..fac32fb3d0e 100644
>> --- a/gcc/testsuite/lib/target-supports.exp
>> +++ b/gcc/testsuite/lib/target-supports.exp
>> @@ -9073,9 +9073,9 @@ proc check_effective_target_vect_int_mult { } {
>>
>> proc check_effective_target_vect_long_mult { } {
>> if { [istarget i?86-*-*] || [istarget x86_64-*-*]
>> - || (([istarget powerpc*-*-*]
>> - && ![istarget powerpc-*-linux*paired*])
>> - && [check_effective_target_ilp32])
>> + || ([istarget powerpc*-*-*]
>> + && [check_effective_target_powerpc_vsx_ok]
>> + && [check_effective_target_has_arch_pwr10])
>> || [is-effective-target arm_neon]
>> || ([istarget sparc*-*-*] && [check_effective_target_ilp32])
>> || [istarget aarch64*-*-*]
>> --
>> 2.39.1
prev parent reply other threads:[~2024-01-29 2:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 2:42 Kewen.Lin
2024-01-26 22:42 ` Andrew Pinski
2024-01-29 2:39 ` Kewen.Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1a498b9-3b64-069d-c084-8dc27c49ed44@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
--cc=quic_apinski@quicinc.com \
--cc=richard.guenther@gmail.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).