From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 653B83858C60 for ; Mon, 29 Jan 2024 02:40:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 653B83858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 653B83858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706496006; cv=none; b=x8diJtmlhUrtTlvnZW4xUrTQFYPK3ujQuJYypYQ8JALlyZm9wGOnrUXNIc7j0dJcRBNXrKEdwHdrwY50NfjGF7Jk0j9isJVdj/llUwxv4/hNTrL5q072c44tiNHlPmthoCQ+oIXDJuU+QaRI1gMUUjJ2WyYIU5PhHit5ly5uqmk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706496006; c=relaxed/simple; bh=8B4WsiGOYpZQFHtkOL3nCxLc0CSv7JZNSdRVnHzfQSM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ZIjhdOcaRDkNsG1uwOQIinrv4ueyfAvg5dCFq78pu/9gGqQS35kHKhHXAaf4tH0VYK7TlAZpVE2M4CikUCWKrYispT+tmXCOMQGGvTdxdONQvYrsolN+yslAJVxcyRnV7Eqfv3fH0vVjEnKaE+U0RbKSwqMegIVXu17DVHLAgnI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40T1bviR020760; Mon, 29 Jan 2024 02:40:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Y4zZpbfGxMdJctVhjv27SuHSj4m0QBahWy/ADFO/iEg=; b=hZQJTl5vXCOwqgDjCVSZPDEnl1AgN6vj7fmBEiOeYkLQRMDoNXxUVzXUtRcDH84haenP BW3x8XBL/VEYskyKNH/1WIRLgnpzju9cBQzvMXo+QSkhKIL7RXeiCcZBD0MIMtGOow9s ZoS0r+deLq6pBImv3UapjJbiwaETYxszyWP2DGE/8RPW/2J2tdBQO/g/IGiPULTuRfk4 KudGdGc55rP/+YUcshgWNA8dihwSvBv66/fDSfYS5cMZ91iVmm1s3TfSyylEIx2+DM6w YoOtZuYXWM61qjoK+Jx7PSsA6at0i/felh0SO3+eSZia8YCpOpMbmEZEDlXXxl9TFise tg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vx2h68wds-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jan 2024 02:40:03 +0000 Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 40T1on7e024417; Mon, 29 Jan 2024 02:40:02 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vx2h68wdd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jan 2024 02:40:02 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 40T0m7tH010501; Mon, 29 Jan 2024 02:40:02 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3vwd5ndp82-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jan 2024 02:40:01 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 40T2dxPf20185606 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Jan 2024 02:39:59 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CA4DA20043; Mon, 29 Jan 2024 02:39:59 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2754420040; Mon, 29 Jan 2024 02:39:57 +0000 (GMT) Received: from [9.197.248.232] (unknown [9.197.248.232]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 29 Jan 2024 02:39:56 +0000 (GMT) Message-ID: Date: Mon, 29 Jan 2024 10:39:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] testsuite: Fix vect_long_mult on Power [PR109705] Content-Language: en-US To: Andrew Pinski , "Andrew Pinski (QUIC)" Cc: GCC Patches , Segher Boessenkool , David Edelsohn , Peter Bergner , Richard Biener References: <53887523-ea6c-3a7e-6bb6-59268b9d3a4f@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: TT0vVac_iUtEi15h2HBzqdF0-0bQoKy4 X-Proofpoint-ORIG-GUID: 3ydj94Z0TTd9PCPxbOTef6mjZPOxbaOE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-25_14,2024-01-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 mlxscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401290018 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: on 2024/1/27 06:42, Andrew Pinski wrote: > On Mon, Jan 15, 2024 at 6:43 PM Kewen.Lin wrote: >> >> Hi, >> >> As pointed out by the discussion in PR109705, the current >> vect_long_mult effective target check on Power is broken. >> This patch is to fix it accordingly. >> >> With additional change by adding a guard vect_long_mult >> in gcc.dg/vect/pr25413a.c , it's tested well on Power{8,9} >> LE & BE (also on Power10 LE as before). > > I see this is still broken for 32bit PowerPC where vect_long_mult > should return true still since long there is 32bit and there is a > 32bit vector multiply. > Can someone test (and apply if approved) the attached patch to see if > it fixes pr25413a.c for powerpc*-*-* for 32bit? Thanks for fixing, it works perfectly as tested. I just pushed it as r14-8485 (also updating with a tab and commit log). BR, Kewen > > Thanks, > Andrew Pinski > >> >> I'm going to push this soon. >> >> BR, >> Kewen >> ----- >> PR testsuite/109705 >> >> gcc/testsuite/ChangeLog: >> >> * lib/target-supports.exp (check_effective_target_vect_long_mult): >> Fix powerpc*-*-* checks. >> --- >> gcc/testsuite/lib/target-supports.exp | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp >> index 81ae92a0266..fac32fb3d0e 100644 >> --- a/gcc/testsuite/lib/target-supports.exp >> +++ b/gcc/testsuite/lib/target-supports.exp >> @@ -9073,9 +9073,9 @@ proc check_effective_target_vect_int_mult { } { >> >> proc check_effective_target_vect_long_mult { } { >> if { [istarget i?86-*-*] || [istarget x86_64-*-*] >> - || (([istarget powerpc*-*-*] >> - && ![istarget powerpc-*-linux*paired*]) >> - && [check_effective_target_ilp32]) >> + || ([istarget powerpc*-*-*] >> + && [check_effective_target_powerpc_vsx_ok] >> + && [check_effective_target_has_arch_pwr10]) >> || [is-effective-target arm_neon] >> || ([istarget sparc*-*-*] && [check_effective_target_ilp32]) >> || [istarget aarch64*-*-*] >> -- >> 2.39.1