From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5C62D3858D20 for ; Wed, 5 Apr 2023 20:10:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C62D3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680725429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=QUAo4uWwZdYZfK2b2g3wpl/SAyuVZ+bh3gPxG6zRZPA=; b=irYdIxIrRdO8aZBlaeJUtvTLS937QDJzczgwg890LvW2XfnfhrZB8T98rmYUa9dMnOainp Yyg5+x4rdPkbqt3zgxCIYVwPCaKooeoRzkR/nif0Z7UIkfTnw/06MbY8e3BXaUqg8l3Ds0 SYHeFewQ/bSsL0nYTAaYQPkM232Pank= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-GDMefdjYO8iW4O5bc5A9Kg-1; Wed, 05 Apr 2023 16:10:27 -0400 X-MC-Unique: GDMefdjYO8iW4O5bc5A9Kg-1 Received: by mail-qv1-f71.google.com with SMTP id e1-20020a0cd641000000b005b47df84f6eso16967778qvj.0 for ; Wed, 05 Apr 2023 13:10:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680725427; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dHDvJPpoJkI/FsRnAcQ5srOHjV5iIe/aJ8pP8Y02Ics=; b=hjCcepoIrZ/fsUt4mHNcOD52iTPnHoRy8ESft/Q3P2J2QL+zd8I5kNIs/iQMk9b390 7Rq49qt1SqY06fEAus2KCXKttlgzMbhMq9IX0Fgu2LCN4RFItgy0vgBfneh5WIU6CFWo xA8w42m6NP+OXiCkP/S0qafkIzsHFB6gcoDRLqtV1AWrDlsH/w+xODJej7diCNhBLHaX F4Ead1PwWynooxar9qQ5bIVbkvFMNqQTjgO6Kb9LrloQFyFNb//K5B10XRHl5czxPYqa Esrdyz5LsgEpB5t0FG9xcDMBbgXlPmBBTo0QgcEwhzHS7rjSQzqQFpltxURo5/dPLJ3p HchQ== X-Gm-Message-State: AAQBX9fLWaP2Omo5v+rqKZ0zEoncRtzw1BZJPvkkLAYRroVtm995acRm CA7mQhw9c2hdiguyXnuSgQjPod5ijjkGVzZfQ3ePcdS3EiGOC0Eqsq81GU4F/yCqp3g4G9YL3t4 H24qb5Ep7h4jAN3sbngqte+rBNucc4YLCsu2RoKAko/Jq0EpiE03RTTzZOATc0JuTEmjFZ9Gfit zW6A== X-Received: by 2002:a05:622a:507:b0:3e6:6502:16aa with SMTP id l7-20020a05622a050700b003e6650216aamr6625744qtx.36.1680725426837; Wed, 05 Apr 2023 13:10:26 -0700 (PDT) X-Google-Smtp-Source: AKy350a9dt2yUHxjVLlrByvKhlYQQAUCR69z24R1kSkfTNBx9whFLfsJSWVpdBsEC36BGaEirQS9jg== X-Received: by 2002:a05:622a:507:b0:3e6:6502:16aa with SMTP id l7-20020a05622a050700b003e6650216aamr6625697qtx.36.1680725426481; Wed, 05 Apr 2023 13:10:26 -0700 (PDT) Received: from ?IPV6:2607:fea8:51dd:1100::345b? ([2607:fea8:51dd:1100::345b]) by smtp.gmail.com with ESMTPSA id y20-20020ac87094000000b003e4e9aba4b3sm4232209qto.73.2023.04.05.13.10.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Apr 2023 13:10:25 -0700 (PDT) Message-ID: Date: Wed, 5 Apr 2023 16:10:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: gcc-patches From: Andrew MacLeod Subject: [PATCH] PR tree-optimization/109417 - Check if dependency is valid before using in may_recompute_p. X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------hn0gTXvbr9PsbjpGBMfPebe3" Content-Language: en-US X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------hn0gTXvbr9PsbjpGBMfPebe3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit When a statement is first processed, any SSA_NAMEs that are dependencies are cached for quick future access. if we ;later rewrite the statement (say propagate a constant into it), its possible the ssa-name in this cache is no longer active.   Normally this is not a problem, but the changed to may_recompute_p forgot to take that into account, and was checking a dependency from the cache that was in the SSA_NAME_FREE_LIST. It thus had no SSA_NAME_DEF_STMT when we were expecting one. This patch simply rejects dependencies from consideration if they are in the free list. Bootstrapping on x86_64-pc-linux-gnu  and presuming no regressio0ns, OK for trunk? Andrew --------------hn0gTXvbr9PsbjpGBMfPebe3 Content-Type: text/x-patch; charset=UTF-8; name="417.diff" Content-Disposition: attachment; filename="417.diff" Content-Transfer-Encoding: base64 Y29tbWl0IGVjZDg2ZTE1OWU4NDk5ZmViMzg3YmM0ZDk5YmQzN2E1ZmQ2YTBkNjgKQXV0aG9yOiBB bmRyZXcgTWFjTGVvZCA8YW1hY2xlb2RAcmVkaGF0LmNvbT4KRGF0ZTogICBXZWQgQXByIDUgMTU6 NTk6MzggMjAyMyAtMDQwMAoKICAgIENoZWNrIGlmIGRlcGVuZGVuY3kgaXMgdmFsaWQgYmVmb3Jl IHVzaW5nIGluIG1heV9yZWNvbXB1dGVfcC4KICAgIAogICAgV2hlbiB0aGUgSUwgaXMgcmV3cml0 dGVuIGFmdGVyIGEgc3RhdGVtZW50IGhhcyBiZWVuIHByb2Nlc3NlZCBhbmQKICAgIGRlcGVuZGVu Y2llcyBjYWNoZWQsIGl0cyBwb3NzaWJsZSB0aGF0IGFuIHNzYS1uYW1lIGluIHRoZSBkZXBlbmRl bmN5CiAgICBjYWNoZSBpcyBubyBsb25nZXIgaW4gdGhlIElMLiAgQ2hlY2sgdGhpcyBiZWZvcmUg dHJ5aW5nIHRvIHJlY29tcHV0ZS4KICAgIAogICAgICAgICAgICBQUiB0cmVlLW9wdGltaXphdGlv bi8xMDk0MTcKICAgICAgICAgICAgZ2NjLwogICAgICAgICAgICAqIGdpbXBsZS1yYW5nZS1nb3Jp LmNjIChnb3JpX2NvbXB1dGU6Om1heV9yZWNvbXB1dGVfcCk6IENoZWNrIGlmCiAgICAgICAgICAg IGRlcGVuZGVuY3kgaXMgaW4gU1NBX05BTUVfRlJFRV9MSVNULgogICAgCiAgICAgICAgICAgIGdj Yy90ZXN0c3VpdGUvCiAgICAgICAgICAgICogZ2NjLmRnL3ByMTA5NDE3LmM6IE5ldy4KCmRpZmYg LS1naXQgYS9nY2MvZ2ltcGxlLXJhbmdlLWdvcmkuY2MgYi9nY2MvZ2ltcGxlLXJhbmdlLWdvcmku Y2MKaW5kZXggNWY0MzEzYjI3ZGQuLjZlMmY5NTMzMDM4IDEwMDY0NAotLS0gYS9nY2MvZ2ltcGxl LXJhbmdlLWdvcmkuY2MKKysrIGIvZ2NjL2dpbXBsZS1yYW5nZS1nb3JpLmNjCkBAIC0xMzE0LDcg KzEzMTQsOSBAQCBnb3JpX2NvbXB1dGU6Om1heV9yZWNvbXB1dGVfcCAodHJlZSBuYW1lLCBiYXNp Y19ibG9jayBiYiwgaW50IGRlcHRoKQogICB0cmVlIGRlcDIgPSBkZXBlbmQyIChuYW1lKTsKIAog ICAvLyBJZiB0aGUgZmlyc3QgZGVwZW5kZW5jeSBpcyBub3Qgc2V0LCB0aGVyZSBpcyBubyByZWNv bXB1dGF0aW9uLgotICBpZiAoIWRlcDEpCisgIC8vIERlcGVuZGVuY2llcyByZWZsZWN0IG9yaWdp bmFsIElMLCBub3QgY3VycmVudCBzdGF0ZS4gICBDaGVjayBpZiB0aGUKKyAgLy8gU1NBX05BTUUg aXMgc3RpbGwgdmFsaWQgYXMgd2VsbC4KKyAgaWYgKCFkZXAxIHx8IFNTQV9OQU1FX0lOX0ZSRUVf TElTVCAoZGVwMSkpCiAgICAgcmV0dXJuIGZhbHNlOwogCiAgIC8vIERvbid0IHJlY2FsY3VsYXRl IFBISXMgb3Igc3RhdGVtZW50cyB3aXRoIHNpZGVfZWZmZWN0cy4KZGlmZiAtLWdpdCBhL2djYy90 ZXN0c3VpdGUvZ2NjLmRnL3ByMTA5NDE3LmMgYi9nY2MvdGVzdHN1aXRlL2djYy5kZy9wcjEwOTQx Ny5jCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi4xNTcxMWRiYmFmZQot LS0gL2Rldi9udWxsCisrKyBiL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3ByMTA5NDE3LmMKQEAgLTAs MCArMSwyNCBAQAorLyogeyBkZy1kbyBjb21waWxlIH0gKi8KKy8qIHsgZGctb3B0aW9ucyAiLU8z IiB9ICovCisKK2ludCBwcmludGYoY29uc3QgY2hhciAqLCAuLi4pOworaW50IGMsIGQsICplLCBm WzFdWzJdLCBnOworaW50IG1haW4oKSB7CisgIGludCBoID0gMCwgKmEgPSAmaCwgKipiWzFdID0g eyZhfTsKKyAgd2hpbGUgKGUpCisgICAgd2hpbGUgKGcpIHsKKyAgICBMOgorICAgICAgZm9yICho ID0gMDsgaCA8IDI7IGgrKykgeworICAgICAgICB3aGlsZSAoZCkKKyAgICAgICAgICBmb3IgKCpl ID0gMDsgKmUgPCAxOykKKyAgICAgICAgICAgIHByaW50ZigiMCIpOworICAgICAgICB3aGlsZSAo YykKKyAgICAgICAgICA7CisgICAgICAgIGZbZ11baF0gPSAwOworICAgICAgfQorICAgIH0KKyAg aWYgKGgpCisgICAgZ290byBMOworICByZXR1cm4gMDsKK30KKwo= --------------hn0gTXvbr9PsbjpGBMfPebe3--