From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id C61A43858C27 for ; Wed, 13 Oct 2021 10:02:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C61A43858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8E23922304; Wed, 13 Oct 2021 10:02:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1634119342; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x2UnYqe93y39iAtB+qpuPuIJlU02dGDbyFbUjy0e2cc=; b=F4s+l3KZ/7CrSaOMaHnpticunpJIF62U4uN1Tod3rCnBZgrrWKBTWTH9RYmBK0feZDw4WD mdfvla9SM1mIkG1qzeZVNVsaAbvTOnOGPvGGLCdbQ8i/j2jgqUnKHlPC6xrLsBvCUsQMjp Wv2h/4diaiK3JG6Q5bQyQo/gJvGkzdw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1634119342; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x2UnYqe93y39iAtB+qpuPuIJlU02dGDbyFbUjy0e2cc=; b=7x0rCbZaOW9J/FZsZIAXA4xrcqTgHY3himqPOuDgT3VN+dc1VSveXbNxBPOkgJfmc4pFME mlRfm3uf332PCuBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 71A5613CEC; Wed, 13 Oct 2021 10:02:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UtuxGq6uZmESPwAAMHmgww (envelope-from ); Wed, 13 Oct 2021 10:02:22 +0000 Message-ID: Date: Wed, 13 Oct 2021 12:02:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH] Fix handling of flag_rename_registers. Content-Language: en-US To: Richard Biener Cc: "Joseph S. Myers" , GCC Patches References: <12fd0c18-79e0-d20d-2973-92639071c050@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2021 10:02:25 -0000 On 10/13/21 10:39, Richard Biener wrote: > On Tue, Oct 12, 2021 at 5:11 PM Martin Liška wrote: >> >> On 10/12/21 15:37, Richard Biener wrote: >>> by adding EnabledBy(funroll-loops) to the respective options instead >>> (and funroll-loops EnabledBy(funroll-all-loops)) >> >> All right, so the suggested approach works correctly. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? > > funroll-all-loops > -Common Var(flag_unroll_all_loops) Optimization > +Common Var(flag_unroll_all_loops) Optimization EnabledBy(funroll-all-loops) > > that should be on funroll-loops? Yeah, what a stupid error. > > Can you verify that the two-step -funroll-all-loops -> -funroll-loops > -> -frename-registers Yes, verified that in debugger, it's not dependent on an ordering. > works and that it is not somehow dependent on ordering? Otherwise we have to > use EnabledBy(funroll-loops,funroll-all-loops) on frename-registers. > I guess the > EnabledBy doesn't work if the target decides to set flag_unroll_loop in one of > its hooks rather than via its option table override? (as said, this > is all a mess...) It's a complete mess. The only override happens in rs6000_override_options_after_change. I think it can also utilize EnabledBy, but I would like to do it in a different patch. > > But grep should be your friend telling whether any target overrides > any of the flags... > > I do hope we can eventually reduce the number of pre-/post-/lang/target/common > processing phases for options :/ Meh. Huh. May I install this fixed patch once it's tested? Martin > > Richard. > >> Thanks, >> Martin