From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from toucan.tulip.relay.mailchannels.net (toucan.tulip.relay.mailchannels.net [23.83.218.254]) by sourceware.org (Postfix) with ESMTPS id 6341E3858D33 for ; Wed, 25 Jan 2023 11:23:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6341E3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id AA4649213B7; Wed, 25 Jan 2023 11:22:59 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 3A31B9209B3; Wed, 25 Jan 2023 11:22:59 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1674645779; a=rsa-sha256; cv=none; b=VR2HvPszCX49ltwoVRchIYr9lLWFT+UIRzu0aa1A0PlaGL02A4CeELby00Ca6aq5YBJtYR 5MvulaT1dCCFFhukUU87nYY4+B+g1n6NcU6scAN/KlnGHgjgpaMW40bGvwKwL9grwTYJb5 ZlFjdxl8qFv8iA9BtAu3c/ASPHP3A0Vt19VmjabgNVyQso/7D3fhwRt8sxuZjTkTMQfNXt 7B1lQqIZUDoFQD/L4w+UANvaZP/gGtYONgeXMq7D1PwxaX+WCUcwCCyAoT1flBzBKE2JgG NwG3yhx1KOH8eDcdaRWRdp4h/Lg59C5B172qBbXC3AJFRQQjob5hLtNhe/glaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1674645779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6IA1Pm0apKqZjU1TYyYuC1KQgXoFr8WncLpkD+qqzmw=; b=k49m0qaWaCPEUGvVr35fs65kgyHxc0BHJ+OUxdryqgVHAJqZnDyhUumbJEn2k2j5Hz2Rev 6+K8w+oRv9vsSynpL1Z/49e44aVDgYs51AhA5cOF5zej0vhqJUpnLycwlo1MEdSqg5p1JJ rG76LOQ26LKtzY3KnjQIPU+qRhxztbOPkQ5uJM8d/maEONEaZZ6U9jixqsNjoI8vyUbTRa joEdTl44Kzuk/maBk85qwEPOHLEa3U+JznVLnYk3+Nx96UmVQqPnkB21hqVTyxx5lWKIxQ l8ClR3Cz1ryhWnamrnj2eG+YzX2kGPFxg0iX/siK2jl57ywOeRjCJ+G4lulsqQ== ARC-Authentication-Results: i=1; rspamd-55978756d7-bfj9r; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Chief-Glossy: 3c8f6a1465d8aab0_1674645779481_786373408 X-MC-Loop-Signature: 1674645779481:3595618395 X-MC-Ingress-Time: 1674645779480 Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.116.179.120 (trex/6.7.1); Wed, 25 Jan 2023 11:22:59 +0000 Received: from [192.168.0.182] (bras-base-toroon4834w-grc-23-76-68-24-147.dsl.bell.ca [76.68.24.147]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4P21fV2bNTzK2; Wed, 25 Jan 2023 03:22:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1674645778; bh=6IA1Pm0apKqZjU1TYyYuC1KQgXoFr8WncLpkD+qqzmw=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=BDtigBlSsrJ8koeJxrFAOmgK2lq/HTpIVZUdKdovbOJH0duaMJD/BVMBy+PnG1MpF COSd2AUiMgGj70epByYBUZXx88I7aRlOk89pRh6nZxMyqSzqQ9/H1KRytcld+u6kNz B1wngxcIgEVHdOWrNTOx8c3MdaU8yckUYxjoNLwV18LalubSm3QEO3RiGjejpNKfSw +0ht8nEbOKvgHCndIwjAHwmTr/GQhP9BIxRleZ9ha4NGV3cIoTnhZ+f5LjjyRSYf4U a3m6sy1Ht+MZ44qis/P/XnjhpLCrF073l1hca+Yp0dwAqjThyUe/T3RkjjUivL+IsQ eYrf32HFJ3rrg== Message-ID: Date: Wed, 25 Jan 2023 06:22:56 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] tree-optimization/108522 Use COMPONENT_REF offset when available Content-Language: en-US To: Richard Biener Cc: gcc-patches@gcc.gnu.org, jakub@redhat.com References: <20230124215400.1345220-1-siddhesh@gotplt.org> From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3031.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-01-25 02:44, Richard Biener wrote: >> t = TREE_OPERAND (expr, 1); >> - off = size_binop (PLUS_EXPR, DECL_FIELD_OFFSET (t), >> + off = size_binop (PLUS_EXPR, >> + (TREE_OPERAND (expr, 2) ? TREE_OPERAND (expr, 2) >> + : DECL_FIELD_OFFSET (t)), > > That isn't correct - operand 2 is the field offset in units of > DECL_OFFSET_ALIGN (t) / BITS_PER_UNIT. > See component_ref_filed_offset (), maybe you should be using that > function instead? Ahh, and it passed my testing only because I was testing a char. Thanks, I'll test and send an update with additional tests. Thanks, Sid