From: Jeff Law <jeffreyalaw@gmail.com>
To: "Christoph Müllner" <christoph.muellner@vrull.eu>,
"Liao Shihua" <shihua@iscas.ac.cn>
Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com,
shiyulong@iscas.ac.cn, jiawei@iscas.ac.cn,
chenyixuan@iscas.an.cn
Subject: Re: [PATCH V2 0/2] RISC-V: Add intrinsics for Bitmanip and Scalar Crypto extensions
Date: Thu, 7 Dec 2023 14:01:15 -0700 [thread overview]
Message-ID: <a2040a5c-f917-413b-88a6-93712cc694f1@gmail.com> (raw)
In-Reply-To: <CAEg0e7giXc2JWkVQ9RTM6WQG-_4uT-MGek4cO4XKJ_=kS6S1xA@mail.gmail.com>
On 12/7/23 09:59, Christoph Müllner wrote:
> On Thu, Dec 7, 2023 at 11:18 AM Liao Shihua <shihua@iscas.ac.cn> wrote:
>>
>> In accordance with the suggestions of Christoph Müllner, the following amendments are made
>>
>> Update v1 -> v2:
>> 1. Rename *_intrinsic-* to *_intrinsic-XLEN.
>> 2. Typo fix.
>> 3. Intrinsics with immediate arguments will use marcos at O0 .
>>
>> It's a little patch add just provides a mapping from the RV intrinsics to the builtin
>> names within GCC.
>
> Thanks for the update!
>
> I think this patchset was not properly tested as I see the tests failing.
Thanks for pointing this out.
I think we're well past the point where if a patchkit doesn't specify
how it was tested that it should be rejected. This is standard
procedure for the rest of the compiler and there's no good reason why we
should have a lax policy in the RISC-V target files.
Jeff
prev parent reply other threads:[~2023-12-07 21:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 10:16 Liao Shihua
2023-12-07 10:16 ` [PATCH V2 1/2] RISC-V: Add C intrinsics of Scalar Crypto Extension Liao Shihua
2023-12-07 10:16 ` [PATCH V2 2/2]RISC-V: Add C intrinsics of Bitmanip Extension Liao Shihua
2023-12-07 16:59 ` [PATCH V2 0/2] RISC-V: Add intrinsics for Bitmanip and Scalar Crypto extensions Christoph Müllner
2023-12-07 21:01 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2040a5c-f917-413b-88a6-93712cc694f1@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=chenyixuan@iscas.an.cn \
--cc=christoph.muellner@vrull.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jiawei@iscas.ac.cn \
--cc=kito.cheng@gmail.com \
--cc=shihua@iscas.ac.cn \
--cc=shiyulong@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).