From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.codeweavers.com (mail.codeweavers.com [4.36.192.163]) by sourceware.org (Postfix) with ESMTPS id 88A4E3858D3C for ; Tue, 7 Mar 2023 14:18:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 88A4E3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=codeweavers.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=codeweavers.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codeweavers.com; s=6377696661; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=c2xuTx3+ge7N40B2Bzwl6c7llsdHnS79dq613VS6Atg=; b=rNKwEa31kbTm8eg2qMZ5YdzbYG 6D8v9J/W827VqPSbc/MG8JneV+JYr4pAoT0N/JbJaFbptHaY0HR/fvfQPvEZMMTDqCLjUSXYCPzcO nwX+1+q6d8u0BVU9yWt3ORlGBiRQZ1CRLNt5HBPkoG9XC5bsPmVVlE9AB0UX+YXhw8sg=; Received: from cw141ip133.vpn.codeweavers.com ([10.69.141.133]) by mail.codeweavers.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pZY8s-00E9ma-0W; Tue, 07 Mar 2023 08:18:14 -0600 Message-ID: Date: Tue, 7 Mar 2023 15:17:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865] Content-Language: en-GB To: Costas Argyris Cc: gcc-patches@gcc.gnu.org References: <508051a3-0314-bb4a-1ce8-5772b1b8f5a6@codeweavers.com> From: Jacek Caban In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Costas, On 3/7/23 15:00, Costas Argyris wrote: > Hi Jacek, > > "Is there a reason to make it specific to x86_64? It seems to me that > all mingw hosts could use it." > > Are you referring to the 32-bit host?    My concern here is that this > functionality (embedding the UTF-8 > manifest file into the executable) is only truly supported in recent > versions of Windows.    From: > > https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page > > It says that Windows Version 1903 (May 2019 Update) enables this, so > we are looking at the 64-bit > version of Windows. > > I suppose you are referring to the scenario where one has a 32-bit > gcc + mingw running in a 64-bit > Windows that is recent enough to support this?    It is not clear to > me based on the above doc what > would happen encoding-wise in that situation, and I haven't tried it > either because I assumed that > most people would want the 64-bit version of gcc since they are > probably running a 64-bit OS. > > If you think it is useful, I could look into that as a separate task > to try and keep this one simple, if > that makes sense. Yes, realistically it's mostly about 32-bit gcc on 64-bit Windows (perhaps aarch64 as well at some point in the future). It's probably indeed not very popular configuration those days, but I think it should work just fine if you didn't explicitly limit the patch to x86_64. > "I think that .manifest file should also be a dependency here." > > Why is that?    Windres takes only the .rc file as its input, as per > its own doc, and it successfully > compiles it into an object file.    The .manifest file is only > referenced by the .rc file, and it doesn't > get passed to windres, so I don't see why it has to be listed as a > prerequisite in the make rule. The point that when winnt-utf8.manifest is modified, utf8-mingw32.o should be rebuilt. Anyway, it's probably not a big deal (I should disclaim that I'm not very familiar with gcc build system; I'm mostly on this ML due to mingw-w64 contributions). Thanks, Jacek