From: Robin Dapp <rdapp@linux.ibm.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] c-family: Copy DECL_USER_ALIGN even if DECL_ALIGN is similar.
Date: Mon, 17 May 2021 16:03:47 +0200 [thread overview]
Message-ID: <a29162f7-acf1-7c48-c6e7-d56aa6d66079@linux.ibm.com> (raw)
In-Reply-To: <dbec56ab-a57a-d84f-1286-2f46d049bcae@linux.ibm.com>
> on s390 a warning test fails:
>
> inline int ATTR ((cold, aligned (8)))
> finline_hot_noret_align (int);
>
> inline int ATTR ((warn_unused_result))
> finline_hot_noret_align (int);
>
> inline int ATTR ((aligned (4)))
> finline_hot_noret_align (int); /* { dg-warning "ignoring attribute
> .aligned \\(4\\). because it conflicts with attribute .aligned \\(8\\)."
>
> This test actually uncovered two problems. First, on s390 the default
> function alignment is 8 bytes. When the second decl above is merged
> with the first one, DECL_USER_ALIGN is only copied if DECL_ALIGN (old) >
> DECL_ALIGN (new). Subsequently, when merging the third decl, no warning
> is emitted since DECL_USER_ALIGN is unset.
[..]
Ping.
next prev parent reply other threads:[~2021-05-17 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 14:53 Robin Dapp
2021-05-10 6:32 ` Robin Dapp
2021-05-17 14:03 ` Robin Dapp [this message]
2021-05-19 22:03 ` Martin Sebor
2021-05-21 19:13 ` Jason Merrill
2021-05-25 10:38 ` Robin Dapp
2021-05-25 15:15 ` Martin Sebor
2021-05-25 15:56 ` Jason Merrill
2021-06-01 13:20 ` Robin Dapp
2021-06-01 19:11 ` Jason Merrill
2021-06-09 8:47 ` Robin Dapp
2021-06-09 21:24 ` Jason Merrill
2021-06-01 13:24 ` Robin Dapp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a29162f7-acf1-7c48-c6e7-d56aa6d66079@linux.ibm.com \
--to=rdapp@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).