From: Jeff Law <law@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>, Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Adjust -Wsequence-point for C++17 changes (PR c++/91415)
Date: Mon, 12 Aug 2019 20:15:00 -0000 [thread overview]
Message-ID: <a29c72dc-4115-c3a7-1db0-fb0f8434caac@redhat.com> (raw)
In-Reply-To: <20190812144831.GP2726@tucnak>
On 8/12/19 8:48 AM, Jakub Jelinek wrote:
> Hi!
>
> The following patch adds some tweaks for -Wsequence-point warning for C++17
> and later. In particular, stop warning about no sequence point in between
> <<, >>, ., -> and [] expressions, where E1 is in C++17 sequenced before E2.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> As mentioned in the PR, this is just part of the needed changes, I've tried
> to adjust handling of MODIFY_EXPR, but didn't figure out exactly what needs
> to be done, and .* / ->* aren't handled either, and CALL_EXPR needs probably
> some verification too.
>
> 2019-08-12 Jakub Jelinek <jakub@redhat.com>
>
> PR c++/91415
> * c-common.c (verify_tree): For LSHIFT_EXPR, RSHIFT_EXPR,
> COMPONENT_REF and ARRAY_REF in cxx_dialect >= cxx17 mode handle it
> like COMPOUND_EXPR rather than normal expression.
>
> * g++.dg/warn/sequence-pt-4.C: New test.
OK
jeff
prev parent reply other threads:[~2019-08-12 20:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 14:53 Jakub Jelinek
2019-08-12 20:15 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a29c72dc-4115-c3a7-1db0-fb0f8434caac@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).