From: Craig Blackmore <craig.blackmore@embecosm.com>
To: Jim Wilson <jimw@sifive.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Ofer Shinaar <Ofer.Shinaar@wdc.com>,
Nidal Faour <Nidal.Faour@wdc.com>
Subject: Re: [PATCH v2 1/2] RISC-V: Add shorten_memrefs pass
Date: Wed, 13 May 2020 18:51:57 +0100 [thread overview]
Message-ID: <a2ced542-d9ab-b49e-2a9d-4c6d3f2a9a3c@embecosm.com> (raw)
In-Reply-To: <CAFyWVab07rS6RdwEbZpk+e=eYB17wm4_9zwNOY9M_M6XWYynbw@mail.gmail.com>
On 12/05/2020 23:33, Jim Wilson wrote:
> On Mon, Apr 27, 2020 at 10:08 AM Craig Blackmore
> <craig.blackmore@embecosm.com> wrote:
>> Thanks for the review. I have updated the following patch with those changes.
> This looks good, and the tree is open for development work again, so I
> committed both parts 1 and 2 and pushed it.
>
> One weird thing is that while the patch program accepted the patch
> fine, git am would not, and kept giving me an error that didn't make
> any sense, pointing at a line that didn't have any visible problem.
> So I had to commit it by hand and then use git commit --amend to fix
> the authorship before pushing it. The end result looks OK to me
> though.
>
> Jim
Hi Jim,
Many thanks for your help in reviewing this patch.
I am not sure what happened with git am, thanks for working around it,
the end result looks good to me.
Craig
next prev parent reply other threads:[~2020-05-13 17:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 16:19 [PATCH] RISC-V: Allow more load/stores to be compressed Craig Blackmore
2019-09-18 10:01 ` Kito Cheng
2019-10-25 17:40 ` [PATCH v2 0/2] " Craig Blackmore
2019-10-25 17:40 ` [PATCH v2 1/2] RISC-V: Add shorten_memrefs pass Craig Blackmore
2019-10-26 18:25 ` Jeff Law
2019-10-26 19:16 ` Oleg Endo
2019-10-26 20:04 ` Jeff Law
2019-10-26 20:02 ` Andrew Waterman
2019-10-26 20:16 ` Jeff Law
2019-10-27 7:13 ` Oleg Endo
2019-10-31 0:00 ` Jim Wilson
2019-10-31 9:42 ` Nidal Faour
2019-10-31 10:42 ` Andrew Waterman
2019-10-31 15:57 ` Ofer Shinaar
2019-12-10 18:28 ` Craig Blackmore
2020-02-19 11:40 ` Craig Blackmore
2020-04-08 16:04 ` Jim Wilson
2020-04-27 17:08 ` Craig Blackmore
2020-05-12 22:33 ` Jim Wilson
2020-05-13 17:51 ` Craig Blackmore [this message]
2019-10-31 0:03 ` Jim Wilson
2019-10-25 17:57 ` [PATCH v2 2/2] sched-deps.c: Avoid replacing address if it increases address cost Craig Blackmore
2019-10-31 2:00 ` Jim Wilson
2019-12-10 18:29 ` Craig Blackmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2ced542-d9ab-b49e-2a9d-4c6d3f2a9a3c@embecosm.com \
--to=craig.blackmore@embecosm.com \
--cc=Nidal.Faour@wdc.com \
--cc=Ofer.Shinaar@wdc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jimw@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).