From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id B8AA73858D28 for ; Tue, 17 Jan 2023 02:48:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B8AA73858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30H1gKK2032179; Tue, 17 Jan 2023 02:48:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=C+5UV5d4h43gHH+re7uSIIL3v4Wrhhg2Xe6P6bOSE98=; b=Jko1Nhtww0jP9XwvFqf8OpGg7O0mrdtnph+Ht8haHSJ0VJdlNV7iJUfAi/UkzMFoEgGF RLxsgGpkq8hyJ19BvTfu7ESNRB+g2P6awFcgINIk6+Vg9tYnMN3dRkzvlWrxCwnfdF3j MJy6bYAVFAiVW5oj8SrCmayHmcr5SlsqK96ve1s6Xbkcg1rpcCFqQJ4Rx5YVNyavlRqt 8Zg7Jm5n9UjePJHysIH0cF0cmR2+p846nBHjmv/Py3pCajTBY76nh4pjN4fCyp8jG3mE t4omKYP+c7g/tMgm+Q1hEPbknaQrDDiF+uHY4t2s/I4ltIPJRH+idnY5areCygagNq3m aA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3n5egnd5r0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jan 2023 02:48:46 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 30H2k4bN018738; Tue, 17 Jan 2023 02:48:45 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3n5egnd5q4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jan 2023 02:48:45 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30GFqxHg005139; Tue, 17 Jan 2023 02:48:43 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3n3m16k69c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jan 2023 02:48:43 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30H2melI43778504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Jan 2023 02:48:40 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BFB8920049; Tue, 17 Jan 2023 02:48:40 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E4DE120040; Tue, 17 Jan 2023 02:48:38 +0000 (GMT) Received: from [9.197.226.105] (unknown [9.197.226.105]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 17 Jan 2023 02:48:38 +0000 (GMT) Message-ID: Date: Tue, 17 Jan 2023 10:48:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] rs6000: Teach rs6000_opaque_type_invalid_use_p about gcall [PR108348] Content-Language: en-US To: Segher Boessenkool Cc: GCC Patches , David Edelsohn , Peter Bergner References: <1ea87e1b-7caf-59dd-ff1a-8f282a2dae14@linux.ibm.com> <20230116084907.GE25951@gate.crashing.org> <20230116104051.GG25951@gate.crashing.org> <2422e203-d2bb-30a4-efac-55972c96e074@linux.ibm.com> <20230116152458.GH25951@gate.crashing.org> From: "Kewen.Lin" In-Reply-To: <20230116152458.GH25951@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 17aqc3XqjEvgBMxlx0YBIHtM3kWfllVG X-Proofpoint-ORIG-GUID: 1vn19mHFr95mz_YiFP0mrZcrA_veSIJG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-16_18,2023-01-13_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 bulkscore=0 clxscore=1015 suspectscore=0 mlxscore=0 spamscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301170017 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Segher, on 2023/1/16 23:24, Segher Boessenkool wrote: > On Mon, Jan 16, 2023 at 09:05:38PM +0800, Kewen.Lin wrote: >>> The *_ok things should only be used for features that can be disabled >>> during configuration, or features that we *want* users to be able to >>> turn off (like FP, VMX, VSX, or HMT or QP float, that kind of thing). >>> That gives quite enough permutations to test already, we do not need to >>> create a whole bunch extra for no reason :-) >> >> Thanks for the explanation!! I meant to use powerpc_p9modulo_ok to >> exclude those cases where we can't use -mcpu=power9, as you explained we >> should not worry about it!? > > But that selector says whether modulo insns are enabled. This is not > correct to use here. I know we have abused these things before, but it > needs to be untangled, not made worse :-) Makes sense, thanks for further clarifying! > >> Since the test point requires altivec support >> (which is implied when specifying -mcpu=power9, I didn't explicitly specify >> it before), I think I could use powerpc_altivec_ok to replace >> powerpc_p9modulo_ok here, does it sound good to you? > > VMX can be turned off even with -mcpu=power9. So yes, it does need > powerpc_altivec_ok. Does it need VSX even? I think we don't need to check VSX here. Checking VMX is for robustness and ensure it's consistent with the comment: /* Allow -maltivec -mabi=no-altivec without warning. Altivec vector modes only exist for GCC vector types if -maltivec. */ if (TARGET_32BIT && !TARGET_ALTIVEC_ABI && ALTIVEC_VECTOR_MODE (arg.mode)) { if (TARGET_DEBUG_ARG) fprintf (stderr, "function_arg_pass_by_reference: AltiVec\n"); return 1; } BR, Kewen