From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by sourceware.org (Postfix) with ESMTPS id 394203858281 for ; Wed, 8 Nov 2023 13:06:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 394203858281 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ispras.ru ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 394203858281 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699448816; cv=none; b=q/5jqP9D2KWPUG25tf8atQYQFglhAE+9/BskmKpKk5O1E+DYMj23IvZznrrr6wcqQ5Ez9f2/wAGP8re3vWmVSI0ltMUp6NT5AM49fmsiy5rcXU1AdLgftLbOsNdmWrB01KnokAAvck8ym7zYq8ZrUFjQUBUpu0bZltv9jwpdqho= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699448816; c=relaxed/simple; bh=en8QuweJKjq78+nRZPrOLGVggrfsUx/KijqNQ5MKfaU=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=RU/88UZwkvZxi318ZZuBTXVNaBHHLw3KQB0xrT/reZ1f2DvB4NUOpPZdUfefjEYPAn+X/Ocos5qdCQM9e07z3+uuEyyGnKeyUl/LhuM0q/QaAoP2RIS8kvSfBvTUvSD3rlvvwLJSGDkyxT+HZJDvN0MNz1FXDe2LFqmN7wJ9vK0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.10.3.121] (unknown [10.10.3.121]) by mail.ispras.ru (Postfix) with ESMTPS id 6299B40F1DD8; Wed, 8 Nov 2023 13:06:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 6299B40F1DD8 Date: Wed, 8 Nov 2023 16:06:53 +0300 (MSK) From: Alexander Monakov To: Richard Biener cc: Florian Weimer , Alexander Monakov via Gcc-patches Subject: Re: [PATCH 1/3] tree-ssa-sink: do not sink to in front of setjmp In-Reply-To: Message-ID: References: <87o7g48vli.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323328-1283281829-1699448813=:14884" X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1283281829-1699448813=:14884 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Wed, 8 Nov 2023, Richard Biener wrote: > >> --- /dev/null > >> +++ b/gcc/testsuite/gcc.dg/setjmp-7.c > >> @@ -0,0 +1,13 @@ > >> +/* { dg-do compile } */ > >> +/* { dg-options "-O2 -fno-guess-branch-probability -w" } */ > >> +/* { dg-require-effective-target indirect_jumps } */ > >> + > >> +struct __jmp_buf_tag { }; > >> +typedef struct __jmp_buf_tag jmp_buf[1]; > >> +struct globals { jmp_buf listingbuf; }; > >> +extern struct globals *const ptr_to_globals; > >> +void foo() > >> +{ > >> + if ( _setjmp ( ((*ptr_to_globals).listingbuf ))) > >> + ; > >> +} > > > > Is the implicit declaration of _setjmp important to this test? > > Could we declare it explicitly instead? > > It shouldn’t be important. Yes, it's an artifact from testcase minimization, sorry about that. Florian, I see you've sent a patch to fix this up — thank you! Alexander --8323328-1283281829-1699448813=:14884--