public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: sellcey@cavium.com, gcc-patches <gcc-patches@gcc.gnu.org>,
	"richard.earnshaw" <richard.earnshaw@arm.com>
Subject: Re: [Patch] Document __builtin_extend_pointer
Date: Thu, 22 Feb 2018 05:04:00 -0000	[thread overview]
Message-ID: <a30ed595-46c0-4026-46a6-60cadb43775b@redhat.com> (raw)
In-Reply-To: <1519147981.6296.18.camel@cavium.com>

On 02/20/2018 10:33 AM, Steve Ellcey wrote:
> While working on PR 83335 I proposed a change to a test case that
> used __builtin_extend_pointer and Richared Earnshaw pointed out
> that this builtin is not documented.  Since I could not find any
> other (reasonable) way to generate an extended address in inline
> assembly other than this builtin I would like to document it for
> use.
> 
> Here is a proposed patch, the one problem I found was the return
> type of the builtin.  I don't know how to describe it other than
> Pmode, but that is not a user visible type.
> 
> See https://gcc.gnu.org/ml/gcc-patches/2018-02/msg01051.html
> for my PR 83335 patch and follow up comments.
> 
> Should I go ahead and add this documentation?
> 
> 
> 2018-02-20  Steve Ellcey  <sellcey@cavium.com>
> 
> 	* doc/extend.texi (__builtin_extend_pointer): Document builtin.
I'd change "is different than" to "is smaller than".  It's kind of
implied in the name, but I think it's slightly clearer.

With that.  OK.

jeff

ps.  You might ping Richard Sandiford on the actual patch that fixes
83335.  It looks like it's been waiting for over a month.

  reply	other threads:[~2018-02-22  5:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20 17:33 Steve Ellcey
2018-02-22  5:04 ` Jeff Law [this message]
2018-03-20 12:13 ` Tom de Vries
2018-03-20 21:00   ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a30ed595-46c0-4026-46a6-60cadb43775b@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.earnshaw@arm.com \
    --cc=sellcey@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).