From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66367 invoked by alias); 22 Feb 2018 05:04:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 66353 invoked by uid 89); 22 Feb 2018 05:04:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=month, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Feb 2018 05:04:25 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C513A8123D; Thu, 22 Feb 2018 05:04:23 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-67.rdu2.redhat.com [10.10.112.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id D8DB4608F9; Thu, 22 Feb 2018 05:04:22 +0000 (UTC) Subject: Re: [Patch] Document __builtin_extend_pointer To: sellcey@cavium.com, gcc-patches , "richard.earnshaw" References: <1519147981.6296.18.camel@cavium.com> From: Jeff Law Message-ID: Date: Thu, 22 Feb 2018 05:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519147981.6296.18.camel@cavium.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg01257.txt.bz2 On 02/20/2018 10:33 AM, Steve Ellcey wrote: > While working on PR 83335 I proposed a change to a test case that > used __builtin_extend_pointer and Richared Earnshaw pointed out > that this builtin is not documented.  Since I could not find any > other (reasonable) way to generate an extended address in inline > assembly other than this builtin I would like to document it for > use. > > Here is a proposed patch, the one problem I found was the return > type of the builtin.  I don't know how to describe it other than > Pmode, but that is not a user visible type. > > See https://gcc.gnu.org/ml/gcc-patches/2018-02/msg01051.html > for my PR 83335 patch and follow up comments. > > Should I go ahead and add this documentation? > > > 2018-02-20  Steve Ellcey   > > * doc/extend.texi (__builtin_extend_pointer): Document builtin. I'd change "is different than" to "is smaller than". It's kind of implied in the name, but I think it's slightly clearer. With that. OK. jeff ps. You might ping Richard Sandiford on the actual patch that fixes 83335. It looks like it's been waiting for over a month.