* Re: [PATCH] tree-optimization/106081 - elide redundant permute
[not found] <20230726132804.E4E863854826@sourceware.org>
@ 2023-07-26 16:18 ` Jeff Law
2023-07-27 7:52 ` Richard Biener
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2023-07-26 16:18 UTC (permalink / raw)
To: Richard Biener, gcc-patches
On 7/26/23 07:27, Richard Biener via Gcc-patches wrote:
> The following patch makes sure to elide a redundant permute that
> can be merged with existing splats represented as load permutations
> as we now do for non-grouped SLP loads. This is the last bit
> missing to fix this PR where the main fix was already done by
> r14-2117-gdd86a5a69cbda4
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
>
> PR tree-optimization/106081
> * tree-vect-slp.cc (vect_optimize_slp_pass::start_choosing_layouts):
> Assign layout -1 to splats.
>
> * gcc.dg/vect/pr106081.c: New testcase.
:-) Glad to see how easy this ended up being after the work you put
into pushing permutes around a couple years ago.
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tree-optimization/106081 - elide redundant permute
2023-07-26 16:18 ` [PATCH] tree-optimization/106081 - elide redundant permute Jeff Law
@ 2023-07-27 7:52 ` Richard Biener
0 siblings, 0 replies; 3+ messages in thread
From: Richard Biener @ 2023-07-27 7:52 UTC (permalink / raw)
To: Jeff Law; +Cc: gcc-patches
On Wed, 26 Jul 2023, Jeff Law wrote:
>
>
> On 7/26/23 07:27, Richard Biener via Gcc-patches wrote:
> > The following patch makes sure to elide a redundant permute that
> > can be merged with existing splats represented as load permutations
> > as we now do for non-grouped SLP loads. This is the last bit
> > missing to fix this PR where the main fix was already done by
> > r14-2117-gdd86a5a69cbda4
> >
> > Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
> >
> > PR tree-optimization/106081
> > * tree-vect-slp.cc (vect_optimize_slp_pass::start_choosing_layouts):
> > Assign layout -1 to splats.
> >
> > * gcc.dg/vect/pr106081.c: New testcase.
> :-) Glad to see how easy this ended up being after the work you put
> into pushing permutes around a couple years ago.
And of course Richard S. refactoring and improving this a lot after
that.
Richard.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] tree-optimization/106081 - elide redundant permute
@ 2023-07-26 13:27 Richard Biener
0 siblings, 0 replies; 3+ messages in thread
From: Richard Biener @ 2023-07-26 13:27 UTC (permalink / raw)
To: gcc-patches
The following patch makes sure to elide a redundant permute that
can be merged with existing splats represented as load permutations
as we now do for non-grouped SLP loads. This is the last bit
missing to fix this PR where the main fix was already done by
r14-2117-gdd86a5a69cbda4
Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
PR tree-optimization/106081
* tree-vect-slp.cc (vect_optimize_slp_pass::start_choosing_layouts):
Assign layout -1 to splats.
* gcc.dg/vect/pr106081.c: New testcase.
---
gcc/testsuite/gcc.dg/vect/pr106081.c | 33 ++++++++++++++++++++++++++++
gcc/tree-vect-slp.cc | 5 ++++-
2 files changed, 37 insertions(+), 1 deletion(-)
create mode 100644 gcc/testsuite/gcc.dg/vect/pr106081.c
diff --git a/gcc/testsuite/gcc.dg/vect/pr106081.c b/gcc/testsuite/gcc.dg/vect/pr106081.c
new file mode 100644
index 00000000000..8f97af2d642
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/vect/pr106081.c
@@ -0,0 +1,33 @@
+/* { dg-do compile } */
+/* { dg-additional-options "-ffast-math -fdump-tree-optimized" } */
+/* { dg-additional-options "-mavx2" { target x86_64-*-* i?86-*-* } } */
+/* { dg-require-effective-target vect_double } */
+/* { dg-require-effective-target vect_unpack } */
+/* { dg-require-effective-target vect_intdouble_cvt } */
+/* { dg-require-effective-target vect_perm } */
+
+struct pixels
+{
+ short a,b,c,d;
+} *pixels;
+struct dpixels
+{
+ double a,b,c,d;
+};
+
+double
+test(double *k)
+{
+ struct dpixels results={};
+ for (int u=0; u<1000*16;u++,k--)
+ {
+ results.a += *k*pixels[u].a;
+ results.b += *k*pixels[u].b;
+ results.c += *k*pixels[u].c;
+ results.d += *k*pixels[u].d;
+ }
+ return results.a+results.b*2+results.c*3+results.d*4;
+}
+
+/* { dg-final { scan-tree-dump "vectorized 1 loops" "vect" } } */
+/* { dg-final { scan-tree-dump-times "VEC_PERM" 4 "optimized" { target x86_64-*-* i?86-*-* } } } */
diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc
index e4430248ab5..a1b153035e1 100644
--- a/gcc/tree-vect-slp.cc
+++ b/gcc/tree-vect-slp.cc
@@ -4605,7 +4605,10 @@ vect_optimize_slp_pass::start_choosing_layouts ()
IFN_MASK_LOADs). */
gcc_assert (partition.layout == 0 && !m_slpg->vertices[node_i].succ);
if (!STMT_VINFO_GROUPED_ACCESS (dr_stmt))
- continue;
+ {
+ partition.layout = -1;
+ continue;
+ }
dr_stmt = DR_GROUP_FIRST_ELEMENT (dr_stmt);
imin = DR_GROUP_SIZE (dr_stmt) + 1;
tmp_perm.safe_splice (SLP_TREE_LOAD_PERMUTATION (node));
--
2.35.3
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-27 7:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230726132804.E4E863854826@sourceware.org>
2023-07-26 16:18 ` [PATCH] tree-optimization/106081 - elide redundant permute Jeff Law
2023-07-27 7:52 ` Richard Biener
2023-07-26 13:27 Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).