From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id B365C3858C60 for ; Tue, 5 Dec 2023 14:34:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B365C3858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B365C3858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::532 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701786857; cv=none; b=tfqXRcAS+TefhYgKiAur0Q39Unnt9WiYpy6fAoNyYwjS0wqy9cKsQongAVI97d8Ok7b2uQOlzwECDMARIE1osnOtvL+l9xbgkWBlXWHaK5gwkFlqEiK6nzWFfEJSnRmydZy+sX18Uv8+Wxbq7rWHxNf37bYuAAZZ9Sfunmt649w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701786857; c=relaxed/simple; bh=IvRD9Nx82xnEZX+ymQYfJx6JdtPFqYu8A2JvuKqudEI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EtAg+78edB/0kyG2u0dpdoM8XRx4wQ+D68/SiVQ7pX+hloFGyIV9uMewwn8dUnlWc0cNXqLaB2bjfTzcuioLlNM606ET2UlSyOp4yraARPRadb6+cl4+jDdvPK4OLa2+GkFg4xCpA7R3qUp74InG3LXl0NyD4t3mcAJU6gT871U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-54c74b3cd4cso6905472a12.1 for ; Tue, 05 Dec 2023 06:34:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701786854; x=1702391654; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oFczVZ5E3vRXEehFAiMs1cIb2apO3HUah29V5nlsupA=; b=CGsE/nfjUd/h1NuZyllcJVWIdhpFHsA0FkInKnA/MvrBcY9dZUMyrooJRMz7Rhu/gP InCFXoBsgN7CbC+sdT7i12AQVXMJmFklZQ0rZp8+KoIdDRyadvItXf99b4aMrCky/myR rH7w286+54m+68BswQuNZi6LDA/E27W3Jd4s5QFczUTP0iwB9b6NmcoqMl6zRLz8i9z5 uKy9KwlHWUKwDs+LXnHYlNF4f3SJDZ2VIokTmHjGSwp8t0zq1K+GXbKBOezRLLRpQXhG QYSu3kxHKADz34V66vKybmJkaNhZLqyzy3Hz+zPV0OaOsEINOaB03S4zoM/p5V5rZkQy 4vRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701786854; x=1702391654; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oFczVZ5E3vRXEehFAiMs1cIb2apO3HUah29V5nlsupA=; b=mS0R/wk9ajMDrTtHwzzSJ7B45eB1pSDgQM8uafPfdIfJWgFnPyckeXTGqzDDDNJ/Zu L5fteTF2nkBOP67VQCya+3XoFdsbrUj+Iqdtpb8uVzTRw/1v4ztrzpmKB0jvqozkZ+lP fHgqNqQHQPS+uiSGecomz5KLGGE+F20ay2+UqO7mzsNzaRJh68q+YAk58UJ3F45cYXXF GhYADFBBwglSKE66tN8By6q9bM02Is7H0VkinUEYk+kLT/SePNDVrt9mMB+8REaPBDjl IZ+rEOVSOEYAc4l8A4omGtyQHVOA+SZUsWOxaqz6Okje0mhnjBANt41Am6td5GqU6uMe OWZA== X-Gm-Message-State: AOJu0Yy3F1Keu0GshQj+3AosY2PfDSQFJaaEXjasmBESldbuPdOFsbWi VN8XyPzLTYF/HDnHy//JB+s= X-Google-Smtp-Source: AGHT+IHJMcRszd6kftWMOmJgRZn95D3/qdw5eRnQQ3xUMYVfmEjd7zuGtDKPECyreTlKXpsG7A6i1w== X-Received: by 2002:a50:d0ce:0:b0:54c:6f19:6a9d with SMTP id g14-20020a50d0ce000000b0054c6f196a9dmr1807063edf.10.1701786854168; Tue, 05 Dec 2023 06:34:14 -0800 (PST) Received: from [192.168.1.23] (ip-149-172-150-237.um42.pools.vodafone-ip.de. [149.172.150.237]) by smtp.gmail.com with ESMTPSA id b20-20020aa7cd14000000b0054c8f7708c9sm1163185edw.79.2023.12.05.06.34.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 06:34:13 -0800 (PST) Message-ID: Date: Tue, 5 Dec 2023 15:34:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, kito.cheng@gmail.com, kito.cheng@sifive.com, jeffreyalaw@gmail.com Subject: Re: [PATCH] RISC-V: Block VLSmodes according to TARGET_MAX_LMUL and BITS_PER_RISCV_VECTOR Content-Language: en-US To: Juzhe-Zhong , gcc-patches@gcc.gnu.org References: <20231205125727.1805615-1-juzhe.zhong@rivai.ai> From: Robin Dapp In-Reply-To: <20231205125727.1805615-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Yes, makes sense. Just one clarifying question. > + { > + if (GET_MODE_CLASS (vls_mode) != MODE_VECTOR_BOOL > + && !ordered_p (TARGET_MAX_LMUL * BITS_PER_RISCV_VECTOR, > + GET_MODE_PRECISION (vls_mode))) > + /* We enable VLS modes which are aligned with TARGET_MAX_LMUL and > + BITS_PER_RISCV_VECTOR. > + > + e.g. When TARGET_MAX_LMUL = 1 and BITS_PER_RISCV_VECTOR = (128,128). > + We enable VLS modes have fixed size <= 128bit. Since ordered_p is > + false between VLA modes with size = (128, 128) bits and VLS mode > + with size = 128 bits, we will end up with multiple ICEs in > + middle-end generic codes. */ > + return false; > + return true; > + } Wouldn't maybe_gt on the mode precision already suffice? I.e. do we need the ordered_p and the exclusion for masks? (Sure, masks never exceed one register anyway.) Couldn't we exclude all VLS modes that exceed our minimum vector size? Or will this exclude too many? And could we move this to vls_mode_valid_p? We already do similar checks for fixed_vlmax there. Regards Robin