From: Paolo Carlini <paolo.carlini@oracle.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Marek Polacek <polacek@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jason Merrill <jason@redhat.com>
Subject: Re: [C++ Patch] One more DECL_SOURCE_LOCATION
Date: Fri, 11 Oct 2019 15:58:00 -0000 [thread overview]
Message-ID: <a38228d5-e3ed-ff66-24ba-705fb680e60b@oracle.com> (raw)
In-Reply-To: <20191011155235.GU15914@tucnak>
Hi,
On 11/10/19 17:52, Jakub Jelinek wrote:
> On Fri, Oct 11, 2019 at 05:34:16PM +0200, Paolo Carlini wrote:
>> Hi again...
>>
>> On 11/10/19 17:30, Paolo Carlini wrote:
>>> Oh nice, I wasn't aware of that, to be honest, probably we should audit
>>> the front-end for more such redundant uses.
>> ... and I can confirm that we have *many*. If we agree that removing all of
>> them is the way to go I can do that in a follow up patch.
> If they just guard a pedwarn/warning/warning_at etc., that's fine, if they
> guard also some code that needs to compute something for the diagnostics,
> it might not be redundant.
Indeed. We got many of the very straightforward ones ;)
Paolo.
next prev parent reply other threads:[~2019-10-11 15:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 11:09 Paolo Carlini
2019-10-11 13:57 ` Marek Polacek
2019-10-11 15:14 ` Paolo Carlini
2019-10-11 15:23 ` Marek Polacek
2019-10-11 15:31 ` Paolo Carlini
2019-10-11 15:44 ` Paolo Carlini
2019-10-11 15:53 ` Jakub Jelinek
2019-10-11 15:58 ` Paolo Carlini [this message]
2019-10-11 16:17 ` Marek Polacek
2019-10-11 22:23 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a38228d5-e3ed-ff66-24ba-705fb680e60b@oracle.com \
--to=paolo.carlini@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).