public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Tom de Vries <Tom_deVries@mentor.com>, Jakub Jelinek <jakub@redhat.com>
Cc: Mike Stump <mikestump@comcast.net>,
	Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
	Richard Biener <richard.guenther@gmail.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [testsuite] Add missing dg-require-effective-target alloca to gcc testsuite
Date: Fri, 28 Apr 2017 16:28:00 -0000	[thread overview]
Message-ID: <a385abac-b7ce-d00c-01cc-4a3090412baf@redhat.com> (raw)
In-Reply-To: <57fe5b00-f121-1b0c-5515-5267b4b08002@mentor.com>

On 04/27/2017 04:04 PM, Tom de Vries wrote:
> On 04/26/2017 01:57 PM, Jakub Jelinek wrote:
>> I guess those should be decided case by case
>> whether we want relative, absolute or saved line numbers.  If the
>> diagnostic is within the same function or code block as the stuff it is
>> relative to, relative is fine, but if e.g. the messages are just at 
>> the end
>> of file and there are unrelated functions in between, it is not a good 
>> idea
> 
> I've written attached patches:
> - replace absolute linenrs in objc.dg,obj-c++.dg
> - replace absolute linenrs in gfortran.dg
> and tested them on x86_64 with -m64/-m32.
> 
> OK for trunk?
> 
> Thanks,
> - Tom
> 
> 0001-Replace-absolute-linenrs-in-objc.dg-obj-c-.dg.patch
> 
> 
> Replace absolute linenrs in objc.dg,obj-c++.dg
> 
> 2017-04-25  Tom de Vries<tom@codesourcery.com>
> 
> 	* obj-c++.dg/bitfield-1.mm: Replace absolute linenrs.
> 	* obj-c++.dg/bitfield-4.mm: Same.
> 	* obj-c++.dg/bitfield-5.mm: Same.
> 	* obj-c++.dg/exceptions-3.mm: Same.
> 	* obj-c++.dg/exceptions-5.mm: Same.
> 	* obj-c++.dg/method-1.mm: Same.
> 	* obj-c++.dg/method-12.mm: Same.
> 	* obj-c++.dg/method-13.mm: Same.
> 	* obj-c++.dg/method-15.mm: Same.
> 	* obj-c++.dg/method-16.mm: Same.
> 	* obj-c++.dg/property/at-property-18.mm: Same.
> 	* obj-c++.dg/property/at-property-25.mm: Same.
> 	* obj-c++.dg/property/at-property-5.mm: Same.
> 	* obj-c++.dg/property/dynamic-2.mm: Same.
> 	* obj-c++.dg/property/property-neg-3.mm: Same.
> 	* obj-c++.dg/protocol-inheritance-1.mm: Same.
> 	* obj-c++.dg/protocol-inheritance-2.mm: Same.
> 	* obj-c++.dg/syntax-error-1.mm: Same.
> 	* obj-c++.dg/try-catch-13.mm: Same.
> 	* objc.dg/bitfield-4.m: Same.
> 	* objc.dg/class-1.m: Same.
> 	* objc.dg/method-11.m: Same.
> 	* objc.dg/method-6.m: Same.
> 	* objc.dg/method-7.m: Same.
> 	* objc.dg/method-9.m: Same.
> 	* objc.dg/missing-proto-3.m: Same.
> 	* objc.dg/naming-2.m: Same.
> 	* objc.dg/property/at-property-16.m: Same.
> 	* objc.dg/property/at-property-18.m: Same.
> 	* objc.dg/property/at-property-25.m: Same.
> 	* objc.dg/property/at-property-5.m: Same.
> 	* objc.dg/property/dynamic-2.m: Same.
> 	* objc.dg/property/property-neg-3.m: Same.
> 	* objc.dg/protocol-inheritance-1.m: Same.
> 	* objc.dg/protocol-inheritance-2.m: Same.
OK.
jeff

  reply	other threads:[~2017-04-28 15:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 15:46 Tom de Vries
2017-03-23 16:24 ` Thomas Schwinge
2017-03-23 16:51   ` Tom de Vries
2017-03-23 17:45 ` Mike Stump
2017-03-24  7:46   ` Tom de Vries
2017-03-24 12:43     ` Rainer Orth
2017-03-24 12:44       ` Richard Biener
2017-03-24 12:53         ` Rainer Orth
2017-03-24 13:04           ` Rainer Orth
2017-03-24 17:45             ` Mike Stump
2017-03-27 14:14               ` Tom de Vries
     [not found]                 ` <d453445e-54be-d3b5-cc27-d73bdbcc855d@mentor.com>
2017-04-26 12:40                   ` Tom de Vries
2017-04-26 12:50                     ` Jakub Jelinek
2017-04-27  9:03                       ` Tom de Vries
2017-04-28  8:23                         ` Tom de Vries
2017-04-28 14:31                         ` Tom de Vries
2017-04-28  1:35                       ` Tom de Vries
2017-04-28 16:28                         ` Jeff Law [this message]
2017-03-27 13:11       ` Tom de Vries
2017-03-28  8:51 ` Thomas Schwinge
2017-03-28  8:57   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a385abac-b7ce-d00c-01cc-4a3090412baf@redhat.com \
    --to=law@redhat.com \
    --cc=Tom_deVries@mentor.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=mikestump@comcast.net \
    --cc=richard.guenther@gmail.com \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).