From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o92.zoho.com (sender4-pp-o92.zoho.com [136.143.188.92]) by sourceware.org (Postfix) with ESMTPS id A8B1D388187A; Thu, 27 Jun 2024 21:53:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A8B1D388187A Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A8B1D388187A Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.92 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1719525216; cv=pass; b=jlfhcz/1z9MWzKcJDYVF1Rgm0sp3ogovgy/qba4eWX9a0oNP6th4/CSWRQfKpQHH3vPwZDPuXH4jIZYGXCTEkVr3Hg3ac4lLif4scm7qd/Qo/FEq8myExEgi4cUwHsYs3onfnEs7qoC/fpwClJcGwSn2XV3G2ZtCMFxXNOp0ZaA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1719525216; c=relaxed/simple; bh=kVmk5veXKgSDrQQRhDuN6GfTDcEGSZwsaQ7yE0740vI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=onbm5Gzd3pZp1dY9MLVrYGRLgtSSiJav+KyKqL//3MuojQ4EvlrtI/nWOqxkiejR6xkAIGw/3OqAi86s0/vhXrRrN+RdllDLBWhmU6Td6UYBb0ARzJMcaOI5BzfDO9+Ckg3NB7aVaqoJU/VPBNoxcfkZv19IpD9eydbAyaxJH+s= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1719525207; cv=none; d=zohomail.com; s=zohoarc; b=evQyc7PqH0PR+Uad+hFUnNzSxQCbuTgf2Xbjk3mxYaGu/xG55GPMpgiYCVSKtbLix3W9M3TRlHCBzqnnAkjpO8M6Tuxvrc64wyh0J3+eSThGf1bOa4X05r5CJJXulSVW/L3uVnaEs1L99tUbM4HBwSKHl0hXUBdew6H06I9jH+A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1719525207; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=1K/3wz5mZRmurRgiKOoNqzwFip0DiS3eunewdMoKyOo=; b=JzfIzDf9vAr6+gdyDkvButdf5rfTLUqSLXPG62EJIM6PxOXSkw+oHNgzrabJ+7nCJX1tLImIavETw2SKbMaAKX8sTY8pqm/7rS74iHZSY82A1qrHsHgs9AqBiKdLso0//EvclmcBt4P8229wh95hCUEKVFx7ajrpUj+z//hGYn4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1719525207; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID:Message-Id:Reply-To:Cc; bh=1K/3wz5mZRmurRgiKOoNqzwFip0DiS3eunewdMoKyOo=; b=KVkhgOzES616rzeSqddq79e6ST4WljigygO3IpExH4jsvE2hpM7TxOEAlIOqBbIO lixcolcuHbs76btNsOmtWZUac0xYXDP7+rmarSirxgpi4iEGiBbPIgPzBbdMFZrvN+7 VXMPxOAJ8pw46+G0FcG65BDIQyuU43D0PH82zL/8= Received: by mx.zohomail.com with SMTPS id 1719525205965129.45192428288487; Thu, 27 Jun 2024 14:53:25 -0700 (PDT) Message-ID: Date: Thu, 27 Jun 2024 17:53:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] libgccjit: Make new_array_type take unsigned long To: David Malcolm , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org References: <2660ad377160743a11f73345771fae8fdb7880ac.camel@zoho.com> <04836ac8aa62ee9e67e4a40bb074d55f54d23402.camel@redhat.com> <19b40a98bc66aadb7f52f369d82b06d7f6f08802.camel@zoho.com> <4ecf6c4be38aa5aa019d74e249457197e1d79337.camel@zoho.com> <8d6aef3dac729d75ace67d369ef059a21958b3f6.camel@redhat.com> Content-Language: en-US, fr From: Antoni Boucher In-Reply-To: <8d6aef3dac729d75ace67d369ef059a21958b3f6.camel@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Feedback-ID: rr0801122857ccf11f10ec91ccd800b582000007d8ac2eed593c9f6c9e58f8862cc1f91e2043b13cd307549425:zu08011226609123e26422eb7badf9f4b600008425f33e15e58550e33c78d62a371f618064dc7fc03f2d08:rf0801122c6af274375dca10fa48e7747b0000a02d0084611c10556b6b0b1501ece108f3bd95d4e527c54face9a3c38186:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks for the review. I'm a bit concerned about using unsigned long. Would it be OK if I change the type to uint64_t? I could rename the function to gcc_jit_context_new_array_type_u64. Regards. Le 2024-06-26 à 11 h 34, David Malcolm a écrit : > On Fri, 2024-02-23 at 09:55 -0500, Antoni Boucher wrote: >> I had forgotten to add the doc since there is now a new API. >> Here it is. > > Sorry for the delay; the updated patch looks good to me (but may need > usual ABI tag changes when pushing). > > Thanks > Dave > > >> >> On Wed, 2024-02-21 at 19:45 -0500, Antoni Boucher wrote: >>> Thanks for the review. >>> >>> Here's the updated patch. >>> >>> On Thu, 2023-12-07 at 20:04 -0500, David Malcolm wrote: >>>> On Thu, 2023-12-07 at 17:29 -0500, Antoni Boucher wrote: >>>>> Hi. >>>>> This patches update gcc_jit_context_new_array_type to take the >>>>> size >>>>> as >>>>> an unsigned long instead of a int, to allow creating bigger >>>>> array >>>>> types. >>>>> >>>>> I haven't written the ChangeLog yet because I wasn't sure it's >>>>> allowed >>>>> to change the type of a function like that. >>>>> If it isn't, what would you suggest? >>>> >>>> We've kept ABI compatibility all the way back to the version in >>>> GCC >>>> 5, >>>> so it seems a shame to break ABI. >>>> >>>> How about a new API entrypoint: >>>>   gcc_jit_context_new_array_type_unsigned_long >>>> whilst keeping the old one. >>>> >>>> Then everything internally can use "unsigned long"; we just keep >>>> the >>>> old entrypoint accepting int (which internally promotes the arg >>>> to >>>> unsigned long, if positive, sharing all the implementation). >>>> >>>> Alternatively, I think there may be a way to do this with symbol >>>> versioning: >>>>   https://gcc.gnu.org/wiki/SymbolVersioning >>>> see e.g. Section 3.7 of Ulrich Drepper's "How To Write Shared >>>> Libraries", but I'm a bit wary of cross-platform compatibility >>>> with >>>> that. >>>> >>>> Dave >>>> >>>> >>> >> >