From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87639 invoked by alias); 21 Nov 2017 07:49:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 87600 invoked by uid 89); 21 Nov 2017 07:49:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Nov 2017 07:49:45 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7763D75717; Tue, 21 Nov 2017 07:49:44 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-12.rdu2.redhat.com [10.10.112.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 862435C552; Tue, 21 Nov 2017 07:49:43 +0000 (UTC) Subject: Re: [102/nnn] poly_int: vect_permute_load/store_chain To: gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org References: <871sltvm7r.fsf@linaro.org> <87k1zldann.fsf@linaro.org> From: Jeff Law Message-ID: Date: Tue, 21 Nov 2017 08:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <87k1zldann.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg01857.txt.bz2 On 10/23/2017 11:41 AM, Richard Sandiford wrote: > The GET_MODE_NUNITS patch made vect_grouped_store_supported and > vect_grouped_load_supported check for a constant number of elements, > so vect_permute_store_chain and vect_permute_load_chain can assert > for that. This patch adds commentary to that effect; the actual > asserts will be added by a later, more mechanical, patch. > > The patch also reorganises the function so that the asserts > are linked specifically to code that builds permute vectors > element-by-element. This allows a later patch to add support > for some variable-length permutes. > > > 2017-10-23 Richard Sandiford > Alan Hayward > David Sherwood > > gcc/ > * tree-vect-data-refs.c (vect_permute_store_chain): Reorganize > so that both the length == 3 and length != 3 cases set up their > own permute vectors. Add comments explaining why we know the > number of elements is constant. > (vect_permute_load_chain): Likewise. This is OK. Obviously it can't go in until if/when the whole it is ack'd. Jeff