From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 12FC33858421 for ; Mon, 24 Oct 2022 15:21:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 12FC33858421 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x429.google.com with SMTP id g16so3793195pfr.12 for ; Mon, 24 Oct 2022 08:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mGvlDng/u9U1i85Y9omt7iUTgShUASUcfp2exrFYh9s=; b=EPv8mUubvPNwXujdsr9UxPWMUWRgfoYDbXY4HQvs6ZueeFjN4KdYZNChGg3TwO5n+o iEk+PSMROVmYgMB2LL7xb9wW4n7XUoNfxN45um5CzBuuq20HarFD/xKyYGBd6iyC8P0S s5WuLTYPtlmL7H6yZ1Afm7pHAQHLhmHKNZ/vH4V333uMWuLv4XSwFAyK3yYweQsYm2Gv yZEtEc/gLqU33VWtlsuT0QEa7T+FEN/ZCkHHSrYXtqePE0pcvnASf+t42GsVOQ9+CUCq p/8rkI4iI7Nx1ddtskhLCbrx1zuPROY/6EOBQINtFGclwshjkHaiGGFcDTo4SSJa3sDT MsUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mGvlDng/u9U1i85Y9omt7iUTgShUASUcfp2exrFYh9s=; b=Sp9D63MXmA/ABhBDdD96kSauyCJeX1U3LDV64tOt48AkA5cc76t/ugwKp/EGr5jHck XRO2exia5/QHPlGX3vh0/B5gDpoF//8cQ9HPNEhGkkROph3YPW4MZNRxw4nXz8k4jj63 PqssEpf1a53niAdo+fdhVqpWW3ufvNxkaLkSG6qe6QtuuUGLCHGjEgtgYrGz+G5RVMqu LoR2c06uPF1FkQrp6KU51avg9gBE3MXMdsjpaJLGxrY/ug8vFlhPVzne+3GAW4sNAtB2 7lPGF1vrvPPml8R2fq73hPvZR8nQADgYexxxirunfSxlEwSvl4GUyHp3ePCscZvD6IvP Sinw== X-Gm-Message-State: ACrzQf1HZb0gs25+zFHistW0J4drVRcoq0wtYczzQAs/pr1YQqUAT3CN lky61+Z8hjsQi7LNDgXf3tXLztF4YuU= X-Google-Smtp-Source: AMsMyM7YJhX7prVTmvz4M5btRWhwVfE4hOMcYciCU9YTrzHs5cNx2gj2siXndHFGJp9KWUy2s2Kh0g== X-Received: by 2002:a05:6a00:1389:b0:566:1549:c5bc with SMTP id t9-20020a056a00138900b005661549c5bcmr34350545pfg.8.1666624873664; Mon, 24 Oct 2022 08:21:13 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id c3-20020a170902d48300b001781a7c28b9sm19498938plg.240.2022.10.24.08.21.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Oct 2022 08:21:12 -0700 (PDT) Message-ID: Date: Mon, 24 Oct 2022 09:21:11 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH RFA] tree: add build_string_literal overloads Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20221020202053.3389227-1-jason@redhat.com> From: Jeff Law In-Reply-To: <20221020202053.3389227-1-jason@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/20/22 14:20, Jason Merrill via Gcc-patches wrote: > Tested x86_64-pc-linux-gnu, OK for trunk? > > -- >8 -- > > Simplify several calls to build_string_literal by not requiring redundant > strlen or IDENTIFIER_* in the caller. > > I also corrected a wrong comment on IDENTIFIER_LENGTH. > > gcc/ChangeLog: > > * tree.h (build_string_literal): New one-argument overloads that > take tree (identifier) and const char *. > * builtins.cc (fold_builtin_FILE) > (fold_builtin_FUNCTION) > * gimplify.cc (gimple_add_init_for_auto_var) > * vtable-verify.cc (verify_bb_vtables): Simplify calls. > > gcc/cp/ChangeLog: > > * cp-gimplify.cc (fold_builtin_source_location) > * vtable-class-hierarchy.cc (register_all_pairs): Simplify calls to > build_string_literal. > (build_string_from_id): Remove. OK jeff