From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5C83B383F965 for ; Fri, 24 Jun 2022 18:19:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C83B383F965 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-548-e7QspSDaNC2IIzvPHtVRzg-1; Fri, 24 Jun 2022 14:19:41 -0400 X-MC-Unique: e7QspSDaNC2IIzvPHtVRzg-1 Received: by mail-qk1-f199.google.com with SMTP id ay8-20020a05620a178800b006a76e584761so3430947qkb.13 for ; Fri, 24 Jun 2022 11:19:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=rIR1ruJBUUHlHnlqxPtlAaxoE5JMYBIT2d8E03pD28c=; b=0SUAGLzss541oHu/iZBewgRG0xwNYgEon5ZVqsHQ4xJdGzvsN77aIiLSi5RkZLVWt1 6SADbYbaLm1PBA5Xo6/iAIBeGugphWJZ9VJPatrwrs3OEBrTGIZGYeZ8t2OUQRtQlszR 0E7aaJOeqHt+m/Yhv4SWy041t1+ZJ3t6anCdglddFGzjjppCIqgVxS0O5xN+7b4MwxXs OS8zysPRvn9ETjjMLZYd+k7YbS41LLUzgoNoWR46s/zkPEsMjF1YZ7gyj9z7LjFJWKGk V3nmOwBWGF7Or5w+Ga/j2/SwsnelULJ+8kvBAdl44/t3vXSDh8qUn/Blr1ISS9ggPb1Q 6lvQ== X-Gm-Message-State: AJIora9WoshYklnxX/MSzY9gtmxjfMO0LtmpmcucPifdgEkUlqw3IHZs mw/HyxXem+A9BT5QTezBDHZ0rj/eRskWe4SJezMGKtN8NGdAnADwqEx1c4f9KY16hs556ATp+u4 09yyszxwRhIly3pBLj7LNXx/PQ8+w4pJWTcgdqzMqUWKpu3ArTRQuwtmh2hWYXlHENC9FjQ== X-Received: by 2002:ac8:5b0e:0:b0:306:6c7c:efe3 with SMTP id m14-20020ac85b0e000000b003066c7cefe3mr178262qtw.633.1656094779915; Fri, 24 Jun 2022 11:19:39 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s2/SM3gc1qS8mXZvBiMukad8dQ6IcrUcdJoFC7Is83IbzRq9A/VObrqFZhGheoPWfKP2OHOg== X-Received: by 2002:ac8:5b0e:0:b0:306:6c7c:efe3 with SMTP id m14-20020ac85b0e000000b003066c7cefe3mr178237qtw.633.1656094779609; Fri, 24 Jun 2022 11:19:39 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id j13-20020a05620a288d00b006a3325fd985sm2520102qkp.13.2022.06.24.11.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 11:19:38 -0700 (PDT) Message-ID: Subject: PING^2 : Re: [PATCH 08/10] i386: add 'final' and 'override' to scalar_chain vfunc impls From: David Malcolm To: gcc-patches@gcc.gnu.org, Jan Hubicka , Uros Bizjak Date: Fri, 24 Jun 2022 14:19:38 -0400 In-Reply-To: References: <20220523192834.3785673-1-dmalcolm@redhat.com> <20220523192834.3785673-9-dmalcolm@redhat.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 18:19:43 -0000 I'd like to ping this patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595440.html OK for trunk? Thanks Dave On Mon, 2022-06-13 at 14:30 -0400, David Malcolm wrote: > Ping for this patch: >   https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595440.html > > OK for trunk? > > Thanks > Dave > > On Mon, 2022-05-23 at 15:28 -0400, David Malcolm wrote: > > gcc/ChangeLog: > >         * config/i386/i386-features.h: Add "final" and "override" to > >         scalar_chain vfunc implementations as appropriate. > > > > Signed-off-by: David Malcolm > > --- > >  gcc/config/i386/i386-features.h | 16 ++++++++-------- > >  1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/gcc/config/i386/i386-features.h b/gcc/config/i386/i386- > > features.h > > index 5c307607ae5..f46a6d95b74 100644 > > --- a/gcc/config/i386/i386-features.h > > +++ b/gcc/config/i386/i386-features.h > > @@ -169,18 +169,18 @@ class general_scalar_chain : public > > scalar_chain > >   public: > >    general_scalar_chain (enum machine_mode smode_, enum machine_mode > > vmode_); > >    ~general_scalar_chain (); > > -  int compute_convert_gain (); > > +  int compute_convert_gain () final override; > >   private: > >    hash_map defs_map; > >    bitmap insns_conv; > >    unsigned n_sse_to_integer; > >    unsigned n_integer_to_sse; > > -  void mark_dual_mode_def (df_ref def); > > -  void convert_insn (rtx_insn *insn); > > +  void mark_dual_mode_def (df_ref def) final override; > > +  void convert_insn (rtx_insn *insn) final override; > >    void convert_op (rtx *op, rtx_insn *insn); > >    void convert_reg (rtx_insn *insn, rtx dst, rtx src); > >    void make_vector_copies (rtx_insn *, rtx); > > -  void convert_registers (); > > +  void convert_registers () final override; > >    int vector_const_cost (rtx exp); > >  }; > >   > > @@ -190,14 +190,14 @@ class timode_scalar_chain : public scalar_chain > >    timode_scalar_chain () : scalar_chain (TImode, V1TImode) {} > >   > >    /* Convert from TImode to V1TImode is always faster.  */ > > -  int compute_convert_gain () { return 1; } > > +  int compute_convert_gain () final override { return 1; } > >   > >   private: > > -  void mark_dual_mode_def (df_ref def); > > +  void mark_dual_mode_def (df_ref def) final override; > >    void fix_debug_reg_uses (rtx reg); > > -  void convert_insn (rtx_insn *insn); > > +  void convert_insn (rtx_insn *insn) final override; > >    /* We don't convert registers to difference size.  */ > > -  void convert_registers () {} > > +  void convert_registers () final override {} > >  }; > >   > >  } // anon namespace >